From patchwork Tue Apr 4 10:11:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19810 Received: (qmail 41291 invoked by alias); 4 Apr 2017 10:11:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41262 invoked by uid 89); 4 Apr 2017 10:11:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0077.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 10:11:44 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0102.eurprd08.prod.outlook.com (10.160.211.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Tue, 4 Apr 2017 10:11:42 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d%16]) with mapi id 15.01.1005.018; Tue, 4 Apr 2017 10:11:42 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: [PATCH 1/11] Add ARM_MAX_REGISTER_SIZE Date: Tue, 4 Apr 2017 10:11:42 +0000 Message-ID: authentication-results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0102; 7:9kRtXkjDmW0tzwb04j51zH4yWCZa0m855e4DFIQAnwmVKhLEa94Fl9OicpRPQ8Wr8+3zTJkbpF7TCltN7Lp6mwsbrPXD0h7psniR4vGfax2ZaLHvE0RPpK4GD9AZpm9c0OGKBcPtz5UpiNVxidte5jr9Q/lhwfupClJv+N/OWG1whgRJrNzY2j0gfaLItRbqQQ1aGLr7gNXJ8uuY4nIQGEAOGx6q1kToC67OoUvxkqs3dIyRp0rVY9uZ4Bp3qGlj5dCk72oTsZ1gjEpCM6aYMjQbiXWoy9ndafkySnjcNdAPH9SW6+H64rKrMPK7hFxCvo+a/UjEpsbVheRMvpPpzA==; 20:tZp2NrpqoN+nAOGLvmndfz4ZLWVi0eu7EO6CSm5JQPdnAk5uWWY08EqvwfxX8coc3Wnib7fl27/vsIrYh2YnlVdiz17lg5r44elCu+8QxVES6aWvk1ze0axlZD9/PSTpUEfjHSzQEFStZ+qTIaW56/3+qjWbT3b7HRchjUt2qCI= x-ms-office365-filtering-correlation-id: 49364263-613c-4d95-cc38-08d47b42fdf0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM3PR08MB0102; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:AM3PR08MB0102; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0102; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39450400003)(39850400002)(39400400002)(39840400002)(377424004)(8936002)(2351001)(4326008)(81166006)(8676002)(25786009)(6916009)(5250100002)(575784001)(2906002)(86362001)(50986999)(33656002)(2900100001)(54356999)(189998001)(3660700001)(3846002)(110136004)(38730400002)(6486002)(83716003)(6506006)(66066001)(36756003)(7736002)(99286003)(5660300001)(5640700003)(82746002)(6436002)(53936002)(6116002)(305945005)(3280700002)(6512007)(102836003)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0102; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <49D2454C86389D4E8DDB6C6A257C3A54@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2017 10:11:42.1164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0102 Max size set to 96bits, which is taken from FP_REGISTER_SIZE Tested on a --enable-targets=all build using make check with board files unix and native-gdbserver. Ok to commit? Alan. 2017-04-04 Alan Hayward * arm-tdep.c (arm_store_return_value): Use ARM_MAX_REGISTER_SIZE. * arm-tdep.h: Add ARM_MAX_REGISTER_SIZE. diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h index 8125226362e5a9c155b60ffd1fbd4ed839270493..20bcda9dcc554c7d613d6534f5b3cf9a59dfa975 100644 --- a/gdb/arm-tdep.h +++ b/gdb/arm-tdep.h @@ -38,6 +38,9 @@ struct gdb_get_next_pcs; purposes and code readability. These are fixed at 64 bits. */ #define VFP_REGISTER_SIZE 8 +/* Big enough to hold the size of the largest register in bytes. */ +#define ARM_MAX_REGISTER_SIZE FP_REGISTER_SIZE + /* Number of machine registers. The only define actually required is gdbarch_num_regs. The other definitions are used for documentation purposes and code readability. */ diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 88ed391729813dc4ef8e4dccb6698fa798e0de08..6b544481627678f2b6442725573b02d4e4cd9f2d 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -8153,7 +8153,7 @@ arm_store_return_value (struct type *type, struct regcache *regs, if (TYPE_CODE (type) == TYPE_CODE_FLT) { - gdb_byte buf[MAX_REGISTER_SIZE]; + gdb_byte buf[ARM_MAX_REGISTER_SIZE]; switch (gdbarch_tdep (gdbarch)->fp_model) {