From patchwork Sat Nov 15 19:44:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 3770 Received: (qmail 32135 invoked by alias); 15 Nov 2014 19:44:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 32125 invoked by uid 89); 15 Nov 2014 19:44:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f52.google.com Received: from mail-yh0-f52.google.com (HELO mail-yh0-f52.google.com) (209.85.213.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 15 Nov 2014 19:44:19 +0000 Received: by mail-yh0-f52.google.com with SMTP id z6so2920913yhz.39 for ; Sat, 15 Nov 2014 11:44:17 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.236.15.68 with SMTP id e44mr17332296yhe.37.1416080657080; Sat, 15 Nov 2014 11:44:17 -0800 (PST) Received: by 10.170.81.68 with HTTP; Sat, 15 Nov 2014 11:44:17 -0800 (PST) In-Reply-To: <1415990846-9482-1-git-send-email-arnez@linux.vnet.ibm.com> References: <1415990846-9482-1-git-send-email-arnez@linux.vnet.ibm.com> Date: Sat, 15 Nov 2014 11:44:17 -0800 Message-ID: Subject: Re: [PATCH 0/3] Fix fallout from GDB testsuite cleanup, fix more compiler warnings From: Doug Evans To: Andreas Arnez Cc: "gdb-patches@sourceware.org" X-IsSubscribed: yes On Fri, Nov 14, 2014 at 10:47 AM, Andreas Arnez wrote: > It seems that my earlier testsuite cleanup has left some test cases in > a broken state. The first two patches fix (at least some of) these. > I'm sorry for the breakage and hope that I didn't miss anything else. > > The third patch fixes some more compiler warnings I've overlooked > before. > > Andreas Arnez (3): > Drop remaining references to removed source lines in break1.c and > ur1.c > Eliminate literal line numbers in mi-until.exp > GDB testsuite: More fixes for warnings with -std=gnu11 > > gdb/testsuite/gdb.base/bp-permanent.c | 1 + > gdb/testsuite/gdb.base/condbreak.exp | 28 ++++++++++++---------------- > gdb/testsuite/gdb.base/ena-dis-br.exp | 26 +++++++++++--------------- > gdb/testsuite/gdb.base/hbreak2.exp | 25 ++++++++----------------- > gdb/testsuite/gdb.mi/mi-until.exp | 23 +++++++++++++++-------- > gdb/testsuite/gdb.mi/until.c | 10 +++++----- > gdb/testsuite/gdb.python/py-framefilter-mi.c | 3 ++- > gdb/testsuite/gdb.python/py-framefilter.c | 3 ++- > gdb/testsuite/gdb.reverse/until-precsave.exp | 6 +++--- > gdb/testsuite/gdb.reverse/until-reverse.exp | 6 +++--- > gdb/testsuite/gdb.trace/actions-changed.c | 3 +++ > 11 files changed, 65 insertions(+), 69 deletions(-) Hi. This patch set is ok. Please commit ASAP. :-) No worries on the breakage ... live and learn ... And besides, thanks very much for taking this on! btw, the following violates the coding standards. We're trying to be follow them more closely in the testsuite. I don't mind it, but you might as well fix them. [function result type goes on a line by itself] diff --git a/gdb/testsuite/gdb.python/py-framefilter-mi.c b/gdb/testsuite/gdb.python/py-framefilter-mi.c index 242efa1..2955b71 100644 --- a/gdb/testsuite/gdb.python/py-framefilter-mi.c +++ b/gdb/testsuite/gdb.python/py-framefilter-mi.c @@ -132,7 +132,8 @@ int func5(int f, int d) return i; } -main() +int main() { func5(3,5); + return 0; } diff --git a/gdb/testsuite/gdb.python/py-framefilter.c b/gdb/testsuite/gdb.python/py-framefilter.c index 80087c2..3102dda 100644 --- a/gdb/testsuite/gdb.python/py-framefilter.c +++ b/gdb/testsuite/gdb.python/py-framefilter.c @@ -146,10 +146,11 @@ int func5(int f, int d) return i; } -main() +int main() { int z = 32; int y = 44; const char *foo1 = "Test"; func5(3,5); + return 0; }