[2/4] Save plain text in the source cache
Commit Message
On Tue, Oct 22, 2019 at 4:39 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, Jul 26, 2019 at 6:34 AM Tom Tromey <tromey@adacore.com> wrote:
> >
> > Currently the source cache will only store highlighted text. However,
> > there's no reason it could not also store plain text, when styling is
> > turned off.
> >
> > This patch makes this change. This also simplifies the source cache
> > code somewhat.
> >
> > gdb/ChangeLog
> > 2019-07-26 Tom Tromey <tromey@adacore.com>
> >
> > * source-cache.c (source_cache::get_plain_source_lines):
> > Remove "first_line" and "last_line" parameters.
> > (source_cache::get_source_lines): Cache plain text.
> > * source-cache.h (class source_cache)
> > <get_plain_source_lines>: Update.
>
> This caused:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=25126
>
>
This works for my test case.
Comments
On Okt 23 2019, H.J. Lu wrote:
> + /* Clear the staled source cache. */
s/staled/stale/
Andreas.
> This works for my test case.
Thank you.
This is ok with a ChangeLog entry, and with a fix for the typo that
Andreas pointed out.
Tom
@@ -2518,6 +2518,9 @@ reread_symbols (void)
automatically recreated by sym_read. */
free_objfile_separate_debug (objfile);
+ /* Clear the staled source cache. */
+ forget_cached_source_info ();
+
/* Remove any references to this objfile in the global
value lists. */
preserve_values (objfile);