diff mbox series

gdb: Remove inappropriate comments

Message ID CAKxEfiwjfHicuN3h3Es6ntGST9qH-h7t-zBOgS1ikku+9hy6eA@mail.gmail.com
State New
Headers
Series gdb: Remove inappropriate comments |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Charles Baylis Nov. 18, 2024, 10:27 p.m. UTC 
  Hi,

I was browsing the gdb source code, and found some inappropriate comments.
They've been around a while, but it's not the sort of thing that fosters a
welcoming environment.

This is a trivial patch which removes those comments.

I don't have a copyright assignment, but hopefully that's not necessary for
this sort of change.

Thanks
Charles

Comments

Tom de Vries Nov. 19, 2024, 10:05 a.m. UTC | #1 
On 11/18/24 23:27, Charles Baylis wrote:
> 
> Hi,
> 
> I was browsing the gdb source code, and found some inappropriate 
> comments. They've been around a while, but it's not the sort of thing 
> that fosters a welcoming environment.
> 
> This is a trivial patch which removes those comments.

Hi Charles,

thanks for the patch.

I think this is a good change, and I'd expect it to be non-controversial 
after this outcome ( 
https://sourceware.org/git/?p=glibc.git;a=commit;h=7f0e1933f08d52b22b02fdcd075382506f7b2e9c 
).

> I don't have a copyright assignment, but hopefully that's not necessary 
> for this sort of change.

The patch is small enough to not count as a "Legally Significant Change" 
( https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html ) 
and AFAICT requires no copyright assignment.

But if you'd like to contribute more, then please do consider getting a 
copyright assignment (the process can be slow, apologies beforehand).

I've posted a v2 ( 
https://sourceware.org/pipermail/gdb-patches/2024-November/213407.html 
), with you as author, with the "Copyright-paperwork-exempt: yes" tag 
added, and added a small description and mentioned how it was tested (by 
me).

I'll wait for a week before pushing.

Thanks again for the patch.

- Tom
diff mbox series

Patch

From db205955987821fd99d243f1cb6686974f47c51b Mon Sep 17 00:00:00 2001
From: Charles Baylis <cbaylis@undo.io>
Date: Mon, 18 Nov 2024 19:10:12 +0000
Subject: [PATCH] gdb: Remove inappropriate comments

---
 gdb/darwin-nat.c | 2 +-
 gdb/gnu-nat.c    | 2 +-
 gdb/inf-ptrace.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 7ba1fbb6775..e4243f67648 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -2032,7 +2032,7 @@  darwin_nat_target::attach (const char *args, int from_tty)
 
   pid = parse_pid_to_attach (args);
 
-  if (pid == getpid ())		/* Trying to masturbate?  */
+  if (pid == getpid ())
     error (_("I refuse to debug myself!"));
 
   target_announce_attach (from_tty, pid);
diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index 6cfac08e5ac..a8a4da1c873 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -2172,7 +2172,7 @@  gnu_nat_target::attach (const char *args, int from_tty)
 
   pid = parse_pid_to_attach (args);
 
-  if (pid == getpid ())		/* Trying to masturbate?  */
+  if (pid == getpid ())
     error (_("I refuse to debug myself!"));
 
   target_announce_attach (from_tty, pid);
diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index 36d6e2aa697..6ef2ea84562 100644
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -141,7 +141,7 @@  inf_ptrace_target::attach (const char *args, int from_tty)
 
   pid_t pid = parse_pid_to_attach (args);
 
-  if (pid == getpid ())		/* Trying to masturbate?  */
+  if (pid == getpid ())
     error (_("I refuse to debug myself!"));
 
   target_unpush_up unpusher;
-- 
2.25.1