diff mbox

src/gdb/breakpoint.c:3092: redundant test ?

Message ID CAHhXt=S4sKZQTtvi3MWNZMfAN6iRgkWHEF=r0emLWN8xjQUb_w@mail.gmail.com
State New, archived
Headers

Commit Message

יעקב שמחוני Aug. 30, 2018, 6:34 p.m. UTC 
  2018-08-30  Yacov Simhony  <ysimhony@gmail.com>

* breakpoint.c (update_inserted_breakpoint_locations): remove reduandant
condition

Comments

Kevin Buettner Sept. 4, 2018, 11:26 p.m. UTC | #1 
On Thu, 30 Aug 2018 21:34:45 +0300
<ysimhony@gmail.com> wrote:

> 2018-08-30  Yacov Simhony  <ysimhony@gmail.com>
> 
> * breakpoint.c (update_inserted_breakpoint_locations): remove reduandant
> condition

typo - s/reduandant/redundant/

Also, place a period at the end of that ChangeLog entry and make sure
it's correctly indented when you put it in the ChangeLog.

> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 4e7dac5..3a9b712 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -2898,7 +2898,7 @@ update_inserted_breakpoint_locations (void)
>        /* We only want to update locations that are already inserted
>          and need updating.  This is to avoid unwanted insertion during
>          deletion of breakpoints.  */
> -      if (!bl->inserted || (bl->inserted && !bl->needs_update))
> +      if (!bl->inserted || !bl->needs_update)
>         continue;
> 
>        switch_to_program_space_and_thread (bl->pspace);

This looks correct to me.

This is okay to push with the ChangeLog fixes noted above.

Kevin
Tom Tromey Sept. 18, 2018, 2:01 p.m. UTC | #2 
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

Kevin> This is okay to push with the ChangeLog fixes noted above.

I think Yacov probably does not have write access.

Yacov, if you can send a patch addressing the review comments, I can
check it in for you.

thanks,
Tom
diff mbox

Patch

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 4e7dac5..3a9b712 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2898,7 +2898,7 @@  update_inserted_breakpoint_locations (void)
       /* We only want to update locations that are already inserted
         and need updating.  This is to avoid unwanted insertion during
         deletion of breakpoints.  */
-      if (!bl->inserted || (bl->inserted && !bl->needs_update))
+      if (!bl->inserted || !bl->needs_update)
        continue;

       switch_to_program_space_and_thread (bl->pspace);