From patchwork Tue Oct 13 15:33:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Edelsohn X-Patchwork-Id: 9082 Received: (qmail 20371 invoked by alias); 13 Oct 2015 15:33:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20358 invoked by uid 89); 13 Oct 2015 15:33:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f182.google.com Received: from mail-ig0-f182.google.com (HELO mail-ig0-f182.google.com) (209.85.213.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 13 Oct 2015 15:33:52 +0000 Received: by igbif5 with SMTP id if5so2068654igb.1 for ; Tue, 13 Oct 2015 08:33:50 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.50.111.137 with SMTP id ii9mr20753796igb.91.1444750430388; Tue, 13 Oct 2015 08:33:50 -0700 (PDT) Received: by 10.36.133.5 with HTTP; Tue, 13 Oct 2015 08:33:50 -0700 (PDT) In-Reply-To: <20151012183438.GE3341@adacore.com> References: <20151006165157.GA3341@adacore.com> <20151010000433.GB3341@adacore.com> <20151012155021.GC3341@adacore.com> <20151012183438.GE3341@adacore.com> Date: Tue, 13 Oct 2015 11:33:50 -0400 Message-ID: Subject: Re: AIX DWARF debugging sections From: David Edelsohn To: Joel Brobecker Cc: Doug Evans , Tristan Gingold , GDB Patches On Mon, Oct 12, 2015 at 2:34 PM, Joel Brobecker wrote: >> Thanks, David >> >> * xcoffread (dwrf2_xcoff_names): Add .dwmac and .dwpbtyp. > > Looks good to me with just one nit. > the GNU Coding Standards ask us that sentences end with a period. So > unfortunately, we're going to have to split that line in two. For full sentences, we might as well document it more completely. Thanks, David { NULL, NULL }, /* eh_frame */ diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 0d49751..e4af37c 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -159,11 +159,14 @@ static const struct dwarf2_debug_sections dwarf2_xcoff_nam es = { { ".dwabrev", NULL }, { ".dwline", NULL }, { ".dwloc", NULL }, - { NULL, NULL }, /* debug_macinfo */ - { NULL, NULL }, /* debug_macro */ + /* AIX XCOFF defines one, named DWARF section for macro debug information. + XLC does not generate debug_macinfo for DWARF4 and below. + The section is assigned to debug_macro for DWARF5 and above. */ + { NULL, NULL }, + { ".dwmac", NULL }, { ".dwstr", NULL }, { ".dwrnges", NULL }, - { NULL, NULL }, /* debug_types */ + { ".dwpbtyp", NULL }, { NULL, NULL }, /* debug_addr */ { ".dwframe", NULL },