From patchwork Tue Jul 18 00:11:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Blaikie X-Patchwork-Id: 21655 Received: (qmail 16442 invoked by alias); 18 Jul 2017 00:11:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 16432 invoked by uid 89); 18 Jul 2017 00:11:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=remained X-HELO: mail-yw0-f176.google.com Received: from mail-yw0-f176.google.com (HELO mail-yw0-f176.google.com) (209.85.161.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jul 2017 00:11:55 +0000 Received: by mail-yw0-f176.google.com with SMTP id y186so100273ywc.1 for ; Mon, 17 Jul 2017 17:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=VIiwaul8ux3iz+q+mDZl2X2kyq58j1XdPfkZAQNUT5A=; b=DSwKrlnic4BWL2snRRmDIC7+NsoR4MvcN93MdQED7P7wuWOkgqUNyYzbmQRnuETho8 7mkQ+r4yV/A5kS8Bn8os2JrhN4kQ5Ze7cJyIiy08GBHXQbqkuTmZQ0tBpONZnKrSe6ku LzxK0bh4VWCa+k6YFgfhiXYTZPZXOCXJqNhBLrAXsu/zUhTMPc4cpmT1eCAjNPnj92fq u87qbgkMIIw47OM9/Rrd8WH8tY4UZNXtHQ9GUQidVdtU21mfx41IQEYRVjndyTZ5svE0 uQjbLH92rjlea9qfuWQbgyiTPaIhSFkYFrOHpBB/0KSbbO9NhcnXn2UF3eDyZS1lIGTo YKHA== X-Gm-Message-State: AIVw111O03Q0gufUtaAt+1MbfVs/76MdkrYlZCctZF5mF9AuokBt+A2M D0pFBHeF02sGbDJ/5ag63oAbpaJWvTcDWVg= X-Received: by 10.129.174.98 with SMTP id g34mr3141949ywk.164.1500336713299; Mon, 17 Jul 2017 17:11:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.83.33.81 with HTTP; Mon, 17 Jul 2017 17:11:52 -0700 (PDT) From: David Blaikie Date: Mon, 17 Jul 2017 17:11:52 -0700 Message-ID: Subject: [patch] Fix Fission (broken by my previous patch) To: gdb-patches , dje X-IsSubscribed: yes gdb/ChangeLog: 2017-07-17 David Blaikie * dwarf2read.c (create_cus_hash_table): re-add lost initialization of dwo_cu's dwo_file Turns out somewhere along the refactoring of the multiple-CU support for Fission I broke the patch before submitting it (& seems to have broken Fission support generally) Syncing back to the point at which the patch was committed, the previous test results on my machine are: expected passes: 36137 unexpected failures: 416 with the previous (broken) patch committed: expected passes: 36131 unexpected failures: 429 With this one line patch applied on top of the broken commit: expected passes: 36144 unexpected failures: 416 (& all other result counts remained the same in all 3 cases) diff --git gdb/dwarf2read.c gdb/dwarf2read.c index 0fdcd42ee0..23fd19d8a0 100644 --- gdb/dwarf2read.c +++ gdb/dwarf2read.c @@ -9739,6 +9739,7 @@ create_cus_hash_table (struct dwo_file &dwo_file, dwarf2_section_info §ion, per_cu.is_debug_types = 0; per_cu.sect_off = sect_offset (info_ptr - section.buffer); per_cu.section = §ion; + create_dwo_cu_data.dwo_file = &dwo_file; init_cutu_and_read_dies_no_follow ( &per_cu, &dwo_file, create_dwo_cu_reader, &create_dwo_cu_data);