From patchwork Fri Apr 11 23:58:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Blaikie X-Patchwork-Id: 519 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 7CC4A360078 for ; Fri, 11 Apr 2014 16:58:47 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14314964) id 2BA034985E18; Fri, 11 Apr 2014 16:58:47 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id EC0284985E11 for ; Fri, 11 Apr 2014 16:58:46 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:date:message-id:subject:from:to :content-type; q=dns; s=default; b=P2vT6Y4slsqr6g23iqOHngRerNWte yCeXSImUiVdyeAVnwMp6Qrd0uO3+ik7q7LjdSevgDEiuL0A3yjYBPG//PNKOXoP9 Z3f272JufqJ+prdoCq4UbBoA6UnC+Mm3Y/ovKvuV+QTsPiEY12zm945nUKTWkg7S ArstnnxOc8t3Z8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:date:message-id:subject:from:to :content-type; s=default; bh=GRDSrHBIGlypzP7JGwFTjQa7EXg=; b=bie 9pqtVvbUz7VsOe7KeggKfr5EUYZrJk/DRogrKQcARFrw1EytohdT2x0511dtMfoZ 05YVDUxaAW6cCPXR0BXCljPjAoeTx6xWe4/US1X9SrMXLR14WMQlhPNmg1EeIQsU b7WpTNHWUKL8XlVhHxsC1fMFTiegdrOuBGu9XELA= Received: (qmail 7184 invoked by alias); 11 Apr 2014 23:58:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7166 invoked by uid 89); 11 Apr 2014 23:58:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f51.google.com Received: from mail-qa0-f51.google.com (HELO mail-qa0-f51.google.com) (209.85.216.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Apr 2014 23:58:43 +0000 Received: by mail-qa0-f51.google.com with SMTP id j7so6082033qaq.10 for ; Fri, 11 Apr 2014 16:58:41 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.224.2.131 with SMTP id 3mr2783068qaj.71.1397260720916; Fri, 11 Apr 2014 16:58:40 -0700 (PDT) Received: by 10.140.30.74 with HTTP; Fri, 11 Apr 2014 16:58:40 -0700 (PDT) Date: Fri, 11 Apr 2014 16:58:40 -0700 Message-ID: Subject: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp From: David Blaikie To: gdb-patches , Eric Christopher , Doug Evans X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in This test is intending to use gnu style inline rather than the standard c99 inline semantics. Clang defaults to c99 and the test breaks for this (and other - there's an inlining debug info quality bug here too - I'll file a bug and kfail the remaining failures in a separate patch) reason. commit 69f01ca2de4a42f336f2656379b90d9a8b6894af Author: David Blaikie Date: Fri Apr 11 12:45:37 2014 -0700 Compile inline test with -std=gnu89 explicitly to override Clang's default (-std=c99) gdb/testsuite/ * gdb.opt/inline-break.exp: Explicitly specify -std=gnu89 to override Clang's default. diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog index ed448c5..f7a4b8e 100644 --- gdb/testsuite/ChangeLog +++ gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-04-11 David Blaikie + + * gdb.opt/inline-break.exp: Explicitly specify -std=gnu89 to + override Clang's default. + 2014-04-11 Joel Brobecker Revert the following changes (regressions): diff --git gdb/testsuite/gdb.opt/inline-break.exp gdb/testsuite/gdb.opt/inline-break.exp index 21c958a..7eef10a 100644 --- gdb/testsuite/gdb.opt/inline-break.exp +++ gdb/testsuite/gdb.opt/inline-break.exp @@ -20,7 +20,7 @@ standard_testfile if { [prepare_for_testing $testfile.exp $testfile $srcfile \ - {debug optimize=-O2 additional_flags=-Winline}] } { + {debug optimize=-O2 additional_flags=-Winline additional_flags=-std=gnu89}] } { return -1 }