From patchwork Tue Apr 9 11:04:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 32217 Received: (qmail 49383 invoked by alias); 9 Apr 2019 11:04:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49375 invoked by uid 89); 9 Apr 2019 11:04:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Connection, didn, HX-Spam-Relays-External:15.20.1771.016, H*r:15.20.1771.016 X-HELO: EUR04-DB3-obe.outbound.protection.outlook.com Received: from mail-eopbgr60076.outbound.protection.outlook.com (HELO EUR04-DB3-obe.outbound.protection.outlook.com) (40.107.6.76) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Apr 2019 11:04:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0D1yvQbrUpGIcgP5lGFvEkuQ2UuEgclXvUgeTeXSYqU=; b=NhlXwfDLerhsu0BPZnJVSELtZApVzrJeDh0oPakfBfs7+BQRfPzAWUxpJ5Gob17lLGoDhke+aq993VQbIopMZazEzVwZUwd5xR6RtN7Dt7S5xayhwJgmFIDchFNJdKEg8Y5MVGBz3Vp8uj5DVBZ5K6Er/TSkFM9B442kxL+eqqc= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2472.eurprd08.prod.outlook.com (10.172.251.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Tue, 9 Apr 2019 11:04:38 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::399b:3a32:bff9:827e]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::399b:3a32:bff9:827e%10]) with mapi id 15.20.1771.016; Tue, 9 Apr 2019 11:04:38 +0000 From: Alan Hayward To: Pedro Alves CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Testsuite: Add gdbserver sysroot test Date: Tue, 9 Apr 2019 11:04:38 +0000 Message-ID: References: <20190408153440.39250-1-alan.hayward@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-purlcount: 1 received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes > On 8 Apr 2019, at 19:58, Pedro Alves wrote: > > Hi Alan, > > Thanks for following through. > >> > > I'm not sure I understand the overall approach you took here. > > Because, if you don't restart between each iteration, then the > second iteration is using the program from the previous connection, > I think? Yes :( Fixed. > > Also, you've used prepare_for_testing, which results in loading the > program into gdb with the "file" command. > > So the main program is not being fetched from the target. I didn’t spot the “file” part. All the libraries do get fetched though. Fixed. > > So the testcase is trying to ensure that we load the DSOs from > the target, right? I did wonder if I should add checks to test for the "Reading * from remote target...” vs "Reading symbols from *...”. But, we can’t really know in advance which libraries will be read. But now I’ve removed the “file” command, I can add a check to make sure that the binary is correctly read in. I’ve overriden gdb_target_cmd locally as I didn’t think it was worth moving the changed version into the library. > > But the thing is, even if you don't have debug info for shared libraries, if you > debug info for the main program, you'll be able to set a breakpoint on "printf". > The result is you end up with a breakpoint at printf@plt. So I'm thinking that > the test would pass even if we failed to load the shared libraries from the target. > I just wanted to make sure we could stop somewhere outside the binary. Any suggestions? Or is is best to just remove that part. > I tried to do that manually, by issuing a "nosharedlibrary" after connecting > to gdbserver, and then running to the breakpoint, but unfortunately, that > runs into a nasty gdb bug: > > (gdb) nosharedlibrary > (gdb) c > Continuing. > pure virtual method called > terminate called without an active exception > Aborted (core dumped) > $ > > I'm looking into that… I get the same error for that. > > Also, the test as is fails for me, on x86-64: > > set sysroot / > warning: Could not load shared library symbols for linux-vdso.so.1. > Do you need "set solib-search-path" or "set sysroot"? > (gdb) FAIL: gdb.server/sysroot.exp: sysroot=/: set sysroot / Works for me on: Ubuntu 16.04, both AArch64 and x86-64 Just tried it on: Centos 7.4 AArch64 OpenSuse 13.3 AArch64 And works there too. But I don’t see anything with “vdso” in any of the logs. What OS are you running? With all the above changes, I now have: diff --git a/gdb/testsuite/gdb.server/sysroot.c b/gdb/testsuite/gdb.server/sysroot.c new file mode 100644 index 0000000000..6fc1443e3b --- /dev/null +++ b/gdb/testsuite/gdb.server/sysroot.c @@ -0,0 +1,25 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2019 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include + +int +main () +{ + printf("Hello World!\n"); + return 0; +} diff --git a/gdb/testsuite/gdb.server/sysroot.exp b/gdb/testsuite/gdb.server/sysroot.exp new file mode 100644 index 0000000000..2429a4caee --- /dev/null +++ b/gdb/testsuite/gdb.server/sysroot.exp @@ -0,0 +1,134 @@ +# This testcase is part of GDB, the GNU debugger. +# +# Copyright 2019 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test GDB can correct read the binary with different sysroot setups. + +load_lib gdbserver-support.exp + +if { [skip_gdbserver_tests] } { + verbose "skipping gdbserver tests" + return -1 +} + +standard_testfile +if {[build_executable "failed to prepare" $testfile $srcfile "additional_flags=--no-builtin"] == -1} { + return -1 +} + +# Override gdb_target_cmd, with additional flag $additional_text which must +# exist in the output of the target connection for the function to pass. +proc gdb_target_cmd { targetname serialport additional_text } { + global gdb_prompt + + set serialport_re [string_to_regexp $serialport] + for {set i 1} {$i <= 3} {incr i} { + send_gdb "target $targetname $serialport\n" + gdb_expect 60 { + -re "A program is being debugged already.*ill it.*y or n. $" { + send_gdb "y\n" + exp_continue + } + -re "unknown host.*$gdb_prompt" { + verbose "Couldn't look up $serialport" + } + -re "Couldn't establish connection to remote.*$gdb_prompt $" { + verbose "Connection failed" + } + -re "Remote MIPS debugging.*$additional_text.*$gdb_prompt" { + verbose "Set target to $targetname" + return 0 + } + -re "Remote debugging using .*$serialport_re.*$additional_text.*$gdb_prompt $" { + verbose "Set target to $targetname" + return 0 + } + -re "Remote debugging using stdio.*$additional_text.*$gdb_prompt $" { + verbose "Set target to $targetname" + return 0 + } + -re "Remote target $targetname connected to.*$additional_text.*$gdb_prompt $" { + verbose "Set target to $targetname" + return 0 + } + -re "Connected to.*$additional_text.*$gdb_prompt $" { + verbose "Set target to $targetname" + return 0 + } + -re "Ending remote.*$gdb_prompt $" { } + -re "Connection refused.*$gdb_prompt $" { + verbose "Connection refused by remote target. Pausing, and trying again." + sleep 30 + continue + } + -re "Timeout reading from remote system.*$gdb_prompt $" { + verbose "Got timeout error from gdb." + } + -notransfer -re "Remote debugging using .*\r\n> $" { + # We got an unexpected prompt while creating the target. + # Leave it there for the test to diagnose. + return 1 + } + timeout { + send_gdb "^C" + break + } + } + } + return 1 +} + +# Run once with sysroot set to the local filesystem and once set to the remote target. +foreach_with_prefix sysroot { "local" "remote" } { + global srcdir + global subdir + global binfile + + if { $sysroot == "local" } { + set sysroot_command "/" + set reading_symbols "Reading symbols from $binfile..." + } else { + set sysroot_command "target:" + set reading_symbols "Reading $binfile from remote target..." + } + + # Restart GDB + gdb_exit + gdb_start + gdb_reinitialize_dir $srcdir/$subdir + + # Make sure we're disconnected, in case we're testing with an + # extended-remote board, therefore already connected. + gdb_test "disconnect $reading_symbols" ".*" + + # Start GDBserver. + set res [gdbserver_start "" $binfile] + set gdbserver_protocol [lindex $res 0] + set gdbserver_gdbport [lindex $res 1] + + # Set the sysroot. + gdb_test_no_output "set sysroot $sysroot_command" + + # Connect to gdbsever, making sure GDB reads in the binary correctly. + gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport $reading_symbols + + gdb_breakpoint main + gdb_test "continue" "Breakpoint $decimal.* main.*" "continue to main" + + # Test we can stop inside a library. + gdb_breakpoint printf + gdb_test "continue" "Breakpoint $decimal.* printf.*" "continue to printf" +}