From patchwork Tue May 21 04:46:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 90516 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B86453858C5F for ; Tue, 21 May 2024 04:44:52 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2096.outbound.protection.outlook.com [40.92.90.96]) by sourceware.org (Postfix) with ESMTPS id 26EF23858D1E for ; Tue, 21 May 2024 04:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26EF23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26EF23858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.90.96 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1716266668; cv=pass; b=raWBYCXQ97RBM4+dvN9dcYH5ucnZM7xxBLNJ1zJyj5oqfVAAcklI21Whj3LB+3ry/BOoiwdl6ezurqzpVDMpQZucF+tvZHFIJtF3MivObdcC6S60FHRrY32CeLxVrWLUQYNwoRBGtlD+GMlPeXotAPa6nmJ73ul4mztoZqGeOLU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1716266668; c=relaxed/simple; bh=RRml/duYTQdBGttpPuSOxmeBlxQ8Qn0dejT/aqHGdIY=; h=DKIM-Signature:Message-ID:Date:To:From:Subject:MIME-Version; b=HJub4+wvAMWGJN26sAudue8KS0VkyMonOVPYspDt6Kwr49qgAybco1hqp5inctE1FEY+USzfTFvThMiKXayceH4WIIhJrpV6GrS7H+pV0mvevKv5g7wALqYL71+V4MM721098iO8+2NT9KdXXKgD+ct90S3SzLiWeQHzgrGV8os= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXM9cNxSM9o6N1+mm8rRf9Vu4RlyfhxuYlgBrKhCm1DFx+Ve+6URdytPNAz8yJX6/SIixpfYcSxAsVKP3jLnrPWTZSuoBj7+uuX8I7xZ/fpjfX7MLnZWuyXmRUTU9pZh7TRudgT+obwoquOR+FJBiBeT14tGSzI36a+P5dRHonYfEH99bDZXeugaYfdv3ucYOuc4FmVMqTXwqaIuxSChN0tI+ajfNQk/rZPFDLwdIBVrpC990Edx2EGEufcpaBovmYQyXq0EGLuS998sFJOzjLQtjoQ7pMgvDByLRWywQNkVHfRc71oEYnmjyxPeuQhe4F/bt8cdkw2/UKagbvDG7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zq6xBGBMBDeI+WO9n3jJ8txKcKHNnXGU8lVvlmA0zpE=; b=RNjMxOWoYaP/DuvorRa7FtHc6lmce5IRVgJbUdEeVmCaNrc08V9guNvYk2HDd53XUGk47n67+j0O4dRu93vNOCpSfr1bALg2b4+sw5Rb21K3gUrZvQJI3QOSZ9D/K7CbIpVbzwalbPscGoB4mH6iW4RX5lDqfJ9OTw8ZUO6/5q9RrM59Z01S2JbWQB6sLd25thE0LL7lnlYbIyl1aHsgLvV7Hprd113V18Wc0u89Denob9MALPjcqoTevgSeYe/WfmEzqQaxLoqCwd9H66j7toCKb39PRV4v0y8SWl46fce4iqzUxJwFELbeIGZLR6P3CR3tbBXxrWjGuvGAlCjpnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zq6xBGBMBDeI+WO9n3jJ8txKcKHNnXGU8lVvlmA0zpE=; b=qyYk4gqnjNdqGzEpOXIx11K7Trmz3zSUL9/aSvR5TbUxizu17Mq76/pnEHgCidsFivKKfjOwPBuE+wQ8s9PAXPEg2304YIESdWuGE14EX8WZXvedBOmWkkcNdjRJ6nrFIF/fsjqMmhTJyTEe9vMvoLb3i0/4wwktiK81tXpKn8Nh6hoOLenmKjo8t1msbCEl1EgCV34mkT/FaP8KyMp8+1NSl+DhBivailqFkST2elYMJhiBPHf00S7psgcYghodo6nKUGGcdlCv2NhA1B7QkAmivCUu1Ii/gHNY5SrCWXu5S0E66drVFmlkuthaFRDBO2mqjkcayajyvA9hyEGp7A== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by VI1P193MB0766.EURP193.PROD.OUTLOOK.COM (2603:10a6:800:147::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Tue, 21 May 2024 04:44:23 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::e65d:5dd2:5662:c61f]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::e65d:5dd2:5662:c61f%4]) with mapi id 15.20.7587.035; Tue, 21 May 2024 04:44:23 +0000 Message-ID: Date: Tue, 21 May 2024 06:46:36 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gdb-patches@sourceware.org" From: Bernd Edlinger Subject: [PATCH v2] sim: fix a warning in dv-sockser.c at connected_p() X-TMN: [+z/X1MiuCTqI1P0HjxPC1ambFCBSQ3fd8bkiFTQ+7VHCjvRl/LyIWO4ZH5rHkneb] X-ClientProxiedBy: FR3P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::21) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: <8560a0eb-6587-435c-8e24-230228590d36@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|VI1P193MB0766:EE_ X-MS-Office365-Filtering-Correlation-Id: 5513a08b-59ea-42b6-7584-08dc7950afa3 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: BLBVpKlVRYu7qdtkszK+KizQLZH9KAOZhsMFoEVUiG7ysAGB3jOXGXouaN2KlTi/BUSaO428sVjQ7/jA5jBHMMitrpE8RZ57FIB8xmeMHiI3cH3QyDRPMaFd1gN0Y7dmmrWPI7duC04GKX0pyL60Uf/ojRr3f2K0trTVCCXbW8/ZuDBdyuslEncCvlcBsIDytCmg4APf1pH3C69bLHrk9EIEdmEgtGQ9mi64kyB7YHgnvQC/Z2kntg8g1sP1fm0uw+zA8XLGq4eRD94SAMTO7SdkxKf4nAw1A8gzTaGoWE/kJmk+bKlQosqzB+x39AGPI/1CjJaUeUcR/kROjmvgzc704dmlIuhw8CNJ5ANe9v0cOSKfJ0BxbyU0XjW2McZ+35lbebEXYMdlmP/4P1BWWH6znBaaJABypJpi868/PbWA2B69hKXGnSlxTGT3FmTr+67dEq6roM420iY4BqNxrqYufPY8IO/Gdoz0dmgN80XgnUwJk6IQE7oyBfKjDxHqub5XSMJ56G6HrUN6iHZjUYSECspkMGkq/8RBG6+X2TkQAAKx15GKKgLVY9h6SGj5 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?8Vg4XyXU4lxJ0A30gQOShwhnT3vy?= =?utf-8?q?odvvgpe5dFsTA5V2nKqWAdhIHO4GayGTZQokjjjFtmFht6ovA/14/UdhtABnPqTEs?= =?utf-8?q?958ssVaX0CQ+6QycGm3JeGYk22JqYaCruqGR/Lpl7+bCKsONMXP1aqLGVCkrExF7W?= =?utf-8?q?y8JNPP4prpfX2w7VyOAeAszNRG79mw8IvwDeaS+taR8Nsg/ajJgURCKDSn4Wuw199?= =?utf-8?q?+oOqC4useTXNTmn91KQ/rBlrDRyx1jvqwWzDUuGqMxmOXXxI9nwXWMcny0zwMXi2z?= =?utf-8?q?dM+QffnRtc/Oo8TZTxPEFxsxzhsY9JshNQ9Ube6RyzG8NZoh7KcAvzjNSPZlivTgD?= =?utf-8?q?2aocw0qtsJFjm8rdkRwRQDp3kHO6arV3C7q4fins20uEQ52igsFc3FFpZJO3y8xnJ?= =?utf-8?q?ultkdf6EAHFuToZhJWBS8B58FpsU15N0hKoRnR49cl0qZrx3x3FhzBvA2lP86PIH4?= =?utf-8?q?Xo4ebqtw1c/axgs+Am3PP/LIRt1w8RIa7j/mZ4M6M6z1/IBYd3ZCThJ17Ru6VlBLP?= =?utf-8?q?reXrWnQPeGA0T5jgJA7o53jUz75ysm5o9v1hntT1C3Ao0BUyt0uVc3BV/9H9xBcNz?= =?utf-8?q?1qPUEAoffA+zAZfkcn5CdpOWitJvUBJ1FObajBL6A2Csp7TbBgJN5F4NLzD1Kf8q6?= =?utf-8?q?HGaMY+SBh7763pJvqqZtdZUUbUXIDZ5R5VEO/ezFfb7Ow8iUP4q9QxUoIhGXsh5/n?= =?utf-8?q?+gatTta9S0lBW6e6Ka1BKKU5kleslUvGlLdHRlm3P5gmNtYS0vDOeucM9JRE3Nrng?= =?utf-8?q?MeJIgJI6R3065G1nZyxyNf8H7oTtaClemtNkA9pr++Sozx0xbke7f5T6NS9tIWbwn?= =?utf-8?q?tv6PqLgnqMm6e8AVLGVRyxD0oNzIstKOz6WVYYVIfT0XtmwAwTz409wd/E2ntbdGZ?= =?utf-8?q?0JeYj3hgKqT7BMUcns2yThsa5fDxZ3NrjJ6Y+yfBVKLWQqye03otR0ytIcRcH9DPc?= =?utf-8?q?SDLKeVI0iZOji3uqySw8TgLi33Pjen2B6VdShMUUftaILsvVAgw9LJrsUFC2ulLlD?= =?utf-8?q?2V4tgFqTczYGFLIyfG7QiBVJECKw1a8Rmmn0h0sspZVE+0HYSnmcs3dfRG7N1Eskq?= =?utf-8?q?z33lZY50oOJKZ/oDNvWn5OQ0J3FL4Pc8nXqvjU7ASZCpJquRNXdzxMYt4YaFGFQeG?= =?utf-8?q?S/6kQP0Oiny/loE0GicqKDYjR06dz5YndZdEMspVFTf6pbqdbHx0v5FZKsqAmtSTk?= =?utf-8?q?JhGppokCnZnE+1KUX8UaXgrhzafaYBYB2zOZLwbAELfQCn3hwB1JslApV1J9LhEVB?= =?utf-8?q?KpbPSgRdVEbOD6KQ?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5513a08b-59ea-42b6-7584-08dc7950afa3 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 04:44:23.6142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1P193MB0766 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In some O/S e.g. windows there is a warning here about the unused variable flags which triggers a -Werror build failure. Fix that by making the variable declaration optional. --- sim/common/dv-sockser.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) v2: moved the variable declaration inside the #if block diff --git a/sim/common/dv-sockser.c b/sim/common/dv-sockser.c index db81233e25b..8f7425658a9 100644 --- a/sim/common/dv-sockser.c +++ b/sim/common/dv-sockser.c @@ -218,7 +218,7 @@ sim_install_dv_sockser (SIM_DESC sd) static int connected_p (SIM_DESC sd) { - int numfds,flags; + int numfds; struct timeval tv; fd_set readfds; struct sockaddr sockaddr; @@ -254,15 +254,17 @@ connected_p (SIM_DESC sd) /* Set non-blocking i/o. */ #if defined(F_GETFL) && defined(O_NONBLOCK) - flags = fcntl (sockser_fd, F_GETFL); - flags |= O_NONBLOCK; - if (fcntl (sockser_fd, F_SETFL, flags) == -1) - { - sim_io_eprintf (sd, "unable to set nonblocking i/o"); - close (sockser_fd); - sockser_fd = -1; - return 0; - } + { + int flags = fcntl (sockser_fd, F_GETFL); + flags |= O_NONBLOCK; + if (fcntl (sockser_fd, F_SETFL, flags) == -1) + { + sim_io_eprintf (sd, "unable to set nonblocking i/o"); + close (sockser_fd); + sockser_fd = -1; + return 0; + } + } #endif return 1; }