From patchwork Mon Apr 15 14:46:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 88495 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA10F3858408 for ; Mon, 15 Apr 2024 14:45:12 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2106.outbound.protection.outlook.com [40.92.89.106]) by sourceware.org (Postfix) with ESMTPS id 20F403858D32 for ; Mon, 15 Apr 2024 14:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20F403858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 20F403858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.89.106 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713192288; cv=pass; b=AnfiJFwgnLilTvcrlZhiJ6B3vgQa7QBqikidQ+SVn3gqYRZmPVZXccJ2b8Vk/+XZv83A9suDRMgK4c11yCN7mJFJwPhtMRrh1pVFR+Xn7vm4fsjJoVnLNXO0EHDcptbSEHnJKmAX1RSHnIi/EFicL2SGe8SU7CThHDRpLlXV4Z0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713192288; c=relaxed/simple; bh=jI6FDawNVxXynuuNU1ColZkOigYjTHILWdjsqYXPAWY=; h=DKIM-Signature:Message-ID:Date:To:From:Subject:MIME-Version; b=s/FSDpqUxmKKPUVUWm7D8AAepbUYsct/R85xWvOr55m4ImW3Hvn3Z7eeFNYyMoKbaxH1RRzpUVakOhFHEz8NulxC9+iJQcziw54Vq6K+vykhFdbY60YVBB57bI5pApiaHmKgJyiUXTqwH/jOGxaZJmRsIl/JuyveyOOBXSd68kE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGbfSDvrbX+w5BGf4wxXolbYPMwwjQsgPmp1R/HxDP5lK0LRtkA4AOQQrf0/mXp4GGYFIG70SnPRLShM3D7OdxjFgEM2Eu+dCYufcXbh7F9f27kkF8JDBR5XzizFchhRb+GbIJm5h8hE423i2hhzEX7dq+e4j+1u1EX9zY6TjNPHur92wHfWi94YFWzrd9fetrleO4DJbHB09PSotxP4at+2Qxi6sDTf4p8DCt1hXQTTRTscbTKUUCC047VdwhrHoE7PDcslmjh+gOH2FKqPxGI+MWpd1Cj3SqpCgcaFNyVRRJC+Gf6qRKW0jG15pWrMJFJ6s9lG5Tw8vLlBNG/euw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WkONdWAQBgJhnkb4xzYignZhn3IcCYqZ7+XeEoWc3CY=; b=k+u9bJn6ijpLRQWXf5PV9V9AG7oNOEupRQ3069bb0wx/Jj+fBo0bRq3cbIEEwv3AsIJRw/KyjOAVHaP78625HtKq0By6T8e2RD2xhsols8hMD8mZvy43p3H8IvuCuX2G+5M3eQGpgU9COCt/3vVEDW2gQdYMfr976gseMMvAi52Wg+WxvDK3kZiGM73ilb+C2EzV85CzW55a1sW7LhUZh33Bj6CSXQroCcMw1PPDd9Qb3JVFsWzormKGRQRCEwZvfChtFJs0Cgib/XtMYyMHdyRiRabpnOdiqEsioNQDIKKi/gPNBhsIF20z2J6g0/gYl4zfnXhyVOvKvTl/83ZvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WkONdWAQBgJhnkb4xzYignZhn3IcCYqZ7+XeEoWc3CY=; b=tpgBCcE33Hil68BC1gKtkEfz9JN0uxYX9uhSpVtZhbIg95yor+lp3paD7Lys2lB3fSgDK6NG7sMi/xej1F+ycSv8TIXzMyPEeZ0iGnvWJ8M2ruEx1cG9bZDUY+vF+TIHPuh5EKQx8xB3riofnqFUnmp2Pv7hHC2BP85/PDQYfKMUdVy/84Mna1jbnPrtAABNYdnCUYCEmDbyQDlNj4DC5SyJEuzQqJcxpD70Zfn4JzLovRn36IYQ+69AUu24nPb8afAle38Ga3unx1U+us/Ie7gcXVFrIsJsEqo0KrGcCywq9lx6upuiCLb2jjEy3SMEGPPXuOnjoOaYpxRUL7Dbkg== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AS8P193MB1205.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:33d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 14:44:45 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71%4]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 14:44:45 +0000 Message-ID: Date: Mon, 15 Apr 2024 16:46:37 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gdb-patches@sourceware.org" From: Bernd Edlinger Subject: [PATCH 1/2] sim: riscv: fix a divw division by -1 bug X-TMN: [Zt/pDQj5RjJM0lgK29wUyu9l4Xuk5mFwfhRWrxhaUz2wvB9XOGvADsJJgLUW7J5r] X-ClientProxiedBy: FR3P281CA0210.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::19) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: <61f642db-5ede-4469-a1e6-29f1700afce9@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AS8P193MB1205:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c2e9b5c-943c-4a3f-d16b-08dc5d5a9764 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HKrhLetVH+3+s8s24e6w3ClEj4YEIAtkdMCHxQlhIgbN2JdtNW2f/t9ciClq7VyAoFruysdCLMkhkZuAJFcnDSGNnw/DYsZcq9U5tyCkkfcS1TADjER6IokoDsfHQU/CXn03Ixm309sbL4+oxfC0GHDqHxMW+7G6IFUQ3OtN8oGdGM4oZIwzcaPjhGocymE6IwQC5bNm4I2lyEjZUB2Mk8oYKkbRlIFR/by/2pxD3JpnsVqICBfIx8ABTjQ3rcd5wSNGfnjeAFRvx9bNUorViXXAd1mVumA3vMm0EwdhOmSNbzxSm4OCEe9qCet53ndBggv2gPbj6zYNblcCLyeFl6ApRn072+J/hYeRtnC806FDF2F6BpXNJQPwYV7nDy4ZkGoT4s8T01Yb0eSxZY8BVhi3MLRfA8PL3FpNJnjx1W26nbt2bfu1U4iOtdfmDKwUNcOpv3Jzv42XkDO7a/osrZS5G8Z76GvrYjC0cz4Fy/Seo7k5gDNLPWYZeKw6okzbwrMWaibEnJfPocJiodgqhoLht/vQswHyOY1B+hEvZm9zZGs56MSDrs5qPX147274 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?RUtPzqU4FXa85Njt+x2bWksvY4VI?= =?utf-8?q?VTW5Cbfg055SaXWVZr8ifENsOun5WE17imDwvORTi0XbyW/FfvK1YfSd8/piyPOqG?= =?utf-8?q?D4Ff5J/j5gLmLYCD0lBcFUKZW+K3QjljUTZVUbJu0hRmLxlp7Uhe0Y+ksbF/3fWrg?= =?utf-8?q?8Vat786gRIKtIMUp3YNO6wXJ60wNAmE51fRlPOo8h7mEF5NsM5KccvXcLi3C7urd/?= =?utf-8?q?RoIk/YBmBRMfyhyK7TNOdH6gP48hpVYbrYsEz7AQ6lR37V1nlHE+XEe9I/Y09SzEN?= =?utf-8?q?Zj/8/AtzHDHpMgA5VS0Lbb6VRkuE9nunRJe5DyhxU11+O6Ctw/CqfrWo2RZfVrpbA?= =?utf-8?q?20XJB+kOf+VJfds4ilT5qfLDb409ayHzLUDASOLQQu1QdpibfiZHwTE5qDq9Ef9Uv?= =?utf-8?q?OVvTOv82bkupvoS+GgpO8y5Zsl2d9EeeLn61xyUPiJ8NQhtpVsckJGlPCvybN7zAX?= =?utf-8?q?dDhw8w8iB6IzmnRhZlmcYp466pblq270rTLy3BBECyZLAr73z1IlAQk7eObOQ5RnA?= =?utf-8?q?VV19G9wK1M8chJQ4E+B6zj2XGhwIv0h3kLwCOFwww4wdF10+nUymYA+YrcgCr69NT?= =?utf-8?q?6iyhPk3GeXB1zBvuX6/aqr8rA9azCAQaPbTCX6BT3cgsHoH3XwMX/vJo55btJI7ET?= =?utf-8?q?N4P0kQelJG3V1IwCjIGRsQ+xuwjtMS2+vU41hDGqo9Y4aOfIkEM6aMA3MqeqGfBWc?= =?utf-8?q?DWtG2bdp+/MLuQzo7YIRL/Khw5XcptoQeg5bk3fzydoUh6Yid/cAu2ZuyTHw80F7C?= =?utf-8?q?OS9u2J8ljHWPZMTWNlJAzPnB/BEjFssOJJLxroy/YnN0JzZjfs4CUm8QRTSv1u8wX?= =?utf-8?q?VZl2G/LzfPQZQRpc8GMhCqTPlPeCh/04z0znxmfGXv9LdXjIy9WzyukDpRpKBV7RZ?= =?utf-8?q?lJo6drbtXzkrJl0PwHvDjVn6hxQzZ/UDEZcMb7eVV77HfITHjTjZBWpeXKG+kjlSX?= =?utf-8?q?AOTEbnwjmWCiIPH/s+1Thon/VZmF893dsyeeSNhU+WwyXRCxx4758J4odDVvf6KxQ?= =?utf-8?q?9KPo9mbnZ6t4cfXFqGdtSp72iZ/wk2LjZxiWHHya1CCGX3+wXmGkkwzbm3/UV4DUF?= =?utf-8?q?upVrnnpcQYXDOiCQxQ3TUJGYm6JSEIMDXcX1wumHCIU1hIkHsc7LwPCg7/DV1Ou0K?= =?utf-8?q?2M9refrd57opZhx1nrd8RUthiXmI3+vjWuT9/RRVr/iuuTdUye7KLKQPrMShQorxm?= =?utf-8?q?nwZPw/qqf2XZk+cNGVahcrkfDvf6pZHTJMA0pWqtxrOUi4SrApDkGKqi8/7eK0MzI?= =?utf-8?q?5Y2grW2ERA8AQqdQ?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2e9b5c-943c-4a3f-d16b-08dc5d5a9764 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 14:44:45.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1205 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org There is a bug in divw for riscv64 target with dividing by -1, the result was always 0, when it should in fact be sign-extended -dividend. It did not affect the rv32 target, because these instructions are rv64 only. Since 1 << 31 is an integer overflow this avoids an undefined behaviour bug at the same time. This caused test failures in the gcc testsuite like: FAIL: gcc.c-torture/execute/arith-rand-ll.c -O0 execution test FAIL: gcc.c-torture/execute/arith-rand-ll.c -O1 execution test FAIL: gcc.c-torture/execute/arith-rand-ll.c -O2 execution test FAIL: gcc.c-torture/execute/arith-rand-ll.c -O3 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O0 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O1 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O2 execution test FAIL: gcc.c-torture/execute/arith-rand.c -O3 execution test ... --- sim/riscv/sim-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c index c8adb65139b..515ff835223 100644 --- a/sim/riscv/sim-main.c +++ b/sim/riscv/sim-main.c @@ -724,7 +724,7 @@ execute_m (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op) rd_name, rs1_name, rs2_name, rd_name, rs1_name, rs2_name); RISCV_ASSERT_RV64 (cpu, "insn: %s", op->name); if (EXTEND32 (riscv_cpu->regs[rs2]) == -1) - tmp = 1 << 31; + tmp = EXTEND32 (-(uint32_t) riscv_cpu->regs[rs1]); else if (EXTEND32 (riscv_cpu->regs[rs2])) tmp = EXTEND32 (riscv_cpu->regs[rs1]) / EXTEND32 (riscv_cpu->regs[rs2]); else