From patchwork Thu Dec 22 15:22:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Hoerberg X-Patchwork-Id: 62266 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95F303857B9B for ; Thu, 22 Dec 2022 15:22:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95F303857B9B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671722564; bh=GTqu3tRynlbBLOAwVq2dQ8vyGSQOemVD3YWdOskGha4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=kCiiyVH9pT9teVFH9oJtM5KQ2/nRkHqZF09Ro8ew7qhm9h+4ebBCGrJ7HIloGdn1G Y0zM+G72EEVXKC/p7cwSpPNpNKNAQusCMEUqDTKgZe1iwWTxPZhDLeCs1xpZx36to4 Ktc8C+ZtVqkNd1vavyuk7Jf3QJfHdzbSZmN8Eyzs= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2138.outbound.protection.outlook.com [40.107.6.138]) by sourceware.org (Postfix) with ESMTPS id 4C06E3858D1E for ; Thu, 22 Dec 2022 15:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C06E3858D1E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h/2w1TPo7fucBlABCnrU6eXrYv/XWI0QS2TRvlURhsIwoaYJhaKOeQDGTORDBFcHwWL2nC9xs6ZARqjUqLFDT26vd7GQ136srkE+WOMy5bUlNuGB6lstWrTBsVzuDc2+SHr2mmK4Z26iXLp7PIO7ikZG5PgsMHRld7Zsy/HEc7IJkuWgdcVRNwS8Gz23gZK1+IctN+Hf46GVq7CbclI7GJ8Q8FDeNVD0RMYqpi6Zy6qSBE7+ZcKmdslRiYthhYrBp1mR4l7dejA/IIc1y+lV8fjvi7wZD1cJMXV+IUuf4yRboMTLTuiko5DP8GEH9cThoeEbCD1TMuKy4GLTkkl2kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GTqu3tRynlbBLOAwVq2dQ8vyGSQOemVD3YWdOskGha4=; b=f3YTp3h7wNa5J+WLi02P/vo52/gwPZ7I4DvxBk/hzSfE8kKzMruJjSI4wAMqMUfD28EslLr7d7N2bJ+A801+jetiLPgUR1t6oAW+eUAz2YtQ6MyvdBu5A6MxK7LsSIZJBpPutKHnfPqPTnx1qsrLddCK7zbBGPM7p4huCn41CbOLix67QljyH7VotWVtpAIWRW2G65khxC4VUmRMA2aFL7UMWoVuTcQOEpriYeyLOLTMs+UeCHJoTN2orXh0kGXdCxbrGq1S+owKhgrov1FWB0U+r1auUjRv78iwvO8xlofECRUUC01jJKHNfRw3UgO4ayO3xwdpFQrlZlYgBnDSMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=danfoss.com; dmarc=pass action=none header.from=danfoss.com; dkim=pass header.d=danfoss.com; arc=none Received: from AM0PR01MB5844.eurprd01.prod.exchangelabs.com (2603:10a6:208:162::13) by AM0PR01MB6530.eurprd01.prod.exchangelabs.com (2603:10a6:20b:161::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.12; Thu, 22 Dec 2022 15:22:17 +0000 Received: from AM0PR01MB5844.eurprd01.prod.exchangelabs.com ([fe80::fb9d:fa83:c2c4:b659]) by AM0PR01MB5844.eurprd01.prod.exchangelabs.com ([fe80::fb9d:fa83:c2c4:b659%7]) with mapi id 15.20.5924.016; Thu, 22 Dec 2022 15:22:17 +0000 To: "gdb-patches@sourceware.org" Subject: [PATCH] Fix target remote pipe command for MinGW Thread-Topic: [PATCH] Fix target remote pipe command for MinGW Thread-Index: AdkWAKlikBEzK8XbSRaPFhISCuFFhg== Date: Thu, 22 Dec 2022 15:22:17 +0000 Message-ID: Accept-Language: sv-SE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_ActionId=34492887-deb0-48e4-80ee-361af953971b; MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_ContentBits=0; MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_Enabled=true; MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_Method=Standard; MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_Name=1. Business; MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_SetDate=2022-12-22T12:25:20Z; MSIP_Label_8d6a82de-332f-43b8-a8a7-1928fd67507f_SiteId=097464b8-069c-453e-9254-c17ec707310d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM0PR01MB5844:EE_|AM0PR01MB6530:EE_ x-ms-office365-filtering-correlation-id: 81ba61ae-679a-4882-659e-08dae4305003 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /KpYpMFLPK6QN5zeBm3sABpGh4Jdg1NzN7DtRaBnX2YU+fpZhmxlSF/LYMQeaCtJ/OVp6uTYTZqFqfQvoSSRqH7KNMmHes+xx8CDP0YPh94hcy7BkW9e/N1GiLbNG2jRZbe3f14B4h2vL1WDwa69SyIpkbT90r2AGW8idyn71ZKBYapELRwEOw8K4hLZ+OzEAUp04AEZIF9CFGqC2q/GwCytUrv1IMvOBSpbQt6Vgbloo5wo2+Kgz9/WGsvvpRHnhBLdRQiUS9+wEjVZswN0d1fzIdaeJF7LMTqFK8O8QFp8L6mKtO7Vqb0pmXCSJaMr/90E4w2VR2+abnoTKGUrjrPDzYi2ySJ6hlj0wbOz7Nn3aGPBrOuOGVZpxgPuNj8soTDz+PxsG5LAbA4LBpKCOAoUZSG3YxzAByYpXOAqsXGzCVpXdhkthFjHDHFsWP82vgJ/BLoKAvdQDquIMbPR+6Pk4MIXfuTXTlaZvkte2N0z44rRjsKuBHq+NNaup3GHt6NQX7mGidDMFxACL+fDxZFA1hF0nrdy714U+gXCokrDI9uuKin1Xy5InCGwQAhFEhFHKW8rUXazZFcij02OVH+DwnU0MTogG2Ni6185qZUYTEc2ECfdoJfP+j9lEZub1inTZ9DZDuUbf8ZzJAOJXeWUYZejqHKQ/f5qKZw6kFUuiFypMNbQMox1SgPTqCkeItEY0mG5SDVuWFqSMf9vwQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR01MB5844.eurprd01.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199015)(8936002)(41300700001)(52536014)(86362001)(5660300002)(83380400001)(8676002)(4744005)(66476007)(66446008)(66556008)(66946007)(76116006)(64756008)(6506007)(186003)(7696005)(6916009)(2906002)(26005)(55016003)(122000001)(478600001)(33656002)(316002)(38100700002)(38070700005)(71200400001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?x30nrI/3GZprC184jzUdyyV?= =?iso-8859-1?q?Z/9G4P2d9Dcq55QzDVYJAUQOfTYX3sTNgtIR+5G2U6h/Nmw3cnpt0pXchQCI?= =?iso-8859-1?q?4s7DKideo+G2WwycaCA3YIPY6DTlRz4eSbh5iZ9xQVpEWiMK767du6ud8u0E?= =?iso-8859-1?q?C6y08dT2P5JIDWqSWM2+loX3MYSfXLOfIktJ5HVXM+48cAssFlxLd7/muYvM?= =?iso-8859-1?q?4xrn7aqGuytA5IcpnhAw/7oCxzylQrO0oXGeL8DcQnOJLLvYdJ+jVjLWcQM1?= =?iso-8859-1?q?5F6dF2E59GnNoY01WXuVjvglHyDd7ktqCKn66lzSMbeg3fLg5Gowdl2Zltqj?= =?iso-8859-1?q?+8cnUZJIJsQLzoOfrN224+2ewDHPyO91SGKmWV04S+/xB3IeCcohzJ+tTgUb?= =?iso-8859-1?q?o0a+uML/SdWlOuY1oIDAZJMW5oRtTLgZDqpShELQb2K5niy2REGf7ZChPcVb?= =?iso-8859-1?q?tThnF2MvhZ+0FEWwELFzA7P23+xb7H9wZHyGv8tP+BAIBKDPiIdoLVDNTmxM?= =?iso-8859-1?q?WsMibLTZqZDTOzKYqenScxfO6AaOLyz+7kPWIbdoqStpWt30gVjv0qUxPdCl?= =?iso-8859-1?q?SOWizKd1bV6pRGmh2hfgGDaH9AWotf+szv8hQLMApD7YaQKYIcF5dpvft2yq?= =?iso-8859-1?q?v6pKHXp09K8DLxFv7wJWEPHDfmsKG31HIHEhIMCBsQNfmSJY/S/CXuWYbPlX?= =?iso-8859-1?q?bY7r3UJ9Xx7B6vww99bOpvnS3BWQ489spccYIyy89dPJnilJOZvzZ/2J5PZM?= =?iso-8859-1?q?8XSVT07QyIYNUOnKx0cUB3qaes9jgKxCr8R3rQMKy26eARv7ZJXamVJW17Au?= =?iso-8859-1?q?SSenGCpzKy2+o7HVoXPUs+4p9HKguJwh9pSSwYmbLNA+08qFkPS+/FFfoWZc?= =?iso-8859-1?q?dvqJV3bZOSTBtjg1albuA7pgcY4f65Cpl1v1RKKsI5oBSrK0cqMNlNTYLpEN?= =?iso-8859-1?q?gMeetR/IykgW9JFsCeDZw/+SDFNeGFhwTL9V2a6i+H/om4aZrjSWcqaeiNH/?= =?iso-8859-1?q?hymSC8UhKTOIX0Bk9W8fUXzkP0cIWH3cFZM9Po6IrdoeAV/TVtY7rXZi7XrV?= =?iso-8859-1?q?7CBqrB14BTusgeR7w0wcLrvAXCf5dVWXddDpzFI3rraj0PkGR4Wx6UDaFG//?= =?iso-8859-1?q?L5W94wEDlq6b10gEqVIaNPzXb+hyXHp2wlao0r0pkbE5RUslCwzibLytSvjQ?= =?iso-8859-1?q?/ax3deiQSA1rcu6DoJeN++aKlwiSAq4kCuTyx/HSxsqR2OyZBu9cC+j7RDbX?= =?iso-8859-1?q?O2KuGh/bsWjWy7xHffW43iPVXi8+QsE2aYMGPI1smQnd6UCgM//FfAIcY8qT?= =?iso-8859-1?q?OZ9TkbXq7d1GVyRBbBm29ODqwG04WJlwDpdyNBjdqHQhEOn94iwFA3g72NdD?= =?iso-8859-1?q?psjVRdhPIqsxI3NKj9XbYriHLQxAVrWKq16GcBg9OjVkBMoNTNCH/c943sFk?= =?iso-8859-1?q?60TFvN71/7iIaf6uTacKBBY9CvdpmsbQXaMYthI8J+489vSC80z/tp7+5Y+M?= =?iso-8859-1?q?ETPqB8oxa8wWwdL7xnIdJ7mi0ogNCgr8r1+cgHmx8G9JWjL4N0KQgI5TuYBy?= =?iso-8859-1?q?1QPx7/wot47d3RitUid8XycbrUzhU1NrG6XKkT03qZY2gSsel5YMYCc+bZMP?= =?iso-8859-1?q?stiKP52kGgE+5XnXV?= MIME-Version: 1.0 X-OriginatorOrg: danfoss.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR01MB5844.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81ba61ae-679a-4882-659e-08dae4305003 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2022 15:22:17.7684 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 097464b8-069c-453e-9254-c17ec707310d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nnWx0IF+OYweHpC88OVaXtkQaqUpMNwndO6dsPMRBgrF4hUmgmH7ke9zB/+n5qIn5KVoM26sznV3xugEQ0OZAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR01MB6530 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jonas Hoerberg via Gdb-patches From: Jonas Hoerberg Reply-To: Jonas Hoerberg Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The cced7cacecad104fff0 ("gdb: preserve `|` in connection details string") commit added '|' detection and removal to ser-pipe.c, but missed to add it to ser-mingw.c. This results in the error message below for MinGW hosts: error starting child process '| ': CreateProcess: No such file or directory This commit add the missing '|' detection and removal to ser-mingw.c. --- gdb/ser-mingw.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.39.0.windows.1 Classified as Business diff --git a/gdb/ser-mingw.c b/gdb/ser-mingw.c index a62502b8d54..94b4d0df5da 100644 --- a/gdb/ser-mingw.c +++ b/gdb/ser-mingw.c @@ -867,6 +867,12 @@ pipe_windows_open (struct serial *scb, const char *name) if (name == NULL) error_no_arg (_("child command")); + if (*name == '|') + { + name++; + name = skip_spaces (name); + } + gdb_argv argv (name); if (! argv[0] || argv[0][0] == '\0')