From patchwork Thu Feb 25 16:38:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Walfred Tedeschi X-Patchwork-Id: 11089 Received: (qmail 59366 invoked by alias); 25 Feb 2016 16:39:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 59353 invoked by uid 89); 25 Feb 2016 16:39:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, MIME_BASE64_BLANKS, SPF_PASS autolearn=ham version=3.3.2 spammy=3967, 3968, 396, 8, fred X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Feb 2016 16:39:05 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 25 Feb 2016 08:39:03 -0800 X-ExtLoop1: 1 Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 25 Feb 2016 08:39:00 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.87]) by IRSMSX152.ger.corp.intel.com ([169.254.6.34]) with mapi id 14.03.0248.002; Thu, 25 Feb 2016 16:39:00 +0000 From: "Tedeschi, Walfred" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH obv] Initialize variables in i386_linux_handle_segmentation_fault Date: Thu, 25 Feb 2016 16:38:59 +0000 Message-ID: References: <1456416469-16334-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1456416469-16334-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-IsSubscribed: yes Thanks Simon, Haven't seen that. Regards, -Fred -----Original Message----- From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Simon Marchi Sent: Thursday, February 25, 2016 5:08 PM To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH obv] Initialize variables in i386_linux_handle_segmentation_fault FYI, I just pushed this as obvious. We see this error when building with gcc 4.3. ../../gdb/i386-linux-tdep.c: In function ‘i386_linux_handle_segmentation_fault’: ../../gdb/i386-linux-tdep.c:399: error: ‘access’ may be used uninitialized in this function ../../gdb/i386-linux-tdep.c:399: error: ‘upper_bound’ may be used uninitialized in this function ../../gdb/i386-linux-tdep.c:399: error: ‘lower_bound’ may be used uninitialized in this function It's a false positive, since the variables will always get initialized in the TRY clause, and the CATCH returns. gdb/ChangeLog: * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Initialize variables. --- gdb/ChangeLog | 5 +++++ gdb/i386-linux-tdep.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) -- 2.5.1 Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dc12399..00af395 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-02-25 Simon Marchi + + * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): + Initialize variables. + 2016-02-25 Antoine Tremblay * ax-general.c (ax_reg): Call gdbarch_remote_register_number. diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index 63cda45..42877da 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -396,7 +396,8 @@ void i386_linux_handle_segmentation_fault (struct gdbarch *gdbarch, struct ui_out *uiout) { - CORE_ADDR lower_bound, upper_bound, access; + /* -Wmaybe-uninitialized */ + CORE_ADDR lower_bound = 0, upper_bound = 0, access = 0; int is_upper; long sig_code = 0;