From patchwork Fri Apr 5 12:21:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88081 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9F923845BC1 for ; Fri, 5 Apr 2024 12:22:13 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DEEC63858415 for ; Fri, 5 Apr 2024 12:21:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEEC63858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DEEC63858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712319699; cv=none; b=ir+e7lnQFTU3WEc4Eap0Du4nKYMD3jyb/h3+wdln4fAGuGNeCn4MDJnwg/qMveMyR+kdOH/5w3cu+e7CiXyVhIDRCYcYc6dUeawV0t3ys8WC2WBRuV2KKk3bY83BdINsQStEgRveNgRup2CS4E6ld4QrtaAJ0P74xL/HH59U7vk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712319699; c=relaxed/simple; bh=Bz5nS2p/Cd/qgne2owoGb9RgYAYKxp8uvCJm2LlHTTs=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=xl1kZq2TfVJdU7HEx+6PecmnVTUJ6KhtE5M/wftfXyjG7lB7Big6cxDzqbkmPIXwHLhyf6FRwX05oQgksPvlO/AIo89VFwoMM53SUkg47ZV22qtK2ET862dinDTIn2WvtNJRPn8sRWfTJPiOEJwBvuKuM/PV3w7J/1r0DFhtjQ8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712319697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pvQUAOxkzDJFKXx4dULwEpeooPR78Tg7S79G2SPNYxA=; b=Ld5wIKdMfMRjG5KeTEUJVMYcaqlpRIvwA94ByAlNJV9HS4TZlRWKhXbEyiHYnI2mnKjc6p +ZNMk3mlST4zmNLUTIuCyvnKMiPdGLDej2P+MiE9xTjFyTj6MvbgP0lMM9n6QBn47VCYVz JjRj0V/8lpK3efd3jykYnKEmack/gMU= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-GVUkOckQNb-J2UX-iIt-6g-1; Fri, 05 Apr 2024 08:21:36 -0400 X-MC-Unique: GVUkOckQNb-J2UX-iIt-6g-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-56c5ce6dd4dso1501774a12.2 for ; Fri, 05 Apr 2024 05:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712319693; x=1712924493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pvQUAOxkzDJFKXx4dULwEpeooPR78Tg7S79G2SPNYxA=; b=pTchhV8dF35ooicTTjkm9TX507tliJ4XrTGlcbF8IbmhjewcMgEkRhfY3nvvQTzFtu jhLMbpgHoAQ6YEL39U54tSdzDr34UCr5OXhTwEJMQgz/r6czZoJGkMtj9KwQdvFgA/0i kppTytxPrzAAP5se7t1RNrL/6eiflDU0Xgh5gnX9mAm7v9N0REYovrsdOCk65UQcM24r vbpUYM9jC784tN6ywmmOJmPA38H5arbpcUkFq60iRxWyfmTsX76P9Li4wwbo1rr8bGUx VWzSgJJdiA6BwvD9JT8hcameFS6V2YGgHbm7nuoClsGXbcdU0WagDVcD492OfHO//hUr MULQ== X-Gm-Message-State: AOJu0YwaZBse/lvDmu7ASS/qZEd9SPzY25Z7WXLzo2EYjNMTpgD1E3QD lhDrNEEbWPr/xtKbcVQJ4Aqb89x1rQO8brIlg/6p7hIkHYw3eeoNk7b28/GjTRHZE2wubIVXMMG G7KxgoGpmlj2CQxb7Y3yJvpMmOFY3kcwNRcZrC3qCqdAdBNqAyOKt11GQrtZgIv0dSfya4mU0KD ngmZbxLNSMD/+iSRezc4zGmdL2/FHA7kYhzykL8E29npY= X-Received: by 2002:a50:9b56:0:b0:56b:c210:870c with SMTP id a22-20020a509b56000000b0056bc210870cmr959260edj.15.1712319693065; Fri, 05 Apr 2024 05:21:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdJA3fSa5JMjJcmLuQV+29P8mRLNHTZUVxbuj/aiEkikrI5f7zrv8hiMlyZV11L88oio036g== X-Received: by 2002:a50:9b56:0:b0:56b:c210:870c with SMTP id a22-20020a509b56000000b0056bc210870cmr959251edj.15.1712319692592; Fri, 05 Apr 2024 05:21:32 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id er18-20020a056402449200b0056bfc48406csm733371edb.7.2024.04.05.05.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 05:21:32 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/4] gdb/Makefile: add gcore to the 'all' target dependency list Date: Fri, 5 Apr 2024 13:21:25 +0100 Message-Id: <9c6e7010992178e170fa30092d48d9a37dd2315b.1712319537.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The gcore script is initially generated by the configure process, just like gdb-gdb.gdb and gdb-gdb.py. However if the gdb/gcore.in input source is modified then 'make all' in the gdb/ directory does not regenerate the gcore script. This is different than the gdb-gdb.gdb and gdb-gdb.py files, if their input is updated then 'make all' will regenerate these files. The difference is that for gdb-gdb.* there is an explicit dependency between the 'all' target and the generated file, this dependency is missing for gcore. This commit adds the dependency. Now, if gcore.in is changed, running 'make all' will regenerate the gcore script. There is no change in _what_ is generated after this commit. --- gdb/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index a9f641c0659..df044288b5e 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1938,7 +1938,7 @@ generated_files = \ # Flags needed to compile Python code PYTHON_CFLAGS = @PYTHON_CFLAGS@ -all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb +all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb gcore @$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=$(SUBDIRS)" subdir_do # Rule for compiling .c files in the top-level gdb directory.