From patchwork Wed Mar 19 22:46:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam James X-Patchwork-Id: 108578 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 57F2C3857C7F for ; Wed, 19 Mar 2025 22:47:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57F2C3857C7F X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 144CE3858C52 for ; Wed, 19 Mar 2025 22:47:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 144CE3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 144CE3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742424436; cv=none; b=VQmydPJry/S4ocgCtOHZ7IORUz/k7DAbaJ+Zq+lQItgsMVdf2CLpYAzOdm0moUGahxVtjlYVlPxOtrrQE46KGhtzZRuuwV4Pnp8af/01XPEljsrA4lLemqiAVbj2vcYXPV+ZRPIqSe7K1R9AYs8r2zPeW8maQblSTEdOC7QzUpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742424436; c=relaxed/simple; bh=C81VrQE3iKKxWxcW5X6fWCqyFjRid3SXmb3X9u2Vo90=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=q8K3yE6yP3ZAqd/iERFWzxQz9bM4xEBI9ZF48TMuVRkodcG0dLo1zVc73UDaL5151cRusDbS3BvyxuxEK2Fpw2ORBxYpsmCX5d8Mh3SlJWUzBC4Z9D2HMK/lCEZedoz8RZVJ6j1Ie3v7I6yXoeS6z96Erzx5VMoyy8pz88KFCpY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 144CE3858C52 Received: from mop.. (unknown [82.8.138.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sam@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id E6D7534310C; Wed, 19 Mar 2025 22:47:12 +0000 (UTC) From: Sam James To: gdb-patches@sourceware.org Cc: Andrew Burgess , Sam James Subject: [COMMITTED] gdb-add-index: quote PKGVERSION Date: Wed, 19 Mar 2025 22:46:53 +0000 Message-ID: <988a084f4dd281a5eeb9efe26987162ec090e19d.1742424413.git.sam@gentoo.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org In Gentoo, we configure our gdb with `--with-pkgversion=` with "Gentoo VERSION XXXX" where XXX depends on patching (not that we patch gdb really these days) or vanilla. Since 71f193a5c1cb02dcde6ac160cdab88e9725862bb, this goes wrong, yielding ``` /usr/bin/gdb-add-index: 25: Syntax error: "(" unexpected ``` with lines 25-26 being: ``` PKGVERSION=(Gentoo 9999 vanilla) VERSION=17.0.50.20250319-git ``` Quote both assignments (PKGVERSION by necessity, VERSION for consistency or symmetry). Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32325 --- Committed as obvious. gdb/contrib/gdb-add-index.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: d1da7bb43ecab2425a1135f09d6f62c9a7f63ae7 diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh index 4db123492f8..b299f830373 100755 --- a/gdb/contrib/gdb-add-index.sh +++ b/gdb/contrib/gdb-add-index.sh @@ -22,8 +22,8 @@ GDB=${GDB:=gdb} OBJCOPY=${OBJCOPY:=objcopy} READELF=${READELF:=readelf} -PKGVERSION=@PKGVERSION@ -VERSION=@VERSION@ +PKGVERSION="@PKGVERSION@" +VERSION="@VERSION@" myname="${0##*/}"