diff mbox

Remove i386bsd-tdep.o from x86_64-*-elf* target

Message ID 94eb2c0bbbf28763bf052ee215f4@google.com
State New
Headers show

Commit Message

Doug Evans March 25, 2016, 4:30 p.m. UTC
Hi all.

I'm currently working on an x86_64 "bare metal" target and am finding
various problems (patches to follow once I get things cleaned up).

In the process of cleaning things up, I'd like to make the following patch.
It's wrong to have bsd-anything (or linux, or ...)
in a bare $arch-elf target.

Ok?

2016-03-25  Doug Evans  <dje@google.com>

	* configure.tgt (x86_64-*-elf*): Remove i386bsd-tdep.o.

Comments

Pedro Alves March 29, 2016, 5:41 p.m. UTC | #1
On 03/25/2016 04:30 PM, Doug Evans wrote:
> Hi all.
> 
> I'm currently working on an x86_64 "bare metal" target and am finding
> various problems (patches to follow once I get things cleaned up).
> 
> In the process of cleaning things up, I'd like to make the following patch.
> It's wrong to have bsd-anything (or linux, or ...)
> in a bare $arch-elf target.
> 
> Ok?

This is fine with me.

Though I too would like to hear from Joel about the rtems bit.

> -x86_64-*-elf* | x86_64-*-rtems*)
> -    gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
> -     ;;
> +x86_64-*-elf*)
> +    gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o"

...

> +x86_64-*-rtems*)
> +    gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
> +    ;;

I've seen rtems configure patches fly by before, and IIRC, they tend
to just just make rtems an alias for bare-metal elf.  That seems to
be supported by other gdb/configure.tgt !x86 rtems stanzas.

I'm curious since that file contains support for old BSD a.out
ports (that is, !elf), and I'm proposing removing a.out support
in another patch.

Joel, does rtems really need anything in i386bsd-tdep.c?

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index c2b9c40..62c2331 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -650,9 +650,9 @@  x86_64-*-dicos*)
  	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o \
  			dicos-tdep.o i386-dicos-tdep.o amd64-dicos-tdep.o"
  	;;
-x86_64-*-elf* | x86_64-*-rtems*)
-	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
-	 ;;
+x86_64-*-elf*)
+	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o"
+	;;
  x86_64-*-linux*)
  	# Target: GNU/Linux x86-64
  	gdb_target_obs="amd64-tdep.o amd64-linux-tdep.o i386-tdep.o \
@@ -684,6 +684,9 @@  x86_64-*-openbsd*)
  			i387-tdep.o i386bsd-tdep.o i386obsd-tdep.o \
  			obsd-tdep.o bsd-uthread.o solib-svr4.o"
  	;;
+x86_64-*-rtems*)
+	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
+	;;
  xtensa*-*-linux*)	gdb_target=linux
  	# Target: GNU/Linux Xtensa
  	gdb_target_obs="xtensa-tdep.o xtensa-config.o xtensa-linux-tdep.o \