diff mbox

configure.tgt (x86_64-*-elf*): Remove i386bsd-tdep.o.

Message ID 94eb2c039f6ec8c1af05405a01fa@google.com
State New
Headers show

Commit Message

Doug Evans Nov. 2, 2016, 11:43 p.m. UTC
Hi.

This is just a cleanup.
I suppose there's the possibility of someone using x86_64-elf with bsd
but anything-elf is not supposed to have os-specific stuff like this.

Any objections?

For reference sake, it was added here.
I have no opinion on what to do for rtems so I kept things as is there.
Maybe when this was added it was just easier to lot x86_64-rtems together
with x86_64-elf?
I couldn't find an email thread, but just likely missed it.

commit f73dbb0e48ef50d2743fed89b68530b731329f05
Author: Joel Sherrill <joel.sherrill@oarcorp.com>
Date:   Fri Apr 3 19:08:27 2015 -0500

     Add x86_64-*-rtems* target

     	ld/configure.tgt: Also add stanza for x86_64-*-elf.

---

2016-11-02  Doug Evans  <dje@google.com>

	* configure.tgt (x86_64-*-elf*): Remove i386bsd-tdep.o.

Comments

Joel Sherrill Nov. 2, 2016, 11:56 p.m. UTC | #1
Please fix it as you see fit.  

You probably remember that all RTEMS targets for gdb and binutils are the same as the elf ones. No intention of adding an OS dependency. 

--joel

On November 2, 2016 6:43:24 PM CDT, Doug Evans <dje@google.com> wrote:
>Hi.
>
>This is just a cleanup.
>I suppose there's the possibility of someone using x86_64-elf with bsd
>but anything-elf is not supposed to have os-specific stuff like this.
>
>Any objections?
>
>For reference sake, it was added here.
>I have no opinion on what to do for rtems so I kept things as is there.
>Maybe when this was added it was just easier to lot x86_64-rtems
>together
>with x86_64-elf?
>I couldn't find an email thread, but just likely missed it.
>
>commit f73dbb0e48ef50d2743fed89b68530b731329f05
>Author: Joel Sherrill <joel.sherrill@oarcorp.com>
>Date:   Fri Apr 3 19:08:27 2015 -0500
>
>     Add x86_64-*-rtems* target
>
>     	ld/configure.tgt: Also add stanza for x86_64-*-elf.
>
>---
>
>2016-11-02  Doug Evans  <dje@google.com>
>
>	* configure.tgt (x86_64-*-elf*): Remove i386bsd-tdep.o.
>
>diff --git a/gdb/configure.tgt b/gdb/configure.tgt
>index d428dff..79473c9 100644
>--- a/gdb/configure.tgt
>+++ b/gdb/configure.tgt
>@@ -666,9 +666,9 @@ x86_64-*-dicos*)
>  	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o \
>  			dicos-tdep.o i386-dicos-tdep.o amd64-dicos-tdep.o"
>  	;;
>-x86_64-*-elf* | x86_64-*-rtems*)
>-	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
>-	 ;;
>+x86_64-*-elf*)
>+	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o"
>+	;;
>  x86_64-*-linux*)
>  	# Target: GNU/Linux x86-64
>  	gdb_target_obs="amd64-tdep.o amd64-linux-tdep.o i386-tdep.o \
>@@ -700,6 +700,9 @@ x86_64-*-openbsd*)
>  			i387-tdep.o i386bsd-tdep.o i386obsd-tdep.o \
>  			obsd-tdep.o bsd-uthread.o solib-svr4.o"
>  	;;
>+x86_64-*-rtems*)
>+	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
>+	;;
>  xtensa*-*-linux*)	gdb_target=linux
>  	# Target: GNU/Linux Xtensa
>  	gdb_target_obs="xtensa-tdep.o xtensa-config.o xtensa-linux-tdep.o \

--joel
Doug Evans Nov. 7, 2016, 9:17 p.m. UTC | #2
On Wed, Nov 2, 2016 at 4:56 PM, Joel Sherrill <joel.sherrill@oarcorp.com> wrote:
> Please fix it as you see fit.
>
> You probably remember that all RTEMS targets for gdb and binutils are the same as the elf ones. No intention of adding an OS dependency.
>
> --joel
>
> On November 2, 2016 6:43:24 PM CDT, Doug Evans <dje@google.com> wrote:
>>Hi.
>>
>>This is just a cleanup.
>>I suppose there's the possibility of someone using x86_64-elf with bsd
>>but anything-elf is not supposed to have os-specific stuff like this.
>>
>>Any objections?
>>
>>For reference sake, it was added here.
>>I have no opinion on what to do for rtems so I kept things as is there.
>>Maybe when this was added it was just easier to lot x86_64-rtems
>>together
>>with x86_64-elf?
>>I couldn't find an email thread, but just likely missed it.
>>
>>commit f73dbb0e48ef50d2743fed89b68530b731329f05
>>Author: Joel Sherrill <joel.sherrill@oarcorp.com>
>>Date:   Fri Apr 3 19:08:27 2015 -0500
>>
>>     Add x86_64-*-rtems* target
>>
>>       ld/configure.tgt: Also add stanza for x86_64-*-elf.

Committed, thanks.
diff mbox

Patch

diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index d428dff..79473c9 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -666,9 +666,9 @@  x86_64-*-dicos*)
  	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o \
  			dicos-tdep.o i386-dicos-tdep.o amd64-dicos-tdep.o"
  	;;
-x86_64-*-elf* | x86_64-*-rtems*)
-	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
-	 ;;
+x86_64-*-elf*)
+	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o"
+	;;
  x86_64-*-linux*)
  	# Target: GNU/Linux x86-64
  	gdb_target_obs="amd64-tdep.o amd64-linux-tdep.o i386-tdep.o \
@@ -700,6 +700,9 @@  x86_64-*-openbsd*)
  			i387-tdep.o i386bsd-tdep.o i386obsd-tdep.o \
  			obsd-tdep.o bsd-uthread.o solib-svr4.o"
  	;;
+x86_64-*-rtems*)
+	gdb_target_obs="amd64-tdep.o i386-tdep.o i387-tdep.o i386bsd-tdep.o"
+	;;
  xtensa*-*-linux*)	gdb_target=linux
  	# Target: GNU/Linux Xtensa
  	gdb_target_obs="xtensa-tdep.o xtensa-config.o xtensa-linux-tdep.o \