[1/3] gdb/testsuite: missing ';' in check-all-boards rule
Checks
| Context |
Check |
Description |
| linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Test passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Test passed
|
Commit Message
The check-all-boards makefile rule was missing a semicolon. As a
result we would pass "result=0" through to the make-check-all.sh
script.
This 'result=0' would end up inside the TESTS="..." string which was
passed to the 'make check-...' command. As 'result=0' doesn't match
any of GDB's .exp files the 'result=0' would then be ignored.
Back in the Makefile, due to the missing semicolon, as the
'result=...' line had become an extra argument to make-check-all.sh,
we were no longer capturing the exit status of the make-check-all.sh
script. This means that when the 'check-all-boards' rule completed we
actually exited with the exit status of the last command rather than
with the exit status of the make-check-all.sh script.
Fix this by adding in the missing semicolon.
There should be no changes in what is tested after this commit.
---
gdb/testsuite/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -386,7 +386,7 @@ check-all-boards: all $(abs_builddir)/site.exp
${abs_srcdir}/make-check-all.sh --keep-results \
--host-user "$(GDB_HOST_USERNAME)" \
--target-user "$(GDB_TARGET_USERNAME)" \
- "$(TESTS)" \
+ "$(TESTS)"; \
result=$$?; \
if test -d check-all; then \
$(SHELL) $(srcdir)/../../contrib/dg-extract-results.sh \