From patchwork Fri Nov 11 16:36:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 60432 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C1D13858025 for ; Fri, 11 Nov 2022 16:37:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C1D13858025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668184627; bh=FbksmJy+fSYgwuqW+YXlZJe2jh7/laEr96nx+j3lUJc=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=slZ5xphdYzZkBI/ZtJ/uNtwIHXdZCKg1szmi3iFosHLt2UazcNTu4odqZcIMVm2y2 K11ueq0R4KAN98+i339ns/WlT8nR9IcJR5NvDoLusJxmfET1Wq+d70tRtgDc5jWVWN 4KmQXyZrHsqi6LGgWv4JkQ5tToaA9n5eFAYgDV0M= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 23E243858D35 for ; Fri, 11 Nov 2022 16:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 23E243858D35 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-453-o8ZMKgH7NzeSAlnH0pDbbg-1; Fri, 11 Nov 2022 11:36:33 -0500 X-MC-Unique: o8ZMKgH7NzeSAlnH0pDbbg-1 Received: by mail-qt1-f198.google.com with SMTP id i13-20020ac8764d000000b003a4ec8693dcso3954569qtr.14 for ; Fri, 11 Nov 2022 08:36:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FbksmJy+fSYgwuqW+YXlZJe2jh7/laEr96nx+j3lUJc=; b=ubTEWKw5KXln4xAvI9vYRWb6zUPfDeziAWXDO4fSigL5lcbjSK51rO6HazTI5abhs9 Yl0MexTuygfQ76q8ab2Q+1OwGnh2sSIts2mjmSvTvBknBfvjNI804euqFSKMKNmKQh8t TGNceSnWtsH7y7JUXHmiF2mpQZy/FjmRLlVqwGthCF7TNzU7Ozt46NQovptaiOifqXZ7 JI4rI0vj8pxIwYewi1MwUuRTwVEDr0zk8fp71xZz4HudYyKibrL26EpLYhLm9IeBfJRe ueHK+e6opOuoiEoNBdwuel6G0xB+mYHDNJ4M0ToW5TSPBeYzUwd+wK1wVPGLreSLMiEg v+EA== X-Gm-Message-State: ANoB5pnhYCj/XkIt7Yy//mLN9v1F5KFGvPR0R/N4gsfC1iUeePiPiNi6 NSijW0mEqB25CtYhtQUI8fT5oaHJw23xf9rH4/w7554Ids/weWjUuNbr77MhAg/BzyAc8yH0s7e Q08Q+5o3NGJS3ZurJvk7iyh2StK7lyGaq1/2fzCnX3lG+vnI7JMEJXXJV7M6sm2NPFBJBPwBf7g == X-Received: by 2002:a05:6214:887:b0:4c6:141f:819d with SMTP id cz7-20020a056214088700b004c6141f819dmr2635236qvb.34.1668184592993; Fri, 11 Nov 2022 08:36:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf65rC8NmhBFSqb+JbYjGW0Hh4qgeFVU/TECwtgcIocLEgVMV7rqQXmAEPsM3LowffDOyXRYRg== X-Received: by 2002:a05:6214:887:b0:4c6:141f:819d with SMTP id cz7-20020a056214088700b004c6141f819dmr2635225qvb.34.1668184592745; Fri, 11 Nov 2022 08:36:32 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id n16-20020a05620a295000b006b640efe6dasm1635072qkp.132.2022.11.11.08.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 08:36:32 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/6] gdb/testsuite: don't avoid DWARF assembler tests with Clang Date: Fri, 11 Nov 2022 16:36:20 +0000 Message-Id: <91331c625a5a332ca1d3286ccc3a9ef21b6d1218.1668184173.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Two tests make the claim that the DWARF assembler requires gcc, however, this isn't true. I think at one point, when the DWARF assembler was first added, we did use some techniques that were not portable (see the comments in lib/dwarf.exp on function_range for details), however, I think most DWARF assembler tests will now work fine with Clang. The two tests that I modify in this commit both work fine with Clang, at least, I've tested with Clang 9.0.1 and 15.0.2, and don't see any problems, so I'm removing the early return logic that stops these tests from running with Clang. --- gdb/testsuite/gdb.base/until-trailing-insns.exp | 6 ------ gdb/testsuite/gdb.cp/incomplete-type-overload.exp | 5 ----- 2 files changed, 11 deletions(-) diff --git a/gdb/testsuite/gdb.base/until-trailing-insns.exp b/gdb/testsuite/gdb.base/until-trailing-insns.exp index 6396b6650c1..56f6cf038e2 100644 --- a/gdb/testsuite/gdb.base/until-trailing-insns.exp +++ b/gdb/testsuite/gdb.base/until-trailing-insns.exp @@ -84,12 +84,6 @@ if {![dwarf2_support]} { return 0 } -# The DWARF assembler requires the gcc compiler. -if {![is_c_compiler_gcc]} { - unsupported "gcc is required for this test" - return 0 -} - standard_testfile .c .S if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { diff --git a/gdb/testsuite/gdb.cp/incomplete-type-overload.exp b/gdb/testsuite/gdb.cp/incomplete-type-overload.exp index 96ed25dd5d1..024014d68ba 100644 --- a/gdb/testsuite/gdb.cp/incomplete-type-overload.exp +++ b/gdb/testsuite/gdb.cp/incomplete-type-overload.exp @@ -31,11 +31,6 @@ if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}] { return } -if {[test_compiler_info clang-*-*]} { - untested "gcc is required for dwarf assembler tests" - return -} - if ![runto_main] { return }