diff mbox

[1/4] gdb: Remove unused parameter

Message ID 8b1aeb820983ea0806c2260fde0aa20e388bf749.1560553051.git.andrew.burgess@embecosm.com
State New
Headers show

Commit Message

Andrew Burgess June 14, 2019, 11:01 p.m. UTC
The parameter 'fullname' is always passed as NULL to the function
get_filename_and_charpos in source.c, so lets remove the parameter.
There should be no user visible changes after this commit.

gdb/ChangeLog:

	* source.c (get_filename_and_charpos): Remove fullname
	parameter.
	(identify_source_line): Update call to get_filename_and_charpos.
---
 gdb/ChangeLog |  6 ++++++
 gdb/source.c  | 12 +++---------
 2 files changed, 9 insertions(+), 9 deletions(-)
diff mbox

Patch

diff --git a/gdb/source.c b/gdb/source.c
index 02df15a1ae6..5fa55e2c160 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -1201,17 +1201,11 @@  find_source_lines (struct symtab *s, int desc)
    or to 0 if the file is not found.  */
 
 static void
-get_filename_and_charpos (struct symtab *s, char **fullname)
+get_filename_and_charpos (struct symtab *s)
 {
   scoped_fd desc = open_source_file (s);
   if (desc.get () < 0)
-    {
-      if (fullname)
-	*fullname = NULL;
-      return;
-    }
-  if (fullname)
-    *fullname = s->fullname;
+    return;
   if (s->line_charpos == 0)
     find_source_lines (s, desc.get ());
 }
@@ -1223,7 +1217,7 @@  identify_source_line (struct symtab *s, int line, int mid_statement,
 		      CORE_ADDR pc)
 {
   if (s->line_charpos == 0)
-    get_filename_and_charpos (s, (char **) NULL);
+    get_filename_and_charpos (s);
   if (s->fullname == 0)
     return 0;
   if (line > s->nlines)