From patchwork Fri Jul 4 23:21:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 1923 Received: (qmail 31945 invoked by alias); 4 Jul 2014 23:20:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31827 invoked by uid 89); 4 Jul 2014 23:20:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 04 Jul 2014 23:20:26 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1X3ClN-0001Av-R3; Sat, 05 Jul 2014 01:19:37 +0200 From: Gabriel Krisman Bertazi To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures. In-Reply-To: (Sergio Durigan Junior's message of "Fri, 04 Jul 2014 12:35:18 -0300") References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Date: Fri, 04 Jul 2014 20:21:47 -0300 Message-ID: <87zjgobth0.fsf@Argo.krisman.be> MIME-Version: 1.0 X-IsSubscribed: yes Sergio Durigan Junior writes: > Thanks, this is great :-). Thanks for your review. > BTW, I recommend that this testcase be simplified. Instead of: I applied your suggestions. Below is a new version of the patch that simplifies the testcase. diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp index 579db03..1ac3623 100644 --- a/gdb/testsuite/gdb.fortran/array-element.exp +++ b/gdb/testsuite/gdb.fortran/array-element.exp @@ -31,18 +31,9 @@ if ![runto sub_] then { continue } -set bp_location [gdb_get_line_number "continue"] -gdb_test "break $bp_location" \ - "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \ - "breakpoint at continue" - -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint" -gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" +gdb_breakpoint [gdb_get_line_number "continue"] +gdb_continue_to_breakpoint "continue" -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint once again" +gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"