From patchwork Sun Aug 17 04:07:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 2408 Received: (qmail 7897 invoked by alias); 17 Aug 2014 04:07:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7872 invoked by uid 89); 17 Aug 2014 04:07:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 17 Aug 2014 04:07:42 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1XIriR-0000fA-Vp for gdb-patches@sourceware.org; Sun, 17 Aug 2014 06:05:12 +0200 From: Gabriel Krisman Bertazi To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures. References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> <87zjgobth0.fsf@Argo.krisman.be> <8761jbbu6l.fsf@Argo.krisman.be> <87lhrv36pm.fsf@Argo.krisman.be> Date: Sun, 17 Aug 2014 01:07:34 -0300 In-Reply-To: <87lhrv36pm.fsf@Argo.krisman.be> (Gabriel Krisman Bertazi's message of "Mon, 14 Jul 2014 19:40:05 -0300") Message-ID: <87zjf3sqrd.fsf@krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Gabriel Krisman Bertazi writes: >> Anyway, just minor comments, no need to resubmit the patch. Let's wait >> for some maintainer to take a look. Sorry, I went on vacation and missed a few weekly pings. Resending ping and updated patch. Is this ok for commit? 2014-08-17 Gabriel Krisman Bertazi * gdb.fortran/array-element.exp: Remove wrong "continue" command. Simplify test case. diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp index 579db03..1ac3623 100644 --- a/gdb/testsuite/gdb.fortran/array-element.exp +++ b/gdb/testsuite/gdb.fortran/array-element.exp @@ -31,18 +31,9 @@ if ![runto sub_] then { continue } -set bp_location [gdb_get_line_number "continue"] -gdb_test "break $bp_location" \ - "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \ - "breakpoint at continue" - -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint" -gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" +gdb_breakpoint [gdb_get_line_number "continue"] +gdb_continue_to_breakpoint "continue" -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint once again" +gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"