From patchwork Wed Jun 19 14:34:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33211 Received: (qmail 65183 invoked by alias); 19 Jun 2019 14:34:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65171 invoked by uid 89); 19 Jun 2019 14:34:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Jun 2019 14:34:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F3A8C560F7; Wed, 19 Jun 2019 10:34:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9KZ7IU-7Odwv; Wed, 19 Jun 2019 10:34:06 -0400 (EDT) Received: from murgatroyd (75-166-12-78.hlrn.qwest.net [75.166.12.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 73EB2560F6; Wed, 19 Jun 2019 10:34:06 -0400 (EDT) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [FYI] Fix crash when setting breakpoint condition References: <20190619120635.25475-1-tromey@adacore.com> Date: Wed, 19 Jun 2019 08:34:05 -0600 In-Reply-To: (Pedro Alves's message of "Wed, 19 Jun 2019 13:49:36 +0100") Message-ID: <87sgs5fxuq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Pedro> This is missing an intro comment mentioning what the testcase is about. Pedro> Should say something similar to "Test Ada breakpoint conditions Pedro> involving arrays lengths.", I suppose. Here's what I'm checking in. Tom commit 899277ae529c2b743d22093fcc1a9e46aff4422a Author: Tom Tromey Date: Wed Jun 19 08:32:35 2019 -0600 Add intro comment to length_cond.exp Pedro pointed out that the new length_cond.exp test did not have an intro comment. This adds one. gdb/testsuite/ChangeLog 2019-06-19 Tom Tromey * gdb.ada/length_cond.exp: Add intro comment. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8454b00755c..60a19eb5f0b 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-06-19 Tom Tromey + + * gdb.ada/length_cond.exp: Add intro comment. + 2019-06-19 Tom Tromey * gdb.ada/length_cond.exp: New file. diff --git a/gdb/testsuite/gdb.ada/length_cond.exp b/gdb/testsuite/gdb.ada/length_cond.exp index 53e9187dc4d..7a37c5f2ac5 100644 --- a/gdb/testsuite/gdb.ada/length_cond.exp +++ b/gdb/testsuite/gdb.ada/length_cond.exp @@ -13,6 +13,9 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +# Regression test for a crash that would happen when setting a +# breakpoint condition that used an array attribute. + load_lib "ada.exp" standard_ada_testfile length_cond