From patchwork Fri Feb 20 08:47:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Wingo X-Patchwork-Id: 5203 Received: (qmail 5534 invoked by alias); 20 Feb 2015 08:48:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5514 invoked by uid 89); 20 Feb 2015 08:48:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_NEUTRAL autolearn=ham version=3.3.2 X-HELO: sasl.smtp.pobox.com Received: from pb-sasl1.int.icgroup.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Feb 2015 08:48:06 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id B05A033E4E; Fri, 20 Feb 2015 03:48:03 -0500 (EST) Received: from pb-sasl1.int.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id A784F33E4D; Fri, 20 Feb 2015 03:48:03 -0500 (EST) Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id AF83133E4A; Fri, 20 Feb 2015 03:48:02 -0500 (EST) From: Andy Wingo To: gdb-patches@sourceware.org Cc: Andy Wingo , Doug Evans Subject: Add frame-read-register Date: Fri, 20 Feb 2015 09:47:59 +0100 Message-ID: <87r3tl0y0w.fsf@igalia.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 X-Pobox-Relay-ID: 2E165D32-B8DD-11E4-A271-8FDD009B7A5A-02397024!pb-sasl1.pobox.com Hi, The attached patch adds frame-read-register to the Guile interface, like Frame.read_register() for python. Andy From cb83778843bbdf4f32c990ca0fc3d16841456d66 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Fri, 20 Feb 2015 09:33:59 +0100 Subject: [PATCH] Add Guile frame-read-register command gdb/ChangeLog: 2015-02-20 Andy Wingo * guile/scm-frame.c (gdbscm_frame_read_register): New function. (frame_functions): Bind gdbscm_frame_read_register to frame-read-register. * guile/lib/gdb.scm (frame-read-register): Export. gdb/doc/ChangeLog: 2015-02-20 Andy Wingo * guile.texi (Frames In Guile): Describe frame-read-register. gdb/testsuite/ChangeLog: 2015-02-20 Andy Wingo * gdb.guile/scm-frame.exp: Add frame-read-register tests, modelled after the Python tests. --- gdb/ChangeLog | 7 +++++ gdb/doc/ChangeLog | 4 +++ gdb/doc/guile.texi | 5 +++ gdb/guile/lib/gdb.scm | 1 + gdb/guile/scm-frame.c | 58 +++++++++++++++++++++++++++++++++++ gdb/testsuite/ChangeLog | 5 +++ gdb/testsuite/gdb.guile/scm-frame.exp | 20 ++++++++++++ 7 files changed, 100 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ee126eb..34bfba9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2015-02-20 Andy Wingo + + * guile/scm-frame.c (gdbscm_frame_read_register): New function. + (frame_functions): Bind gdbscm_frame_read_register to + frame-read-register. + * guile/lib/gdb.scm (frame-read-register): Export. + 2015-02-15 Andy Wingo * guile/scm-frame-filter.c: diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index c7f6470..cb31292 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2015-02-20 Andy Wingo + + * guile.texi (Frames In Guile): Describe frame-read-register. + 2015-02-15 Andy Wingo * guile.texi (Guile Frame Filter API) diff --git a/gdb/doc/guile.texi b/gdb/doc/guile.texi index 8ea9748..7bfdda8 100644 --- a/gdb/doc/guile.texi +++ b/gdb/doc/guile.texi @@ -2816,6 +2816,11 @@ Return the frame's @code{} (symtab and line) object. @xref{Symbol Tables In Guile}. @end deffn +@deffn {Scheme Procedure} frame-read-register frame register +Return the value of @var{register} in @var{frame}. @var{register} +should be a string, like @samp{pc}. +@end deffn + @deffn {Scheme Procedure} frame-read-var frame variable @r{[}#:block block@r{]} Return the value of @var{variable} in @var{frame}. If the optional argument @var{block} is provided, search for the variable from that diff --git a/gdb/guile/lib/gdb.scm b/gdb/guile/lib/gdb.scm index cc35bc1..2eb05ea 100644 --- a/gdb/guile/lib/gdb.scm +++ b/gdb/guile/lib/gdb.scm @@ -219,6 +219,7 @@ frame-older frame-newer frame-sal + frame-read-register frame-read-var frame-select newest-frame diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c index 3927714..8483b28 100644 --- a/gdb/guile/scm-frame.c +++ b/gdb/guile/scm-frame.c @@ -28,6 +28,7 @@ #include "symfile.h" #include "symtab.h" #include "stack.h" +#include "user-regs.h" #include "value.h" #include "guile-internal.h" @@ -748,6 +749,57 @@ gdbscm_frame_sal (SCM self) return stscm_scm_from_sal (sal); } +/* (frame-read-register string) -> + The register argument must be a string. */ + +static SCM +gdbscm_frame_read_register (SCM self, SCM register_scm) +{ + volatile struct gdb_exception except; + char *register_str; + struct value *value = NULL; + struct frame_info *frame = NULL; + struct cleanup *cleanup; + frame_smob *f_smob; + + f_smob = frscm_get_frame_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); + gdbscm_parse_function_args (FUNC_NAME, SCM_ARG2, NULL, "s", + register_scm, ®ister_str); + cleanup = make_cleanup (xfree, register_str); + + TRY_CATCH (except, RETURN_MASK_ALL) + { + int regnum; + + frame = frscm_frame_smob_to_frame (f_smob); + if (frame) + { + regnum = user_reg_map_name_to_regnum (get_frame_arch (frame), + register_str, + strlen (register_str)); + if (regnum >= 0) + value = value_of_register (regnum, frame); + } + } + GDBSCM_HANDLE_GDB_EXCEPTION (except); + + do_cleanups (cleanup); + + if (frame == NULL) + { + gdbscm_invalid_object_error (FUNC_NAME, SCM_ARG1, self, + _("")); + } + + if (value == NULL) + { + gdbscm_out_of_range_error (FUNC_NAME, SCM_ARG2, register_scm, + _("unknown register")); + } + + return vlscm_scm_from_value (value); +} + /* (frame-read-var ) -> (frame-read-var string [#:block ]) -> If the optional block argument is provided start the search from that block, @@ -1021,6 +1073,12 @@ Return the value of the symbol in the frame.\n\ Arguments: \n\ Or: string [#:block ]" }, + { "frame-read-register", 2, 0, 0, gdbscm_frame_read_register, + "\ +Return the value of the register in the frame.\n\ +\n\ + Arguments: string" }, + { "frame-select", 1, 0, 0, gdbscm_frame_select, "\ Select this frame." }, diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 4fe771e..2d96ea8 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-02-20 Andy Wingo + + * gdb.guile/scm-frame.exp: Add frame-read-register tests, modelled + after the Python tests. + 2015-02-09 Mark Wielaard * gdb.dwarf2/atomic.c: New file. diff --git a/gdb/testsuite/gdb.guile/scm-frame.exp b/gdb/testsuite/gdb.guile/scm-frame.exp index 7af9092..9a5eb1e 100644 --- a/gdb/testsuite/gdb.guile/scm-frame.exp +++ b/gdb/testsuite/gdb.guile/scm-frame.exp @@ -120,3 +120,23 @@ gdb_test "guile (print (format #f \"= ~A\" (frame-read-var f0 \"a\")))" \ gdb_test "guile (print (format #f \"= ~A\" (eq? (selected-frame) f1)))" \ "= #t" "test selected-frame" + +# Can read SP register. +gdb_test "guile (print (equal? (frame-read-register (selected-frame) \"sp\") (parse-and-eval \"\$sp\")))" \ + "= #t" "test frame-read-register of sp" + +# PC value obtained via read_register is as expected. +gdb_test "guile (print (equal? (value->integer (frame-read-register f0 \"pc\")) (frame-pc f0)))" \ + "= #t" "test frame-read-register of pc" + +# Test arch-specific register name. +set pc "" +if {[is_amd64_regs_target]} { + set pc "rip" +} elseif {[is_x86_like_target]} { + set pc "eip" +} +if { $pc != "" } { + gdb_test "guile (print (equal? (frame-read-register f0 \"pc\") (frame-read-register f0 \"$pc\")))" \ + "= #t" "test frame-read-register of $pc" +} -- 2.1.4