From patchwork Wed Apr 23 17:11:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 651 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id B413F3604CF for ; Wed, 23 Apr 2014 10:11:47 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 6B0EE62F0D91B; Wed, 23 Apr 2014 10:11:47 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 41EE862EAC2B3 for ; Wed, 23 Apr 2014 10:11:47 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=NQUq9 hpvAMgxzsBP1f+7hVEULIYV82aWhXn1aOkqi4wkhu0Glx2OuRTsbqp1CTcwLV/sh sGR1dCykDbX+AqB/mosdEL7Iez8K7hybjfRzXN7ST7l3GYcngV2p43elXcJ9w6D9 2U1j0hNA7GOEuQnF1P1KkgsJBkaSjYeRmskUBc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=TPUhpcJ7a41 Gxxhw3o+YaF6NAzw=; b=wY0FIfvGn90+HMFd6dece0ICs+sN7rE/krnERj4dAKQ z8GUjdJrzbBguecPURwVG+IgWyV8Mc3s/+XLujMtCtdc/tbnY75JEp1pfFUp2GYF 0bBczjqPJP8INHCVMToQuC8MPGkX+9JyX4xTkDXJLKma3D7wKG1pLVz4m4R5BXL4 = Received: (qmail 3099 invoked by alias); 23 Apr 2014 17:11:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3090 invoked by uid 89); 23 Apr 2014 17:11:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 17:11:44 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NHBgMk006074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Apr 2014 13:11:42 -0400 Received: from barimba (ovpn-113-42.phx2.redhat.com [10.3.113.42]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3NHBeLt002592 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 23 Apr 2014 13:11:41 -0400 From: Tom Tromey To: Daniel Gutson Cc: gdb-patches Subject: Re: specifying gdb's exit code References: Date: Wed, 23 Apr 2014 11:11:40 -0600 In-Reply-To: (Daniel Gutson's message of "Thu, 17 Apr 2014 18:51:57 -0300") Message-ID: <87ppk89dir.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.90 (gnu/linux) MIME-Version: 1.0 X-DH-Original-To: gdb@patchwork.siddhesh.in >>>>> "Daniel" == Daniel Gutson writes: Daniel> What about this? Daniel> (I'm not a native English speaker) I wonder what you think of the appended. It adds an explicit "Usage" line, which gdb does in a few other spots and which I think it generally the most clear approach. Tom diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index bfcd975..298f54c 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1685,7 +1685,11 @@ strict == evaluate script according to filename extension, error if not supporte show_script_ext_mode, &setlist, &showlist); - add_com ("quit", class_support, quit_command, _("Exit gdb.")); + add_com ("quit", class_support, quit_command, _("\ +Exit gdb.\n\ +Usage: quit [CODE]\n\ +The optional argument CODE, if present, is used as gdb's exit status.\n\ +The default is zero.")); c = add_com ("help", class_support, help_command, _("Print list of commands.")); set_cmd_completer (c, command_completer);