From patchwork Tue Jun 18 15:29:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33186 Received: (qmail 98511 invoked by alias); 18 Jun 2019 15:29:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 98483 invoked by uid 89); 18 Jun 2019 15:29:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jun 2019 15:29:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 08189560EC; Tue, 18 Jun 2019 11:29:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lyB34HZxXHnb; Tue, 18 Jun 2019 11:29:24 -0400 (EDT) Received: from murgatroyd (75-166-12-78.hlrn.qwest.net [75.166.12.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 862C656071; Tue, 18 Jun 2019 11:29:24 -0400 (EDT) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix "list" when control characters are seen References: <20190409185432.16985-1-tromey@adacore.com> <32fe2c91-99f5-5b2a-ccaa-8481b1747dd5@redhat.com> Date: Tue, 18 Jun 2019 09:29:23 -0600 In-Reply-To: <32fe2c91-99f5-5b2a-ccaa-8481b1747dd5@redhat.com> (Pedro Alves's message of "Tue, 18 Jun 2019 14:24:17 +0100") Message-ID: <87lfxylxnw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 >> static void foo (int x) >> /* ! >> - ! >> + Pedro> This seems pretty obscure without the context of the patch around. Pedro> Should we add a comment here? Good idea, how's this? Tom commit d20ed5fd574ce1b72543c2963fa53946eb2225de Author: Tom Tromey Date: Tue Jun 18 09:27:45 2019 -0600 Add comment to list0.h Pedro suggested adding a comment to list0.h to explain the control character. Tested on x86-64 Fedora 29. gdb/testsuite/ChangeLog 2019-06-18 Tom Tromey * gdb.base/list0.h: Add comment explaining control character. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b6fcf58c7dd..75adad35f48 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-06-18 Tom Tromey + + * gdb.base/list0.h: Add comment explaining control character. + 2019-06-18 Tom de Vries * boards/fission.exp: Break up long debug_flags line. diff --git a/gdb/testsuite/gdb.base/list0.h b/gdb/testsuite/gdb.base/list0.h index 6f280935509..ba18e29268e 100644 --- a/gdb/testsuite/gdb.base/list0.h +++ b/gdb/testsuite/gdb.base/list0.h @@ -2,7 +2,7 @@ extern void bar(int); static void foo (int x) -/* ! +/* ! the next line has a control character, see PR symtab/24423. ! */ {