From patchwork Tue Jun 30 18:09:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Arnez X-Patchwork-Id: 7437 Received: (qmail 64742 invoked by alias); 30 Jun 2015 18:09:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64184 invoked by uid 89); 30 Jun 2015 18:09:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp15.uk.ibm.com Received: from e06smtp15.uk.ibm.com (HELO e06smtp15.uk.ibm.com) (195.75.94.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 30 Jun 2015 18:09:13 +0000 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Jun 2015 19:09:09 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 30 Jun 2015 19:09:07 +0100 X-MailFrom: arnez@linux.vnet.ibm.com X-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6C4411B08067 for ; Tue, 30 Jun 2015 19:10:14 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5UI971S40632458 for ; Tue, 30 Jun 2015 18:09:07 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5UI97BI020070 for ; Tue, 30 Jun 2015 12:09:07 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-115.boeblingen.de.ibm.com [9.152.212.115]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t5UI966w020030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO); Tue, 30 Jun 2015 12:09:06 -0600 From: Andreas Arnez To: Yao Qi Cc: Doug Evans , Joel Brobecker , gdb-patches Subject: Re: Several regressions and we branch soon. References: <86r3p1queo.fsf@gmail.com> <87lhf8yz90.fsf@br87z6lw.de.ibm.com> <87a8vnzmzy.fsf@br87z6lw.de.ibm.com> <86twtpp6i0.fsf@gmail.com> Date: Tue, 30 Jun 2015 20:09:06 +0200 In-Reply-To: <86twtpp6i0.fsf@gmail.com> (Yao Qi's message of "Tue, 30 Jun 2015 16:20:55 +0100") Message-ID: <87h9ppkr0d.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15063018-0021-0000-0000-00000473C07E X-IsSubscribed: yes On Tue, Jun 30 2015, Yao Qi wrote: > Andreas Arnez writes: > >> Right, this was considered in the patch. But only what I've actually >> seen fail in my testing is marked as KFAIL. Since more FAILs are >> observed now, maybe we could mark them as KFAIL as well. Or skip them >> altogether, like in the patch below. WDYT? > > I am inclined to skip them altogether, but I think we need skip more. > With your patch applied, I still see them in gdb.sum > > KFAIL: gdb.base/gnu_vector.exp: call add_some_intvecs (PRMS: gdb/18537) > KPASS: gdb.base/gnu_vector.exp: call add_many_charvecs (PRMS gdb/18537) > KFAIL: gdb.base/gnu_vector.exp: call add_various_floatvecs (PRMS: gdb/18537) > KFAIL: gdb.base/gnu_vector.exp: call add_structvecs (PRMS: gdb/18537) > KFAIL: gdb.base/gnu_vector.exp: skip remaining vector ABI tests on this arch (PRMS: gdb/18537) > > KPASS is confusing here. I'd like to skip all of them on x86 and emit > UNSUPPORTED in gdb.sum, because we've already know that vector infcall > doesn't support on x86, UNSUPPORTED is better than KFAIL, IMO. You're probably right. I chose KFAIL because GDB doesn't provide any indication that this is not expected to work correctly, but yields a wrong result instead. Anyway, the KFAILs obviously bring more trouble than benefit, and UNSUPPORTED looks good enough to me. So how about this? -- >8 -- Subject: [PATCH] gnu_vector.exp: Skip infcall tests on x86/x86_64 Since the new KFAILs/KPASSs for the infcall tests on x86 and x86_64 targets generated unnecessary noise, this change skips them with UNSUPPORTED instead. gdb/testsuite/ChangeLog: * gdb.base/gnu_vector.exp: On x86 and x86_64 targets, skip the infcall tests instead of setting up for KFAIL. --- gdb/testsuite/gdb.base/gnu_vector.exp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.base/gnu_vector.exp b/gdb/testsuite/gdb.base/gnu_vector.exp index cf91fbb..173da4d 100644 --- a/gdb/testsuite/gdb.base/gnu_vector.exp +++ b/gdb/testsuite/gdb.base/gnu_vector.exp @@ -177,16 +177,19 @@ gdb_test "ptype struct_with_vector_1" "type = struct {\r\n\[\t \]+int i;\r\n\[\t # Test inferior function calls with vector arguments and/or vector # return values. -setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" +if { [istarget "i?86-*-*"] || [istarget "x86_64-*-*" ] } { + # These platforms don't support infcalls with vector arguments + # and/or vector return values, so skip the remaining tests. + # See also PR exp/18537. + unsupported "skip remaining vector ABI tests on this arch" + return +} gdb_test "print add_some_intvecs(i4a, i4b, 3 * i4a)" "= \\{17, 34, 72, 132\\}" \ "call add_some_intvecs" -setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" gdb_test "print add_many_charvecs(c4, c4, c4, c4, c4, c4, c4, c4, c4, c4)" \ "= \\{10, 20, 30, 40\\}" "call add_many_charvecs" -setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" gdb_test "print add_various_floatvecs(2, f4a, f4b)" "= \\{3, 6, 16, 20\\}" \ "call add_various_floatvecs" -setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" gdb_test "print add_structvecs(i2, (struct just_int2)\{2*i2\}, (struct two_int2)\{3*i2, 4*i2\})" \ "= \\{i = \\{10, 20\\}\\}" "call add_structvecs" gdb_test "print add_singlevecs((char1) \{6\}, (int1) \{12\}, (double1) \{24\})" "= \\{42\\}" \ @@ -195,7 +198,6 @@ gdb_test "print add_singlevecs((char1) \{6\}, (int1) \{12\}, (double1) \{24\})" # Test vector return value handling with "finish" and "return". gdb_breakpoint "add_some_intvecs" gdb_continue "add_some_intvecs" -setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" gdb_test "finish" "Value returned is .* = \\{10, 20, 48, 72\\}" \ "finish shows vector return value" gdb_continue "add_some_intvecs" @@ -203,5 +205,4 @@ gdb_test "return (int4) \{4, 2, 7, 6\}" \ "#0 .* main .*" \ "set vector return value" \ "Make add_some_intvecs return now. .y or n.*" "y" -setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" gdb_test "continue" "4 2 7 6\r\n.*" "verify vector return value"