From patchwork Mon Jun 15 16:05:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Arnez X-Patchwork-Id: 7185 Received: (qmail 102860 invoked by alias); 15 Jun 2015 16:05:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102795 invoked by uid 89); 15 Jun 2015 16:05:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp14.uk.ibm.com Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 15 Jun 2015 16:05:26 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Jun 2015 17:05:22 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 15 Jun 2015 17:05:20 +0100 X-MailFrom: arnez@linux.vnet.ibm.com X-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 549C417D8067 for ; Mon, 15 Jun 2015 17:06:24 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5FG5Kq123789798 for ; Mon, 15 Jun 2015 16:05:20 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5FG5Jda025196 for ; Mon, 15 Jun 2015 10:05:19 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-115.boeblingen.de.ibm.com [9.152.212.115]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t5FG5Ii6025153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO); Mon, 15 Jun 2015 10:05:18 -0600 From: Andreas Arnez To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, sergiodj@redhat.com (Sergio Durigan Junior) Subject: Re: [PATCH] Add vector ABI tests to gnu_vector.exp References: <20150612154853.53B9C12CF@oc7340732750.ibm.com> Date: Mon, 15 Jun 2015 18:05:18 +0200 In-Reply-To: <20150612154853.53B9C12CF@oc7340732750.ibm.com> (Ulrich Weigand's message of "Fri, 12 Jun 2015 17:48:53 +0200 (CEST)") Message-ID: <87egld0xfl.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15061516-0017-0000-0000-00000468F722 X-IsSubscribed: yes On Fri, Jun 12 2015, Ulrich Weigand wrote: > Andreas Arnez wrote: > >> [...] >> Since GDB has no vector ABI support for x86 and x86_64 targets, most of >> the new checks are XFAILed there. > > As this due to a known GDB problem and not something in the environment, > that should be a KFAIL, not an XFAIL. OK, I've opened a bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18537 and changed the XFAILs to KFAILs pointing to that bug, as shown by the patch below. diff --git a/gdb/testsuite/gdb.base/gnu_vector.exp b/gdb/testsuite/gdb.base/gnu_vector.exp index 9fe3a27..cf91fbb 100644 --- a/gdb/testsuite/gdb.base/gnu_vector.exp +++ b/gdb/testsuite/gdb.base/gnu_vector.exp @@ -180 +180 @@ gdb_test "ptype struct_with_vector_1" "type = struct {\r\n\[\t \]+int i;\r\n\[\t -setup_xfail "i?86-*-*" "x86_64-*-*" +setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" @@ -183 +183 @@ gdb_test "print add_some_intvecs(i4a, i4b, 3 * i4a)" "= \\{17, 34, 72, 132\\}" \ -setup_xfail "i?86-*-*" "x86_64-*-*" +setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" @@ -186 +186 @@ gdb_test "print add_many_charvecs(c4, c4, c4, c4, c4, c4, c4, c4, c4, c4)" \ -setup_xfail "i?86-*-*" "x86_64-*-*" +setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" @@ -189 +189 @@ gdb_test "print add_various_floatvecs(2, f4a, f4b)" "= \\{3, 6, 16, 20\\}" \ -setup_xfail "i?86-*-*" "x86_64-*-*" +setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" @@ -198 +198 @@ gdb_continue "add_some_intvecs" -setup_xfail "i?86-*-*" "x86_64-*-*" +setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*" @@ -206 +206 @@ gdb_test "return (int4) \{4, 2, 7, 6\}" \ -setup_xfail "i?86-*-*" "x86_64-*-*" +setup_kfail gdb/18537 "i?86-*-*" "x86_64-*-*"