From patchwork Mon Aug 4 14:09:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 2296 Received: (qmail 22730 invoked by alias); 4 Aug 2014 14:09:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 22715 invoked by uid 89); 4 Aug 2014 14:09:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 04 Aug 2014 14:09:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s74E9AnK031086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Aug 2014 10:09:10 -0400 Received: from barimba (ovpn-113-151.phx2.redhat.com [10.3.113.151]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s74E98Lc012612 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 4 Aug 2014 10:09:09 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] make "set debug target" take effect immediately References: <1406574267-5212-1-git-send-email-tromey@redhat.com> <53D74AE0.3050404@codesourcery.com> <8738dkarhc.fsf@fleche.redhat.com> <53D84788.2070905@codesourcery.com> <87ppgn9dgs.fsf@fleche.redhat.com> Date: Mon, 04 Aug 2014 08:09:08 -0600 In-Reply-To: <87ppgn9dgs.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 30 Jul 2014 07:35:15 -0600") Message-ID: <87d2cgqrcr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 >>>>> "Yao" == Tom Tromey writes: Tom> What do you think of the appended? Yao> We need to replace "target_resume" in the comments several lines above Yao> too, Tom> Thanks. I've fixed it locally. Here is what I am checking in. Tom 2014-08-04 Tom Tromey * gdb.base/sss-bp-on-user-bp-2.exp: Match "to_resume", not "target_resume". diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp index a196f68..cb95da0 100644 --- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp +++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp @@ -53,7 +53,7 @@ delete_breakpoints # traffic. Hardware-step targets that can't access memory while the # target is running, either remote or native, are likewise affected. # So we just skip the test if not using software single-stepping. We -# detect that by looking for 'target_resume (..., step)' in "debug +# detect that by looking for 'to_resume (..., step)' in "debug # target" output. # Probe for software single-step breakpoint use. @@ -62,7 +62,7 @@ gdb_test_no_output "set debug target 1" set hardware_step 0 set test "probe target hardware step" gdb_test_multiple "si" $test { - -re "target_resume \\(\[^\r\n\]+, step, .*$gdb_prompt $" { + -re "to_resume \\(\[^\r\n\]+, step, .*$gdb_prompt $" { set hardware_step 1 pass $test }