diff mbox

breakpoint-in-ro-region.exp: Support targets stopping in mid-line after "si"

Message ID 87bnkaxp8n.fsf@br87z6lw.de.ibm.com
State New
Headers show

Commit Message

Andreas Arnez March 3, 2015, 12:03 p.m. UTC
On some targets each of the assignments "i = 0" in the C source for
"breakpoint-in-ro-region.exp" are compiled to a single instruction.
Then each "si" stops at the beginning of the next source line.  But on
some other targets (like s390) such an assignment compiles to multiple
instructions.  Then "si" may stop in mid-line, and GDB displays the PC
address in addition to the source line number.  This was not considered
by the regexp for this case.

gdb/testsuite/ChangeLog:

	* gdb.base/breakpoint-in-ro-region.exp (test_single_step): In the
	regexps for GDB's current line display, accept a hex address
	preceding the line number.
---
 gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Yao Qi March 3, 2015, 12:25 p.m. UTC | #1
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:

> On some targets each of the assignments "i = 0" in the C source for
> "breakpoint-in-ro-region.exp" are compiled to a single instruction.
> Then each "si" stops at the beginning of the next source line.  But on
> some other targets (like s390) such an assignment compiles to multiple
> instructions.  Then "si" may stop in mid-line, and GDB displays the PC
> address in addition to the source line number.  This was not considered
> by the regexp for this case.

Yes, they fail on aarch64-linux too.

>
> gdb/testsuite/ChangeLog:
>
> 	* gdb.base/breakpoint-in-ro-region.exp (test_single_step): In the
> 	regexps for GDB's current line display, accept a hex address
> 	preceding the line number.

It looks good to me.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp b/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp
index d27a0bb..2c9bac0 100644
--- a/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp
+++ b/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp
@@ -191,6 +191,7 @@  delete_breakpoints
 proc test_single_step { always_inserted auto_hw } {
     global gdb_prompt
     global decimal
+    global hex
     global supports_hbreak
     global hw_step
 
@@ -215,11 +216,11 @@  proc test_single_step { always_inserted auto_hw } {
 	    gdb_assert {!$hw_step && $auto_hw == "off"} \
 		"$test (cannot insert sw break)"
 	}
-	-re "^si\r\nNote: automatically using hardware breakpoints for read-only addresses\.\r\n${decimal}\[ \t\]+i = 0;\r\n$gdb_prompt $" {
+	-re "^si\r\nNote: automatically using hardware breakpoints for read-only addresses\.\r\n\(\?\:${hex}\[ \t\]\)\?${decimal}\[ \t\]+i = 0;\r\n$gdb_prompt $" {
 	    gdb_assert {!$hw_step && $auto_hw == "on" && $supports_hbreak} \
 		"$test (auto-hw)"
 	}
-	-re "^si\r\n${decimal}\[ \t\]+i = 0;\r\n$gdb_prompt $" {
+	-re "^si\r\n\(\?\:${hex}\[ \t\]\)\?${decimal}\[ \t\]+i = 0;\r\n$gdb_prompt $" {
 	    gdb_assert {$hw_step || ($auto_hw == "on" && $supports_hbreak)} \
 		"$test (no error)"
 	}