From patchwork Wed Oct 2 16:15:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34792 Received: (qmail 62695 invoked by alias); 2 Oct 2019 16:15:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 62600 invoked by uid 89); 2 Oct 2019 16:15:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1621 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Oct 2019 16:15:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BFD5D117C1B; Wed, 2 Oct 2019 12:15:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8CCkwR448ItM; Wed, 2 Oct 2019 12:15:06 -0400 (EDT) Received: from murgatroyd (75-166-72-156.hlrn.qwest.net [75.166.72.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 464A41178D2; Wed, 2 Oct 2019 12:15:06 -0400 (EDT) From: Tom Tromey To: Simon Marchi Cc: GDB Administrator , gdb-patches@sourceware.org Subject: Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019 References: <20191002015622.GA57488@sourceware.org> Date: Wed, 02 Oct 2019 10:15:05 -0600 In-Reply-To: (Simon Marchi's message of "Tue, 1 Oct 2019 22:50:07 -0400") Message-ID: <875zl7yvhy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 >>>>> "Simon" == Simon Marchi writes: >>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address >> gdb/valprint.c:2077: fprintf_filtered (stream, " %p[%p]", >> Simon> Hmm, I think we can get rid of that %p rule (or improve it), Simon> otherwise we will have a lot of noise. How's this? Tom commit ce98317860cdcdb19426ddee3509ccceea79c7b1 Author: Tom Tromey Date: Wed Oct 2 10:13:33 2019 -0600 Let ARI allow gdb %p printf extensions As pointed out by Simon, this changes ARI to allow the gdb-specific %p printf extensions. gdb/ChangeLog 2019-10-02 Tom Tromey * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cb450e28730..e79612696e6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-10-02 Tom Tromey + + * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions. + 2019-10-02 Tom Tromey * NEWS: Add $_ada_exception entry. diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh index 4bd434c8fec..1556756a12c 100755 --- a/gdb/contrib/ari/gdb_ari.sh +++ b/gdb/contrib/ari/gdb_ari.sh @@ -353,7 +353,7 @@ Do not use printf(\"%p\"), instead use printf(\"%s\",paddr()) to dump a \ target address, or host_address_to_string() for a host address" category["%p"] = ari_code } -/%p/ && !/%prec/ { +/%p[^][sF]/ && !/%prec/ { fail("%p") }