From patchwork Tue Apr 11 11:19:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 67629 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 482FF3858D39 for ; Tue, 11 Apr 2023 11:19:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 482FF3858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1681211992; bh=eFtlZrlkSif9An4eHxJ7lbf1NmipgGGnrSJZNjOf9OY=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mIOeXe76FIeG7dlcpbu2hdq2SXX2KjJ/paKruhfCoYL+79l9P49l0Grk7pPSfUZL5 NjbxSGAS5yI9ATjdeRqG5/z20bLH4+unMRuxqE+sCIENsY/XhHbf2/MK6nWxXkc7bx qvkLTOg27WkGsJTjSTDZnOK720p73j01IO5LOI4Q= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CED083858D28 for ; Tue, 11 Apr 2023 11:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CED083858D28 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-QdCMRKw5NxCcgjIJ0feRbA-1; Tue, 11 Apr 2023 07:19:22 -0400 X-MC-Unique: QdCMRKw5NxCcgjIJ0feRbA-1 Received: by mail-ej1-f70.google.com with SMTP id tg11-20020a1709078dcb00b0093460dfa569so2461589ejc.13 for ; Tue, 11 Apr 2023 04:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681211961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFtlZrlkSif9An4eHxJ7lbf1NmipgGGnrSJZNjOf9OY=; b=nanl01RJfqJAxhQWUajZkwShrO5dwYjCRRxMnEINfyA3W0Gbd0Mw1C7gyvCyj2yESE x12zVPM8tzKKdmO2ftszTX73+HJA3IsrnuQFRQJKzpNbbGc33tSDpV1E6e7zdSBP6Q1C isRuVc4cnOVjz1DwFMWJJy7oo10gnn1rfwLpWLtEbTPaSNlJzyFak9Jd3R8kACEnO0Vz HKI19HOcvsXFZBCSCDgvud8eSGwViHKARIbv6IXWfDN+HXy2Dxmyz59jPraMUD26Yv4T 0QLmtsx3nxVry5doxPXOIT7bJUk+suw3+sjuXYMGrOUy0Kv1rwgsykRQ2nCnr3cI6q19 SQOg== X-Gm-Message-State: AAQBX9c9LhAbfwIm5zXLb0jRt5u7sjRxDqHXnfKipMItXB99iVTP4nKr 07de0eNWX3TOJCBeU0EyGi+sDMFOvjSS5A+wqDPUadRytyGdi/mBREo6T6BwZ8KHzojhJ5sDNu7 /tYNp+kMM2EpMOrg+X6DfMKXcs0TWYcVmJcoKQrj5T8xIFW4O9n6d8FXNhiTpfcQPFoAXoMzF3Y CEHQ7Q4g== X-Received: by 2002:a17:906:454a:b0:94a:5602:5d6a with SMTP id s10-20020a170906454a00b0094a56025d6amr2124145ejq.9.1681211960978; Tue, 11 Apr 2023 04:19:20 -0700 (PDT) X-Google-Smtp-Source: AKy350YAIg0jCKFnr9Pf+B9aa4n4rstCJR0tY/aeoYSasO2JT5FrNteeAu8VEQ+Y/JCrL7ewwIDezg== X-Received: by 2002:a17:906:454a:b0:94a:5602:5d6a with SMTP id s10-20020a170906454a00b0094a56025d6amr2124124ejq.9.1681211960604; Tue, 11 Apr 2023 04:19:20 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id s14-20020a50d48e000000b004faa1636758sm5708373edi.68.2023.04.11.04.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 04:19:20 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/2] gdb/testsuite: avoid {"} pattern in lib/mi-support.exp Date: Tue, 11 Apr 2023 12:19:15 +0100 Message-Id: <8698a0544ca9c9441a4dc0c459ca3944532140ba.1681211875.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Commit: commit c569a946f6925d3f210c3eaf74dcda56843350ef Date: Fri Mar 24 10:45:37 2023 +0100 [gdb/testsuite] Fix unbalanced quotes in mi_expect_stop argument Introduced the use of {"} in mi-support.exp. There is absolutely nothing wrong with this in any way. However, this is causing my editor to get the syntax highlighting of this file wrong after this point. Maybe the real answer is to use a better editor, or fix my current editor.... but I'm hoping I can instead take the lazy approach of just changing {"} to "\"", which is handled fine, and means exactly the same as far as I understand it. There should be no change in what is tested after this commit. Reviewed-By: Tom Tromey --- gdb/testsuite/lib/mi-support.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp index 1841816ffeb..52c188df49d 100644 --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -1271,7 +1271,7 @@ proc mi_expect_stop { reason func args file line extra test } { set r "" if { $reason != "" } { - if { [regexp {"} $reason] } { + if { [regexp "\"" $reason] } { set r "reason=$reason," } else { set r "reason=\"$reason\","