From patchwork Wed May 27 10:35:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 6939 Received: (qmail 94520 invoked by alias); 27 May 2015 10:35:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94507 invoked by uid 89); 27 May 2015 10:35:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f173.google.com Received: from mail-pd0-f173.google.com (HELO mail-pd0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 May 2015 10:35:09 +0000 Received: by pdbki1 with SMTP id ki1so9235519pdb.1; Wed, 27 May 2015 03:35:07 -0700 (PDT) X-Received: by 10.70.40.164 with SMTP id y4mr57728994pdk.25.1432722907440; Wed, 27 May 2015 03:35:07 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id zb14sm5754766pab.20.2015.05.27.03.35.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 03:35:06 -0700 (PDT) From: Yao Qi To: GDB Administrator Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Wed May 27 01:54:00 UTC 2015 References: <20150527015400.GA43207@sourceware.org> Date: Wed, 27 May 2015 11:35:03 +0100 In-Reply-To: <20150527015400.GA43207@sourceware.org> (GDB Administrator's message of "Wed, 27 May 2015 01:54:00 +0000") Message-ID: <864mmyqpew.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes GDB Administrator writes: > 0a1,4 >> gdb/aarch64-tdep.c:3009: code: OP eol: Do not use &&, or || at the >> end of a line > gdb/aarch64-tdep.c:3009: if (!bits (aarch64_insn_r->aarch64_insn, 2, > 4) && >> gdb/aarch64-tdep.c:3010: code: OP eol: Do not use &&, or || at the >> end of a line > gdb/aarch64-tdep.c:3010: !bits (aarch64_insn_r->aarch64_insn, 21, 23) > && >> gdb/aarch64-tdep.c:3413: code: OP eol: Do not use &&, or || at the >> end of a line > gdb/aarch64-tdep.c:3413: else if ((insn_bits24_27 & 0x0b) == 0x08 && > insn_bits28_29 == 0x03 && >> gdb/aarch64-tdep.c:3460: code: OP eol: Do not use &&, or || at the >> end of a line > gdb/aarch64-tdep.c:3460: else if ((insn_bits24_27 & 0x0b) == 0x08 && > insn_bits28_29 == 0x03 && Here is the patch to fix these warnings... I'll push it in. diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index d07b26c..9650a7a 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3006,9 +3006,9 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r) /* Exception generation instructions. */ if (insn_bits24_27 == 0x04) { - if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) && - !bits (aarch64_insn_r->aarch64_insn, 21, 23) && - bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01) + if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) + && !bits (aarch64_insn_r->aarch64_insn, 21, 23) + && bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01) { ULONGEST svc_number; @@ -3410,8 +3410,8 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r) } } /* Load/store register (register offset) instructions. */ - else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 && - insn_bits10_11 == 0x02 && insn_bit21) + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 + && insn_bits10_11 == 0x02 && insn_bit21) { if (record_debug) { @@ -3457,8 +3457,8 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r) } } /* Load/store register (immediate and unprivileged) instructions. */ - else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 && - !insn_bit21) + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 + && !insn_bit21) { if (record_debug) {