"gdb --config" to show the xxHash option

Message ID	83zhfmyvku.fsf@gnu.org
State	New, archived
Headers	Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk Sender: gdb-patches-owner@sourceware.org Date: Sat, 21 Dec 2019 09:41:21 +0200 Message-Id: <83zhfmyvku.fsf@gnu.org> From: Eli Zaretskii <eliz@gnu.org> To: Tom Tromey <tom@tromey.com> CC: gdb-patches@sourceware.org In-reply-to: <87zhfob2rl.fsf@tromey.com> (message from Tom Tromey on Thu, 19 Dec 2019 11:15:26 -0700) Subject: Re: "gdb --config" to show the xxHash option References: <83pngl36rn.fsf@gnu.org> <87zhfob2rl.fsf@tromey.com>

Message ID

83zhfmyvku.fsf@gnu.org

State

New, archived

Headers

Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
Sender: gdb-patches-owner@sourceware.org
Date: Sat, 21 Dec 2019 09:41:21 +0200
Message-Id: <83zhfmyvku.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
CC: gdb-patches@sourceware.org
In-reply-to: <87zhfob2rl.fsf@tromey.com> (message from Tom Tromey on Thu,
	19	Dec 2019 11:15:26 -0700)
Subject: Re: "gdb --config" to show the xxHash option
References: <83pngl36rn.fsf@gnu.org> <87zhfob2rl.fsf@tromey.com>

Commit Message

Eli Zaretskii Dec. 21, 2019, 7:41 a.m. UTC

  > From: Tom Tromey <tom@tromey.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 19 Dec 2019 11:15:26 -0700
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> I've noticed that HAVE_LIBXXHASH is not reflected in the --config
> Eli> output.  Okay to commit the below? including to the GDB 9 branch?
> 
> This is ok.  Thanks.
> I think it's fine for the gdb 9 branch as well.

Thanks, pushed the changes below (which also fix the indentation in
the vicinity):

commit 15b07e4f5672cf02487a26305ac3b2ddd0aec68e
Author:     Eli Zaretskii <eliz@gnu.org>
AuthorDate: Sat Dec 21 09:23:44 2019 +0200
Commit:     Eli Zaretskii <eliz@gnu.org>
CommitDate: Sat Dec 21 09:23:44 2019 +0200

    Include xxHash support status in GDB configuration report
    
    gdb/ChangeLog
    2019-12-21  Eli Zaretskii  <eliz@gnu.org>
    
            * top.c (print_gdb_configuration): Print "--with-xxhash" or
            "--without-xxhash" according to HAVE_LIBXXHASH.

diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b58e4f5..0ba175a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-12-21  Eli Zaretskii  <eliz@gnu.org>
+
+	* top.c (print_gdb_configuration): Print "--with-xxhash" or
+	"--without-xxhash" according to HAVE_LIBXXHASH.
+
 2019-12-20  Weimin Pan  <weimin.pan@oracle.com>
 	* ctfread.c (ctf_file_key): Change type to objfile_key.
 	(struct ctf_context): Remove typedef.
diff --git a/gdb/top.c b/gdb/top.c
index 6f366ff..15bbe30 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1478,35 +1478,43 @@  This GDB was configured as follows:\n\
 #endif
 
 #if HAVE_LIBBABELTRACE
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --with-babeltrace\n\
 "));
 #else
-    fprintf_filtered (stream, _("\
-             --without-babeltrace\n\
+  fprintf_filtered (stream, _("\
+             --without-babeltrace\n		\
 "));
 #endif
 
 #if HAVE_LIBIPT
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --with-intel-pt\n\
 "));
 #else
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --without-intel-pt\n\
 "));
 #endif
 
 #if HAVE_LIBMPFR
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --with-mpfr\n\
 "));
 #else
-    fprintf_filtered (stream, _("\
+  fprintf_filtered (stream, _("\
              --without-mpfr\n\
 "));
 #endif
-
+#if HAVE_LIBXXHASH
+  fprintf_filtered (stream, _("\
+             --with-xxhash\n\
+"));
+#else
+  fprintf_filtered (stream, _("\
+             --without-xxhash\n\
+"));
+#endif
 #ifdef WITH_PYTHON_PATH
   fprintf_filtered (stream, _("\
              --with-python=%s%s\n\