diff mbox

[RFAv3,2/6] Improve process exit status macros on MinGW

Message ID 83r20ceez3.fsf@gnu.org
State New
Headers show

Commit Message

Eli Zaretskii Jan. 6, 2020, 4:17 p.m. UTC 
> Cc: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Mon, 6 Jan 2020 11:57:42 +0000
> 
> >> I think this should have a NEWS entry, BTW.
> > 
> > It's a kind of a bugfix, so I didn't think it was NEWS-worthy.
> 
> My thinking is that users that might have been scripting
> around $_exitcode may need to adjust to look at $_exitsignal.

Fair enough.  How about the below?

Comments

Pedro Alves Jan. 6, 2020, 6:51 p.m. UTC | #1 
On 1/6/20 4:17 PM, Eli Zaretskii wrote:
>> Cc: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
>> From: Pedro Alves <palves@redhat.com>
>> Date: Mon, 6 Jan 2020 11:57:42 +0000
>>
>>>> I think this should have a NEWS entry, BTW.
>>>
>>> It's a kind of a bugfix, so I didn't think it was NEWS-worthy.
>>
>> My thinking is that users that might have been scripting
>> around $_exitcode may need to adjust to look at $_exitsignal.
> 
> Fair enough.  How about the below?

LGTM.

Thanks,
Pedro Alves
Eli Zaretskii Jan. 6, 2020, 7:26 p.m. UTC | #2 
> Cc: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Mon, 6 Jan 2020 18:51:20 +0000
> 
> > Fair enough.  How about the below?
> 
> LGTM.

Thanks, pushed.
diff mbox

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index f51a989..11e4221 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,9 @@ 
 
 *** Changes since GDB 9
 
+* Debugging MS-Windows processes now sets $_exitsignal when the
+  inferior is terminated by a signal, instead of setting $_exitcode.
+
 * Multithreaded symbol loading has now been enabled by default on systems
   that support it (see entry for GDB 9, below), providing faster
   performance for programs with many symbols.