diff mbox

MinGW compilation warnings in libiberty's waitpid.c

Message ID 83poezml4x.fsf@gnu.org
State New
Headers show

Commit Message

Eli Zaretskii May 23, 2017, 7:24 p.m. UTC
> From: DJ Delorie <dj@redhat.com>
> Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
> Date: Mon, 22 May 2017 15:38:40 -0400
> Since (or "if") nobody will (should) use waitpid() on mingw anyway, and
> since libiberty really wants to include waitpid.o, how difficult would
> it be to use some #ifdefs to have waitpid() just return an error on
> mingw?  That at least gets past the mingw build problem.

Instead of making waitpid an always-failing stub on MinGW, wouldn't it
be better to make it work on MinGW?  Like this:
diff mbox


--- libiberty/waitpid.c~0	2016-08-01 18:50:21.000000000 +0300
+++ libiberty/waitpid.c	2017-05-23 21:19:34.302415000 +0300
@@ -23,6 +23,11 @@  does the return value.  The third argume
 #include <sys/wait.h>
+#ifdef __MINGW32__
+#include <process.h>
+#define wait(s)  _cwait(s,pid,_WAIT_CHILD)
 waitpid (pid_t pid, int *stat_loc, int options ATTRIBUTE_UNUSED)