Message ID | 83bmpo128p.fsf@gnu.org |
---|---|
State | New, archived |
Headers |
Received: (qmail 125838 invoked by alias); 16 Jun 2017 13:39:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 125814 invoked by uid 89); 16 Jun 2017 13:39:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_BRBL_LASTEXT, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=our X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jun 2017 13:39:12 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@gnu.org>) id 1dLrSx-0001fq-UH for gdb-patches@sourceware.org; Fri, 16 Jun 2017 09:39:15 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>) id 1dLrSx-0001fk-Qh for gdb-patches@sourceware.org; Fri, 16 Jun 2017 09:39:11 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4772 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@gnu.org>) id 1dLrSx-00043z-0L for gdb-patches@sourceware.org; Fri, 16 Jun 2017 09:39:11 -0400 Date: Fri, 16 Jun 2017 16:38:46 +0300 Message-Id: <83bmpo128p.fsf@gnu.org> From: Eli Zaretskii <eliz@gnu.org> To: gdb-patches@sourceware.org Subject: Automatically set the comment style to what we use Reply-to: Eli Zaretskii <eliz@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes |
Commit Message
Eli Zaretskii
June 16, 2017, 1:38 p.m. UTC
The development version of Emacs has a new feature, whereby one can toggle the comment style and get the C style in C++ sources, the style we use. (I got annoyed by having to manually type the comment starting and ending sequences, so I asked the CC mode maintainer to add this, and he just did.) So what do people think about the following addition to our .dir-locals.el? I verified that it's a no-op in versions of Emacs which don't support this functionality.
Comments
On Fri, Jun 16, 2017 at 2:38 PM, Eli Zaretskii <eliz@gnu.org> wrote: > The development version of Emacs has a new feature, whereby one can > toggle the comment style and get the C style in C++ sources, the style > we use. (I got annoyed by having to manually type the comment > starting and ending sequences, so I asked the CC mode maintainer to > add this, and he just did.) > Hi Eli, How does this change affect the people writing code using new emacs? I still manually type comment starting and ending sequences every day.
> From: Yao Qi <qiyaoltc@gmail.com> > Date: Thu, 22 Jun 2017 10:45:45 +0100 > Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> > > On Fri, Jun 16, 2017 at 2:38 PM, Eli Zaretskii <eliz@gnu.org> wrote: > > The development version of Emacs has a new feature, whereby one can > > toggle the comment style and get the C style in C++ sources, the style > > we use. (I got annoyed by having to manually type the comment > > starting and ending sequences, so I asked the CC mode maintainer to > > add this, and he just did.) > > How does this change affect the people writing code > using new emacs? I still manually type comment > starting and ending sequences every day. Emacs has a command to open a comment: 'M-;' (without the quotes). When you type this in C mode, Emacs inserts "/* */" and puts the cursor inside the comment, so you could type the text. In C++ mode, 'M-;' inserts "// " and puts the cursor after it. With the above new feature, you can now get "/* */" in C++ mode if you toggle the style. Does that answer your question? (I've stopped typing the comment starting and ending sequences long ago, I always use 'M-;'.)
And btw, what about the patch I suggested? Is it OK to push it?
On Thu, Jun 22, 2017 at 4:04 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> And btw, what about the patch I suggested? Is it OK to push it?
Yes, please.
> From: Yao Qi <qiyaoltc@gmail.com> > Date: Thu, 22 Jun 2017 16:14:04 +0100 > Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> > > On Thu, Jun 22, 2017 at 4:04 PM, Eli Zaretskii <eliz@gnu.org> wrote: > > And btw, what about the patch I suggested? Is it OK to push it? > > Yes, please. Thanks, pushed to master.
diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el index a2aa196..48325b1 100644 --- a/gdb/.dir-locals.el +++ b/gdb/.dir-locals.el @@ -26,4 +26,6 @@ ( (c-basic-offset . 2) (eval . (c-set-offset 'innamespace 0)) )) + (c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style) + (c-toggle-comment-style 1))))) )