From patchwork Thu Jan 12 15:42:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 18884 Received: (qmail 57592 invoked by alias); 12 Jan 2017 15:42:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 57573 invoked by uid 89); 12 Jan 2017 15:42:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, KAM_LOTSOFHASH, SPF_PASS autolearn=no version=3.3.2 spammy=sk:cb2a4ac, sk:e386d4d, e7000pc_open, go32_noop X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jan 2017 15:42:29 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by (Symantec Mail Security) with SMTP id 0B.F1.11795.2E3A7785; Thu, 12 Jan 2017 16:42:26 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Jan 2017 16:42:25 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.50.115] (192.75.88.130) by DB4PR07MB393.eurprd07.prod.outlook.com (10.141.236.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.6; Thu, 12 Jan 2017 15:42:23 +0000 Subject: Re: [PATCH] Remove dead serial_interface_lookup calls To: Yao Qi References: <20170111155847.13244-1-simon.marchi@ericsson.com> <20170112083228.GM9518@E107787-LIN> CC: From: Simon Marchi Message-ID: <7cc9646e-c100-3f4c-1042-682ff3b5e90d@ericsson.com> Date: Thu, 12 Jan 2017 10:42:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170112083228.GM9518@E107787-LIN> X-ClientProxiedBy: BN6PR03CA0026.namprd03.prod.outlook.com (10.175.124.12) To DB4PR07MB393.eurprd07.prod.outlook.com (10.141.236.16) X-MS-Office365-Filtering-Correlation-Id: de7db813-83ec-4ba7-28d0-08d43b019ab7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DB4PR07MB393; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB393; 3:lGV+dB0mhC8jiiO8duRzJetOc6BiGZWfJXrQJbJ+SkbBtApyu1Xt78xpr1AfXiBflLPE8nCuK6mIkfm/eA3X4Bwe1fNKwpiDLaSaLz/fzvmtwbwRZwCWosAPmVtcYID5b2Q4GixqzXbaeA+hfnPplP+Yis0arOpEya1zECSCeSab80a7lX7jTqt2lXLoyIaXh+YOaH4rcQSzE69Nl9VLxVBA0/7bjjs7ZnhpAXw5IgORseA8X+kr4qn0OxoGHZ7FYEBqYPvnKoaYIlrc8o3YCA==; 25:RvwjJZGMxmCMXyqKzh8tvpn2FlcXUOpPLLJ0APtAKDzF5CPBvt/gsx+mDqJMUfDyLrIPBu0NYLLUbP3uld6NPp/ht25V8unaSEuVQ3SpFwAbIjjBFWIG75PiF8HJz8gVckWrbvzDIKiK7RXDGCgV4QGed1Y+Kz5TMAF9ofdogi1ERbtYv9lwDRGkU0XONtt7F4qi6sxpWbDLu2wTvxEYMFES5v27Aarten/FcJ8uUgOhfOWZhJCZltKoCGYn+uLDYjIkpDScOj2lyedLnc88cSG/FmYOkxPbu+/4MF4BKYjCxzMwMAqpm/tOB2ByILYQBAvoxYIo5vYzWEnB7aAPf1zYFBdZ4lwereDZAv5bzHrQyQbSTehnoCtgoOYK1lXCnCCXJ5MZgFsYsuN5wKE9T6DR2ScbHfrdPtl9oytbfBgwOJvA6NWmTE8iwOX3nCvsuwYzlbsWd8zlzAaTkOBr2w== X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB393; 31:rOXEw9Oous5OlI4fF6y43Y54Y2IiwbPxAS2QXpZSeNbYcm5P2yAIp6p/ezlwL9/bsQUzdbRjJbtUSmq22PnvCs+zEmc8bztAD1a0CERD84wyx+J2kbNpBHONLaI1rLT8LEWq1v0Dvza2oi1ki2Mw9HmGJvGVD/o5QF+ekThSqYBZASKa8Q3Aie55Uux/Y/doOKHhtGP5mXEp1qW4Yq39GHeEEFfgnkmI9KkECiXylaWNV1M2nFClDKmwtulEnHCncM/8ro/RwsT1Xx12yhe2fg==; 20:CQbsEfH+5IaYWpfuzNYvs9GLPK0oZTCLNGaodZSa7gLA5ObsiwQhvUTNSxm8an2brfriqAMHHmKqvw+2Ezr1keeADyDVMUuGAfSweU+LynHFhcl7yRM3FasiwA2HL4xaSRiT5f+n2J89na4bbhyqVe+iceUWkgXolOtAgyElcHBNI9YdmbLFmxe98b7GsM1nM7QS45I7ta7ozsXhxrbVOHtxeCvS21b5MAeNUKLWQdsmCltZI65Rm5li4DROU/XtQBMUxzr+Kdrp/pn3HZHrBuudtOJC+bcHSbaBrCkzpnH2xzITPaO0P1rpEF/2cc7UE/ZPn/t6oDFsJgbY5lH75JOBk0q44jE0KDu0riftYfKeITSyuzaB7nM0k0KiyrAd6pfLETFLafSQTQqVGJG5UDCNn8WYH7bQZlt8IxZrFnx+xSxIZV+nQxGO4abMpmvuQL/xqIygH+HbeP3YQoBG69MQTb+zxth7mpBPtpQ5o3tuVqR6qbqax6WBgF+oSmm3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(20161123558021)(6072148); SRVR:DB4PR07MB393; BCL:0; PCL:0; RULEID:; SRVR:DB4PR07MB393; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB393; 4:Do14XSlML+Mya2WV6XBSAwdgFGSC9TGyqpnpojNYV6aNS3/zpZSlZy15goviilIZtSQr3PJA2k3nHZ18tSAPSNQAKLREqRIAZsxHFcpVf/e9JUXRIlihh4JZ5eJfObcG98JFGwTtMKXLMjTsw5tAiSRZDVCsu57Fw+swrDwEKnq2X9ENNNHjcCd1wCxQQagMv6zNzs6uibuJadQPz05WZD/DhZRJ5ar/q0/VqJfCfdAlfHg6SNcJ4NbrdpGuqhMX17fSvQLV9NgW4k1m/7iT0R0miEizCck62y9ph2Wso9AGSChPp2I+hlj81HVgkT/sWl21EiiY8BCZMWXZKgg6wYG/U6UVHlHmJKUnUWg1p94y6Ilu7YmSpz6o23Hxor5A9Ql0p/49q4i2DCZu0Z2UvKLQvCNDSyrQycr2RNVXE4xxdNQDMxWAWEx55S0R6VJdohpPS93Me2NJrEFcsDIliPZtXKcRvSvlSHAxsNA/Dm+KVqrZwiuyPnz3ccCfp0Fk/LIKVBsosi5Lrf2QZc5M8crbGqP7t/2dNT7xP7CN7HSuERPxp5NMc30BCyJJQuuEvEAWWE4CuYpISUCYRj+YOWYQviPD472r2EH0kDayn3DU8SxRplf67rDZV0zLn78Z4lwCmCz0KFo2CzcLFNf7Fg== X-Forefront-PRVS: 018577E36E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(54534003)(24454002)(189002)(377454003)(377424004)(199003)(66066001)(47776003)(106356001)(42186005)(65956001)(65806001)(105586002)(65826007)(5660300001)(305945005)(110136003)(7736002)(50986999)(101416001)(1411001)(76176999)(50466002)(54356999)(83506001)(64126003)(2950100002)(6916009)(189998001)(23676002)(6486002)(90366009)(33646002)(86362001)(4001350100001)(8676002)(81156014)(97736004)(81166006)(6666003)(36756003)(575784001)(4326007)(3846002)(230700001)(2906002)(6116002)(25786008)(229853002)(31686004)(38730400001)(31696002)(39060400001)(92566002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR07MB393; H:[142.133.50.115]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzOTM7MjM6YnYrMjhEWGc0cVZBK3FuajJjZWU3Zy9uY1Q4?= =?utf-8?B?WjUzNXA1K29hT0ZvVUJTRlMza2pSVnphSHFOSGFJWGNtZ3lHQzAwODEvTmxG?= =?utf-8?B?Q2FTMkJoK1ZCb0tRT0c2Uk1sVmFmQlZac09DR3pvS1Q2N2cvM05ocWdYdmly?= =?utf-8?B?cWNrK3hZZGxvM2pBVDUxZk9jZnhVMUlGRUVzOTlKOXZpWXdOTnBEeUpGOUNN?= =?utf-8?B?bkJwMjRBWW00UDFCc0pQemNzZXE5enk5R2VvOFlCSFdCMG5Vd0pPYzFwa0xV?= =?utf-8?B?bC9VejRCUWxTeFNZL1o4RU5tcDJ1L3pOK2UrWFEwUEJoSFZOUVpHb1gvaE02?= =?utf-8?B?QjEzMXd2MExBd255M2dFR1NGMWJ3clF4ZTVoRm8vVlIzZGZ1ZkFucUE5TTFH?= =?utf-8?B?ZWdqZytWYk80ZVpZSTlUNks2UC9jeE8xc3NEc2J4QkVLTUwxeXFsb0hKRy9m?= =?utf-8?B?L1lxcE5hazN6b3NZQit3NC82UHhMYlYwQjZ5WTFzakRlT1VXWXlJTk1xMWJU?= =?utf-8?B?ZHNaczdVZytBMlE4WEMvRzhWeEkrZWpIcGdpa0ZlQnRoZmVnblRCN0xxVy80?= =?utf-8?B?SEVSL3kzb24vQTliMzA5SElHUldJQWVmSzFnZ2RFWWhSVWRXTmg3NzY2Z1Rq?= =?utf-8?B?TU1rODllamNYSW1QVitqRFQweXVlUnZKMHVQSm9UbWwrTExlS3dJejcybmxq?= =?utf-8?B?NndvbWlMdks3QXFiNW5rY1RIS092d3VzRW1yTnNjTnNON09qY05IVU5NUjAw?= =?utf-8?B?L3lOM0pKM0txSmFCR2IrNDlZbThRT3pWZkFSUzFiaUNKV0tKYk9kaUVWc0g1?= =?utf-8?B?aGY0bFMyN0JLSHdYMmJYZnBFdkNIamUrcXlJd25GQy91Ykd5TmhNK0lkcUMy?= =?utf-8?B?bERQazc2SWFHMnhVRDJQS0tDaWVEOVg2Z2U4aEhoUkZVMWxWRGNudVlnZCtx?= =?utf-8?B?cW42L1dpMSswYUpObCtPQTRYcXRtQWtNaEFLT1NNZFJWMlF4ZlNjeHFnTlBo?= =?utf-8?B?RFNESmc1QjV2MjlXbllpTjE2b25kQ0Iwc3pidjJMMzNsT3VDVCtDdDRPaHU3?= =?utf-8?B?Znh0TGpCa0RpNVBlTWh6YmUrYkg3QjRPS29zRExLczhsYzkxSnNHNk8zTnVa?= =?utf-8?B?TFB0YUQ2Wm9peHNFcU1wbEdRZHNMTENhckp0YWR5SVFnZXc2SzdlV2llb3lh?= =?utf-8?B?T2d4Vy91YWRJVlRqMHBEcElnSWlYWDZXRHBYSjRXOHVjcW5JRGlzaU0vbGxT?= =?utf-8?B?T2JkRC9abE5nWm82ZDRJNklER0E2WnhlRTVlV1F5SjVHRHBoTkRQRkVXMHkr?= =?utf-8?B?Njk0Y3RweEkvNVhOaXJwZnFmSThUOWt5L1N1bjRVbkxxUjVwSjEzZmFjQ2Ir?= =?utf-8?B?a3BxMWlIVDFnRlpzdi9ES1AwZW15aDc5L2NMRUltL0FGTjY3cjh2d3MySWUv?= =?utf-8?B?RjRzdUFIN1lpUkVwTE0weTlLVndBMldxSFdjMzR2NXI2MUc0NFVmMDBiY1k3?= =?utf-8?B?ZUw3czFEam5yREw2ZTVCMkhFMEFuSk9OUnU0VjdJc0xCbUdoakRtdDZBaHMr?= =?utf-8?B?NGgrT1dPQktCb0Z4UTBjTXF5K2RPTkR2Vlg1Z04yTGs4RzFqemVNL1FBNER6?= =?utf-8?B?UWdlUHl4d00wUWVFYnRlc24zSTdRdkM2UndVQXlwdGVDekZCb2RkakZjNVFH?= =?utf-8?B?WVcxMTI0NXRKZ0JOZWNIL1JoMmRqQ2F6NEpQUEk2TGNOdENMenh5REN1cmhB?= =?utf-8?B?aWcvK2pUaTFYanR4cWRTbXBLMExyRUNUUXFvUzBjcVBUcWJqOUl5UzY0eHY2?= =?utf-8?B?MXlURzdoakQwQkQ3dkRRaU5IMFppUHRwNHo3SVhmcTRmOXNHdW5WT3pwOTZQ?= =?utf-8?B?WWFYM2ZaQitFU2s2UDNINmIzWjRmSHNMUXVPQnJJVlJsMVNoc3ozTnVQZmt4?= =?utf-8?Q?CRMTV/WAwhsz1g5Ioks2O3iqHUEsk=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB393; 6:xKbhO585ZbN9XTOfU36JOW3h90bPx2Pv5lN1ePEbhwNmN6Evb3qL1jRsShkIeIY+L9Z8RMxIwh9w5mEdJdPGhSh0Hwbr/9wmmXEtxczlS4Mjwwfa52DNUsk0+/POwxpazlzKwjdXdNrMe+rzie1YssCjaCrqEfSc72ek30v+LB8UWMngNT8lc71O4t6g+FutjjmDxvKDMV6FPD3VIBFpzm9j8xUaLJR79kPZ9UiPn2AMnScQ5yzPClF9/JSxZw873zU12FJPkXv9oTic8exzwicYDSYV6AGY62kLCxldZhuQ+rs5s5/8edMkhCjNKw8ceVBpiAlr+ls6dqkw3RZ/DI6dp1hHYbrWGAZIc4O1Fibt/gsyuHushswQlRaOTfs+XdZdZ/BYBHvsGLvDWuCD/nieEMnrW6O0qMdta7YOo4w=; 5:bz1sZzUKF1zGZEMKAl6dbDcVGBXT23GglDvr5HjikBL6hOj2WXGXO074RT5X+MljNskwh1oKaFBO3rmfpDtHmDxQ0TX/OpQTJ7vNq1sYVPEgpwT+0jXLumfD6ZKu/py0mQ1RSfr0ezgnrvou6M0P4Q==; 24:NGu9pFGzrmY2ZhNIe+DgK9hIeBTGefIwTzIqaczuVEF3LBHOzau55ZY6ojOJQzEI4f1ZvvQaIPttf5lRZ5XbSqFQM3IvW94IgZKbuCOXS5E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB393; 7:zzQCcEQUYN8Yx9/wWZNgyy3iRCxZFm7PxPhExRh+GSRMdgL/xL7uQhgVIKZtFj/Q7aVNn1cffIYnfki+64e5ntG0pmybm01pjJdG8YbkhwprxuOK6Ujbla+WdM23sS3Pzzgy2kdISDGERyVDAXRvsCUAcOBDN3Ea3iXpljzXqkMiq1RUP1ciDXuWgrCSlPeHTeH94S0qdpvM9QPpyRzibltcKD3xcooOBxUl78AMJZ/S5w9H/+kBd/ntP2SyDV7n5aoW97Z6pbXrnrC95N6yuzckYk4FjnfbekoQdr1/Q70cho0X44NpMYq5d+VnTlVVqduXUsVuBZXwznKVUvU+A/2Xm2w1iA+vJLHOXwaYr+J+R6yoQ4gw+wPWHVPCJHU3aXiXCFLBG5k9OFWG3M8uKLTw5/w/EZzMEZVxx5J2g7sAaZGeJUIRiji/Nkwx7imm3j6X4mLVfrlDr1YYpU65wg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 15:42:23.8095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB393 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes On 17-01-12 03:32 AM, Yao Qi wrote: > On 17-01-11 10:58:47, Simon Marchi wrote: >> By inspecting the serial_add_interface calls, I found that the serial >> interface names that we have today are: >> >> - hardwire >> - terminal >> - pipe >> - tcp >> - event >> >> The calls to serial_interface_lookup with any other names are most >> likely leftovers which can be removed since these serial interfaces >> don't exist anymore. If you go back to the commits that added the >> lines this patch removes, you'll find the serial interface that existed >> at that time. > > It would be nice to show the commits remove these serial interfaces. Right, thanks for digging those out. >> >> gdb/ChangeLog: >> >> * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. > > Patch is good to me. > >> --- >> gdb/serial.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/gdb/serial.c b/gdb/serial.c >> index ac7c1b99c1..afb70758c6 100644 >> --- a/gdb/serial.c >> +++ b/gdb/serial.c >> @@ -209,11 +209,7 @@ serial_open (const char *name) >> const struct serial_ops *ops; >> const char *open_name = name; >> >> - if (strcmp (name, "pc") == 0) >> - ops = serial_interface_lookup ("pc"); > > It was removed by cb2a4ac5dae478fcd9d6e772530c3aba0576fc7a > > -static struct serial_ops e7000pc_ops = > -{ > - "pc", > - 0, > - e7000pc_open, > - e7000pc_close, > - e7000pc_readchar, > - e7000pc_write, > - e7000pc_noop, /* flush output */ > >> - else if (startswith (name, "lpt")) >> - ops = serial_interface_lookup ("parallel"); > > It was removed by e386d4d2fb55042f77d0557a0849ed2464aee7b3 > > -static struct serial_ops go32_ops = > -{ > - "parallel", > - 0, > - go32_open, > - go32_close, > - go32_readchar, > - go32_write, > - go32_noop, /* flush output */ > Thanks, I updated the commit message with references to those commits and pushed it: From 0e88921b1628d0c54b1bcba7abb2c354d39664db Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 12 Jan 2017 10:39:35 -0500 Subject: [PATCH] Remove dead serial_interface_lookup calls By inspecting the serial_add_interface calls, I found that the serial interface names that we have today are: - hardwire - terminal - pipe - tcp - event The calls to serial_interface_lookup with any other names are most likely leftovers which can be removed since these serial interfaces don't exist anymore. The commits that removed the "pc" and "parallel" interfaces are respectively: cb2a4ac5dae478fcd9d6e772530c3aba0576fc7a and e386d4d2fb55042f77d0557a0849ed2464aee7b3 gdb/ChangeLog: * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. --- gdb/ChangeLog | 4 ++++ gdb/serial.c | 6 +----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 89bbb8fbaf..153f6cd7df 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-01-12 Simon Marchi + + * serial.c (serial_open): Forget about "pc" and "lpt" serial interface. + 2017-01-11 Simon Marchi * cli/cli-decode.c (lookup_cmd_1): Fix typo in comment. diff --git a/gdb/serial.c b/gdb/serial.c index ac7c1b99c1..afb70758c6 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -209,11 +209,7 @@ serial_open (const char *name) const struct serial_ops *ops; const char *open_name = name; - if (strcmp (name, "pc") == 0) - ops = serial_interface_lookup ("pc"); - else if (startswith (name, "lpt")) - ops = serial_interface_lookup ("parallel"); - else if (startswith (name, "|")) + if (startswith (name, "|")) { ops = serial_interface_lookup ("pipe"); /* Discard ``|'' and any space before the command itself. */