From patchwork Tue Mar 5 15:21:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 86806 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7119338582AD for ; Tue, 5 Mar 2024 15:24:10 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5493D3858281 for ; Tue, 5 Mar 2024 15:22:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5493D3858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5493D3858281 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709652132; cv=none; b=YFwDDZ71cC6533XHS2l4omTndQANpjjfeUI7IU9RwgpK/9NcHRgQek/X+nMI1QB+LRQ5hXMvWtmLYpahHxtQ5wVwMNaupqdDsl9Oa4rla+2OII66eNzeSBrxyt/d02oo9OEcpTOG+Vqh8E60acSSXBJDlDZ9/HA4HWaHhuB5vdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709652132; c=relaxed/simple; bh=kCtIQjYOvaN9Ldf0PrTb3F8N/TZPT0vgCnsnW7DHdWQ=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=B5IEZEZouMNPdQMlARHChWf5ZuuTKnlICTUuTl0PI58AcWFOfQ8Ojil4N0BTgFXJXeAPPxdU5QvTYMO8aheMRJGEME4JwN+UJtitQ6+Al9Pf/9DR08xFQu/4jXGQREP5gEt/2RRlMbDM0ZG22wcShUKJaOgFrbg8ie7tCzkyuQA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgKtFOpjUVEPGsjxTEdDvisJj2JfoHfouWzF2LNmNQI=; b=h8ULruZnIvt9e7A7Vgm+dT0fzg8fC+l46s7i5V86HMuHvRfpIfH2eU2BulYNwIx9xTcePN 5F7CCt4cS8PpX8B16JduZu5qR9jgGj+h5T5bQnvr0GJNRFl9Sr8BleeO8snqHsXAHEKFJr NysOQyvkH7+sozchSwDumjpmkjh52xI= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-tUHH4_XHNIeIpjCFaFAyMw-1; Tue, 05 Mar 2024 10:22:07 -0500 X-MC-Unique: tUHH4_XHNIeIpjCFaFAyMw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a450265c7b6so56437766b.0 for ; Tue, 05 Mar 2024 07:22:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709652126; x=1710256926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LgKtFOpjUVEPGsjxTEdDvisJj2JfoHfouWzF2LNmNQI=; b=DlJrgZhNEJ7NCnWA68S5fxoAtQ9WAG2NxVpimMqofI8Yb4kUgRgyH2BKQQF60VH+zy cIT/LU+4oJV1FZqtkX6qN0DGMeR+UPi5XEcvg4mFKB7/JF12xW/8R3pX3uanoBacy9EH tiBOgvZfF0lmA0Sjw6HMNefVVFjUBl0uASpMvfMLG6p4kuu03T40tGUyYHWTIfXIHSw1 dou6lhN6a1rbWt/g2G6wTfF6OmEldfgFbhMgLJ73c1t5Kg5Ahc1xPYjS2gm9ywjk888t WeoK+TAOrOZB8IZqoNrIMOgkz9YNaA62mxxDjWonA+zbeXJcIoiTv0a1CmBgv9pQyeGg bDDQ== X-Gm-Message-State: AOJu0Yygx2Ty45TIgMmQR45nJjSimsqwkK5Uaf8a4lX75sl/NQ2w/5Hs NKxct81/nolubOcH66Jx4dxuWYo0XQ4VCC225NoKPMTAq5H4acGS695T0G5F815Ht+Zv9wxYsOx 4aE7x455gryckUFyYIU/vAr8ZF0XYLiBB8SP6FSZDVArZFXS76lQssfOSNVaA8eUwNuKFg/al7W Ol2ZR/vez4uIs7fCg+lNbeQC70ydY3lTeGOjmOV8XlJ/s= X-Received: by 2002:a17:906:f91a:b0:a44:752:ad4e with SMTP id lc26-20020a170906f91a00b00a440752ad4emr9143360ejb.75.1709652126015; Tue, 05 Mar 2024 07:22:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IETeNSY6d7YpmzjtWMpqjnUQIpKZfQvpJX68T1B2poRZWlT5Kwd9UWuxB9uAdv4Hy4Jr+pIMg== X-Received: by 2002:a17:906:f91a:b0:a44:752:ad4e with SMTP id lc26-20020a170906f91a00b00a440752ad4emr9143349ejb.75.1709652125724; Tue, 05 Mar 2024 07:22:05 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id bj9-20020a170906b04900b00a4547925e3asm2468456ejb.141.2024.03.05.07.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:22:05 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv9 10/14] gdb: add another overload of startswith Date: Tue, 5 Mar 2024 15:21:41 +0000 Message-Id: <7ba7f1b02b8cea22c1efaa559b893746423b0fa1.1709651994.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org We already have one overload of the startswith function that takes a std::string_view for both arguments. A later patch in this series is going to be improved by having an overload that takes one argument as a std::string_view and the other argument as a plain 'char *'. This commit adds the new overload, but doesn't make use of it (yet). There should be no user visible changes after this commit. --- gdbsupport/common-utils.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h index 23cd40c0207..2fb22916409 100644 --- a/gdbsupport/common-utils.h +++ b/gdbsupport/common-utils.h @@ -100,6 +100,16 @@ startswith (std::string_view string, std::string_view pattern) && strncmp (string.data (), pattern.data (), pattern.length ()) == 0); } +/* Version of startswith that takes a string_view for only one of its + arguments. Return true if STR starts with PREFIX, otherwise return + false. */ + +static inline bool +startswith (const char *str, const std::string_view &prefix) +{ + return strncmp (str, prefix.data (), prefix.length ()) == 0; +} + /* Return true if the strings are equal. */ static inline bool