From patchwork Fri Apr 28 23:35:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 68528 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB72E3858C20 for ; Fri, 28 Apr 2023 23:41:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB72E3858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682725286; bh=bcX6ALbwaQNi4qR/7VwyEksnM3dcCQ/ZtwvwUZqNDFI=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dGNybsBFnQ8xz84NE1DTPpORC6XIxinw+wbuyeJMa3Jg6lKdU988LEaZXO3El8YN0 4sMnlT7Pln81BeMX3qWZi0YDMsij9OYnheAVqiypZ+eHFxZQWfTOSl1yjKAkmd/P8b HOHs8N81ZbimuEHWMMiR8Sa2JbltPqzda16N/Eg8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5F45B385770F for ; Fri, 28 Apr 2023 23:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F45B385770F Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-K5uLSHYkOQmeAXlnnwVbxA-1; Fri, 28 Apr 2023 19:36:01 -0400 X-MC-Unique: K5uLSHYkOQmeAXlnnwVbxA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f1763fac8bso1581705e9.1 for ; Fri, 28 Apr 2023 16:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682724960; x=1685316960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bcX6ALbwaQNi4qR/7VwyEksnM3dcCQ/ZtwvwUZqNDFI=; b=GNKnmPVHT0oZQxYk09TbiSSmMa87f6kHx1PXcMrpxf2y7BT2E2e29s8Tubus3YPL5r fvBRom4kmiSZoD8U6visINk0SrQvhIAWeYJ/grcN9HH9Yd74D2iJEr8uUeCNwmlEf0Og q9EEH1q1SFGgYluA5axodTIZ8Z8okhlk2pMh30ffmwESp1cbeSLUud/iWCQfTW8IAe3N JxZG6a7NCABG/cu/2g5kZ457uZj9zUjwKTBJ0M0mN14obDpgPh0MGg+BIuVTmHVaI1Ge lqa56TCxebX4FhRrSyANdqAvFhyroAG6lNVoe11MpPktyIettazV421o8YM5kDDjl32r te8w== X-Gm-Message-State: AC+VfDwszMZcgx/D/N21ZSdaeYqHPkxU34mnYotP2bf0I5QuPl9q2VGN 6mAi7pMLwBBK8WSyRJpvK/uAOoXMZynMLNtjJdQumdwx+pi3bjo5/jOklp93dFh8ax+LBbVmpw0 Y4nzSKR//pu55seQBnlnD7BSxNPx7nKWWhjznMqKSKjln9M/r0t7KrWaXP1Dnldi16mzZ8ha0vV DwCb2HwQ== X-Received: by 2002:a1c:7707:0:b0:3f1:78d0:fc3f with SMTP id t7-20020a1c7707000000b003f178d0fc3fmr5428230wmi.14.1682724960369; Fri, 28 Apr 2023 16:36:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4dosNa3CTZJL4kgD2lAlPw+BWKq3awGAke8/PScZ2bl136eAbGfsMNPJuMWAtxjHeYWdL3Dw== X-Received: by 2002:a1c:7707:0:b0:3f1:78d0:fc3f with SMTP id t7-20020a1c7707000000b003f178d0fc3fmr5428222wmi.14.1682724959922; Fri, 28 Apr 2023 16:35:59 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id n10-20020a1c720a000000b003edef091b17sm25355203wmc.37.2023.04.28.16.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 16:35:59 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 8/9] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Sat, 29 Apr 2023 00:35:44 +0100 Message-Id: <76887688077346ce9a5b4f4dc27e86c2cee0c917.1682724005.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index e6e8fcd485e..4b37a217972 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -219,9 +219,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -236,10 +233,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12006,17 +12004,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () {