From patchwork Tue Apr 4 12:45:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 67263 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 554983854831 for ; Tue, 4 Apr 2023 12:47:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 554983854831 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680612420; bh=KaDIK7h2FprOVWLObxpTu5x1CG544dDHYJHsKPfv3d0=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=nBj4zJkOrvBolACJ4S7SjHC6fqLvNWSiVUnlbuG5NToRPi6Lf4GhFwe/3sJk1eXLP xs2Vth9D3Un1yquveVmISmd2YXPn43Rw2O3KNUnCzvjdSCGhXlXjsItfmG7VG4SzUS UTK65HWzXXX8qQJaZv9dSrzuFrVKkm+PNF/0xsFA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8C2F43858C27 for ; Tue, 4 Apr 2023 12:45:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C2F43858C27 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-peDeYIwfNjytoUjUc2OELg-1; Tue, 04 Apr 2023 08:45:48 -0400 X-MC-Unique: peDeYIwfNjytoUjUc2OELg-1 Received: by mail-qt1-f200.google.com with SMTP id f36-20020a05622a1a2400b003deb2fa544bso22118687qtb.0 for ; Tue, 04 Apr 2023 05:45:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680612347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KaDIK7h2FprOVWLObxpTu5x1CG544dDHYJHsKPfv3d0=; b=AUBg9+98HMySa/V9Fqqr8oYbg1OLIcuDIXBQV/AZ6yJ9N1oMxTqpUqgCfnoMPOGI/G m6Ava4KNt9/TghkHYTzRjJVUN7fr+f714LV092N68kUzkno9iRyqr3D0bB3rLP7HRIoh +1XoDU43Q7rO4++TfcdsS4jGxgVz2ngmBPupEBi2rC7edbaO1ZTjROc2ZOCx+yHSHzW4 pKvu3ZocFn+psgmJsekEHSrFmOHKqpi37RlTlzvQx+PZLXJQmyVmNVdke08S+wvHr3uf RNtjC1zWTISFciXCBLuzAhFOiljTnueu1vn7JJYy7pgF+OcbE+ayocpXgZQYNXdzsTAG guDg== X-Gm-Message-State: AAQBX9d5gKvJcsB2ThA2mR+OKYSSv4KzjXCp4G2uhr9RqwQihgKjN3Td Wijnychw6JZIh2A+gtCjquhPhRTPFMf9NzXs//kuACNQwfFHdHY1/VCD5W5jjAVHp28dHdHMBsv n9M1o4DK3bp8tAlIwS2ztiQ68zVXtMlwqRSWSIrQguQqV3X61gn8Uj4aAeHP2finQRA/JGCasxK kmXT7BNA== X-Received: by 2002:a05:622a:1b8e:b0:3e6:6c6d:94dc with SMTP id bp14-20020a05622a1b8e00b003e66c6d94dcmr1060373qtb.26.1680612347546; Tue, 04 Apr 2023 05:45:47 -0700 (PDT) X-Google-Smtp-Source: AKy350acCGxXXymqY5Lej5+3d3LUC0dIWFlxN3e1ydyGcjsc78picHxY6pw6x7OvxZPfrviU47nXkw== X-Received: by 2002:a05:622a:1b8e:b0:3e6:6c6d:94dc with SMTP id bp14-20020a05622a1b8e00b003e66c6d94dcmr1060348qtb.26.1680612347205; Tue, 04 Apr 2023 05:45:47 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id y186-20020a3764c3000000b00741a984943fsm3573193qkb.40.2023.04.04.05.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 05:45:47 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 5/5] gdb: make deprecated_show_value_hack static Date: Tue, 4 Apr 2023 13:45:31 +0100 Message-Id: <6fddb814d85dcacfcd3de87404b722d52edcc89e.1680608960.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The deprecated_show_value_hack function is now only used inside cli-setshow.c, so lets make the function static to discourage its use anywhere else. There should be no user visible changes after this commit --- gdb/cli/cli-setshow.c | 2 +- gdb/command.h | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c index dad3e606620..07233e36a38 100644 --- a/gdb/cli/cli-setshow.c +++ b/gdb/cli/cli-setshow.c @@ -117,7 +117,7 @@ parse_cli_boolean_value (const char *arg) } -void +static void deprecated_show_value_hack (struct ui_file *ignore_file, int ignore_from_tty, struct cmd_list_element *c, diff --git a/gdb/command.h b/gdb/command.h index e9c9f160e1f..a4641bb1fd5 100644 --- a/gdb/command.h +++ b/gdb/command.h @@ -656,16 +656,11 @@ extern void complete_on_enum (completion_tracker &tracker, extern void help_list (struct cmd_list_element *, const char *, enum command_class, struct ui_file *); -/* Method for show a set/show variable's VALUE on FILE. If this - method isn't supplied deprecated_show_value_hack() is called (which - is not good). */ +/* Method for show a set/show variable's VALUE on FILE. */ typedef void (show_value_ftype) (struct ui_file *file, int from_tty, struct cmd_list_element *cmd, const char *value); -/* NOTE: i18n: This function is not i18n friendly. Callers should - instead print the value out directly. */ -extern show_value_ftype deprecated_show_value_hack; /* Various sets of extra literals accepted. */ extern const literal_def integer_unlimited_literals[];