diff mbox

[2/2] gdb: Make use of 'add_info' to create info sub-commands.

Message ID 6df01fb4f21fc58f93e403cae0e38836066f74d7.1447171209.git.andrew.burgess@embecosm.com
State New
Headers show

Commit Message

Andrew Burgess Nov. 10, 2015, 4:03 p.m. UTC
Switch to using 'add_info' function for creating basic info
sub-commands.

gdb/ChangeLog:

	* avr-tdep.c (_initialize_avr_tdep): Switch to 'add_info' for creating
	info sub-commands.
	* gnu-nat.c (add_task_commands): Likewise.
	* macrocmd.c (_initialize_macrocmd): Likewise.
---
 gdb/ChangeLog  |  7 +++++++
 gdb/avr-tdep.c |  5 ++---
 gdb/gnu-nat.c  | 25 ++++++++++---------------
 gdb/macrocmd.c | 15 ++++++---------
 4 files changed, 25 insertions(+), 27 deletions(-)

Comments

Kevin Buettner Nov. 10, 2015, 10:19 p.m. UTC | #1
On Tue, 10 Nov 2015 16:03:51 +0000
Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> Switch to using 'add_info' function for creating basic info
> sub-commands.
> 
> gdb/ChangeLog:
> 
> 	* avr-tdep.c (_initialize_avr_tdep): Switch to 'add_info' for creating
> 	info sub-commands.
> 	* gnu-nat.c (add_task_commands): Likewise.
> 	* macrocmd.c (_initialize_macrocmd): Likewise.

This change looks good too.  Go ahead and push it.

Kevin
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4316c95..2b12fb4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@ 
 2015-11-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 
+	* avr-tdep.c (_initialize_avr_tdep): Switch to 'add_info' for creating
+	info sub-commands.
+	* gnu-nat.c (add_task_commands): Likewise.
+	* macrocmd.c (_initialize_macrocmd): Likewise.
+
+2015-11-09  Andrew Burgess  <andrew.burgess@embecosm.com>
+
 	* cli/cli-decode.c (add_info): Switch to class_info.
 
 2015-11-09  Joel Brobecker  <brobecker@adacore.com>
diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c
index 9c54b2d..ccc8b45 100644
--- a/gdb/avr-tdep.c
+++ b/gdb/avr-tdep.c
@@ -1632,7 +1632,6 @@  _initialize_avr_tdep (void)
   /* FIXME: TRoth/2002-02-18: This should probably be changed to 'info avr
      io_registers' to signify it is not available on other platforms.  */
 
-  add_cmd ("io_registers", class_info, avr_io_reg_read_command,
-	   _("query remote avr target for io space register values"),
-	   &infolist);
+  add_info ("io_registers", avr_io_reg_read_command,
+	    _("query remote avr target for io space register values"));
 }
diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index d3f54d0..5e4d705 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -3264,21 +3264,16 @@  This is the same as setting `task pause', `exceptions', and\n\
 	   &setlist);
 
   /* Commands to show information about the task's ports.  */
-  add_cmd ("send-rights", class_info, info_send_rights_cmd,
-	   _("Show information about the task's send rights"),
-	   &infolist);
-  add_cmd ("receive-rights", class_info, info_recv_rights_cmd,
-	   _("Show information about the task's receive rights"),
-	   &infolist);
-  add_cmd ("port-rights", class_info, info_port_rights_cmd,
-	   _("Show information about the task's port rights"),
-	   &infolist);
-  add_cmd ("port-sets", class_info, info_port_sets_cmd,
-	   _("Show information about the task's port sets"),
-	   &infolist);
-  add_cmd ("dead-names", class_info, info_dead_names_cmd,
-	   _("Show information about the task's dead names"),
-	   &infolist);
+  add_info ("send-rights", info_send_rights_cmd,
+	    _("Show information about the task's send rights"));
+  add_info ("receive-rights", info_recv_rights_cmd,
+	    _("Show information about the task's receive rights"));
+  add_info ("port-rights", info_port_rights_cmd,
+	    _("Show information about the task's port rights"));
+  add_info ("port-sets", info_port_sets_cmd,
+	    _("Show information about the task's port sets"));
+  add_info ("dead-names", info_dead_names_cmd,
+	    _("Show information about the task's dead names"));
   add_info_alias ("ports", "port-rights", 1);
   add_info_alias ("port", "port-rights", 1);
   add_info_alias ("psets", "port-sets", 1);
diff --git a/gdb/macrocmd.c b/gdb/macrocmd.c
index aca4fdc..aae3b6d 100644
--- a/gdb/macrocmd.c
+++ b/gdb/macrocmd.c
@@ -522,21 +522,18 @@  expression work together to yield a pre-processed expression."),
 	   &macrolist);
   add_alias_cmd ("exp1", "expand-once", no_class, 1, &macrolist);
 
-  add_cmd ("macro", no_class, info_macro_command,
-	   _("Show the definition of MACRO, and it's source location.\n\
+  add_info ("macro", info_macro_command,
+	    _("Show the definition of MACRO, and it's source location.\n\
 Usage: info macro [-a|-all] [--] MACRO\n\
 Options: \n\
   -a, --all    Output all definitions of MACRO in the current compilation\
  unit.\n\
-  --           Specify the end of arguments and the beginning of the MACRO."),
+  --           Specify the end of arguments and the beginning of the MACRO."));
 
-	   &infolist);
-
-  add_cmd ("macros", no_class, info_macros_command,
-	   _("Show the definitions of all macros at LINESPEC, or the current \
+  add_info ("macros", info_macros_command,
+	    _("Show the definitions of all macros at LINESPEC, or the current \
 source location.\n\
-Usage: info macros [LINESPEC]"),
-	   &infolist);
+Usage: info macros [LINESPEC]"));
 
   add_cmd ("define", no_class, macro_define_command, _("\
 Define a new C/C++ preprocessor macro.\n\