From patchwork Thu Oct 3 11:29:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 34812 Received: (qmail 70393 invoked by alias); 3 Oct 2019 11:29:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70352 invoked by uid 89); 3 Oct 2019 11:29:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=boards, H*m:andrew, Setup, sk:ccwith X-HELO: mail-wm1-f52.google.com Received: from mail-wm1-f52.google.com (HELO mail-wm1-f52.google.com) (209.85.128.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 11:29:24 +0000 Received: by mail-wm1-f52.google.com with SMTP id f22so2010583wmc.2 for ; Thu, 03 Oct 2019 04:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=aQy6dxlHrcEYo1J0+PutNpsP1brZEQU003PWyuptaFQ=; b=OOHO6lDv85Sgu5A7zjCOD7q6Awgkf4hw6a21agYRfxknEnsAPUw/AV1SGTsmZeIhu/ 1XRsT/Ksd5uI3H5okEasGYZ1wspvs2TO836L/kN13ZNBOGA1pvrTEmoBb5lcfDfOaz9h Bc1Di+uoNE+KZkrxjFav6MKX6JlNAudSJA9p1g5qHvIwCa7hK3XfHag7S8Bg7x9+CqCc t2OwIcpjn4sDYt9Eq66JsPe/D4CoRJO0pBdO9U3FC/webrl+CI8/lBfIw0ChL68TjC30 C9ymNj61k4ESOarfSIWoJRdB7EZaIV61gHfJ+o1TJkEmQia3ZonJVfBYV+26ufN5xu+L n1FA== Return-Path: Received: from localhost (host86-128-12-122.range86-128.btcentralplus.com. [86.128.12.122]) by smtp.gmail.com with ESMTPSA id a3sm3394507wmc.3.2019.10.03.04.29.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Oct 2019 04:29:21 -0700 (PDT) From: Andrew Burgess To: gdb-patches Cc: Andrew Burgess Subject: [PATCHv2 1/4] gdb/testsuite: Allow cc-with-tweaks board file to be used with Fortran Date: Thu, 3 Oct 2019 12:29:14 +0100 Message-Id: <69f66e7b6d45dd19d1ed6317f0b71a71e390c96a.1570101531.git.andrew.burgess@embecosm.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes The board file cc-with-tweaks is used as the core for lots of other board files, for example cc-with-gdb-index and cc-with-debug-names. This commit extends cc-with-tweaks so that it will wrap the Fortran compiler, allowing for more test coverage. I tested all of the board files that make use of cc-with-tweaks running the gdb.fortran/*.exp test set, and in some cases I did see extra failures. The "standard" results are: === gdb Summary === # of expected passes 953 # of known failures 2 With board file 'cc-with-dwz-m': === gdb Summary === # of expected passes 903 # of unexpected failures 1 # of known failures 2 # of untested testcases 4 With board file 'dwarf4-gdb-index': === gdb Summary === # of expected passes 950 # of unexpected failures 3 # of known failures 2 With board file 'fission-dwp': === gdb Summary === # of expected passes 949 # of unexpected failures 4 # of known failures 2 Despite these extra failure I don't think this should prevent this change going in as these failures presumably already exist in GDB. gdb/testsuite/ChangeLog: * boards/cc-with-tweaks.exp: Setup F90_FOR_TARGET and F77_FOR_TARGET. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/boards/cc-with-tweaks.exp | 10 ++++++++++ 2 files changed, 15 insertions(+) diff --git a/gdb/testsuite/boards/cc-with-tweaks.exp b/gdb/testsuite/boards/cc-with-tweaks.exp index 371481477ae..dfca1ad94bb 100644 --- a/gdb/testsuite/boards/cc-with-tweaks.exp +++ b/gdb/testsuite/boards/cc-with-tweaks.exp @@ -43,6 +43,8 @@ process_multilib_options "" set found_gcc [find_gcc] set found_gxx [find_g++] set found_gnatmake [find_gnatmake] +set found_f90 [find_gfortran] +set found_f77 [find_g77] set_board_info compiler "$found_gcc" set contrib_dir [file normalize $srcdir/../contrib] @@ -58,6 +60,14 @@ if ![info exists GNATMAKE_FOR_TARGET] { set GNATMAKE_FOR_TARGET "$found_gnatmake" } set GNATMAKE_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $GNATMAKE_FOR_TARGET" +if ![info exists F90_FOR_TARGET] { + set F90_FOR_TARGET "$found_f90" +} +set F90_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $F90_FOR_TARGET" +if ![info exists F77_FOR_TARGET] { + set F77_FOR_TARGET "$found_f77" +} +set F77_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $F77_FOR_TARGET" set pwd [exec pwd -P] exec echo $GDB $INTERNAL_GDBFLAGS $GDBFLAGS \"\$@\" > $pwd/gdb.sh