From patchwork Tue Apr 11 12:53:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 19952 Received: (qmail 6778 invoked by alias); 11 Apr 2017 12:53:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 6757 invoked by uid 89); 11 Apr 2017 12:53:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40045.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 12:53:48 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0104.eurprd08.prod.outlook.com (10.160.211.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Tue, 11 Apr 2017 12:53:46 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660%14]) with mapi id 15.01.1019.025; Tue, 11 Apr 2017 12:53:46 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 1/11] Add ARM_MAX_REGISTER_SIZE Date: Tue, 11 Apr 2017 12:53:45 +0000 Message-ID: <69B1DAF3-68EB-4FC6-BCB5-A22860754FCE@arm.com> References: In-Reply-To: authentication-results: gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1; AM3PR08MB0104; 7:YVokKo7V9T4g/4Fa4kCuTLti0qwkHvJnvnfzJsAkplFCTyUDgxKtPBC1Zeo6LK83gbvzPwaClhCsYqeJLqzm7EMRcUdVrbROaWNpRBVSb1bWmXv9zqNm9yNfKxZGFiO1vAuwXTkVudyLzwfbOsGW6NJ3F6QoFXqXkOb42lRAD/hn6rNX62fjQKNHcDtt7SIzIS+j8kCCyNU0/7+VLHBVKd6tGDmdQ2zGOqOLsZ9TWd43waovPK7GUWDvm060o96z/J1w7Q8OVJAktYVpa1dmjcE8806XkqLr33kKiMFKZjxjwJnUoaAafWL3oxQg17gEtsDMEXuQvKHYASToPyq4MA== x-ms-office365-filtering-correlation-id: 62310819-4995-4e98-edfb-08d480d9ca99 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM3PR08MB0104; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:AM3PR08MB0104; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0104; x-forefront-prvs: 0274272F87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39400400002)(39850400002)(39450400003)(39860400002)(39410400002)(377454003)(24454002)(377424004)(2950100002)(6916009)(305945005)(189998001)(39060400002)(54906002)(6512007)(53936002)(86362001)(3280700002)(6246003)(110136004)(6486002)(38730400002)(99286003)(6116002)(6506006)(5660300001)(6436002)(3660700001)(3846002)(102836003)(229853002)(33656002)(4326008)(97736004)(2906002)(2900100001)(36756003)(8676002)(7736002)(81166006)(8936002)(1411001)(5250100002)(82746002)(66066001)(25786009)(76176999)(50986999)(53546009)(83716003)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0104; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2017 12:53:45.8914 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0104 > On 5 Apr 2017, at 10:30, Yao Qi wrote: > > On Tue, Apr 4, 2017 at 11:11 AM, Alan Hayward wrote: >> Max size set to 96bits, which is taken from FP_REGISTER_SIZE >> > >> @@ -8153,7 +8153,7 @@ arm_store_return_value (struct type *type, struct regcache *regs, >> >> if (TYPE_CODE (type) == TYPE_CODE_FLT) >> { >> - gdb_byte buf[MAX_REGISTER_SIZE]; >> + gdb_byte buf[ARM_MAX_REGISTER_SIZE]; >> >> switch (gdbarch_tdep (gdbarch)->fp_model) >> { >> > > "buf" is only used for PFA register, and its size is FP_REGISTER_SIZE > so why don't we do "buf[FP_REGISTER_SIZE]? > > @@ -8160,11 +8177,10 @@ arm_store_return_value (struct type *type, > struct regcache *regs, like this, > > if (TYPE_CODE (type) == TYPE_CODE_FLT) > { > - gdb_byte buf[MAX_REGISTER_SIZE]; > - > switch (gdbarch_tdep (gdbarch)->fp_model) > { > case ARM_FLOAT_FPA: > + gdb_byte buf[FP_REGISTER_SIZE]; > > convert_to_extended (floatformat_from_type (type), buf, valbuf, > gdbarch_byte_order (gdbarch)); > -- > Yao (齐尧) Pushed with change as requested. 2017-04-11 Alan Hayward * arm-tdep.c (arm_store_return_value): Use FP_REGISTER_SIZE Alan. diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 9be79437941af89b877fff04dd4fa9f98f480693..5cc3f402e7eb3f1a3559a1b11d52a4d825f4cf05 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -8160,7 +8160,7 @@ arm_store_return_value (struct type *type, struct regcache *regs, if (TYPE_CODE (type) == TYPE_CODE_FLT) { - gdb_byte buf[MAX_REGISTER_SIZE]; + gdb_byte buf[FP_REGISTER_SIZE]; switch (gdbarch_tdep (gdbarch)->fp_model) {