From patchwork Thu Sep 22 08:25:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 57887 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE99B385C33A for ; Thu, 22 Sep 2022 08:28:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE99B385C33A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1663835339; bh=uhI+j6CF7m0EHc/EauSt1STphYjgwk+jyFcRPlSsd9M=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CJDl/MZjzbey91qfN4wlsxMURy9m2wOMRRHFworCRup9942rzsXgcMwx/41P7q1b7 W7NH+eAyZhx5s7m2nyRP/O0cqXBxN5MEkJW+KdpsSmgzfC+5fPXjk9K8gD1Sd4/yFt ld9uSZgDGIc8JvaIJhd3khxSZ+VoOSkXFM2apuoI= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 246BB3858012; Thu, 22 Sep 2022 08:26:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 246BB3858012 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6EDEE300089; Thu, 22 Sep 2022 08:26:21 +0000 (UTC) To: Tsukasa OI , Pedro Alves , Joel Brobecker , Enze Li Subject: [PATCH v2 3/4] gdb/unittests: PR28413, suppress warnings generated by Gnulib Date: Thu, 22 Sep 2022 08:25:46 +0000 Message-Id: <667cafec3594a5eb180aee68f8c3adf1531addd3.1663835104.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Gnulib generates a warning if the system version of certain functions are used (to redirect the developer to use Gnulib version). It caused a compiler error when... - Compiled with Clang - -Werror is specified (by default) - C++ standard used by Clang is before C++17 (by default as of 15.0.0) when this unit test is activated. This issue is raised as PR28413. However, previous proposal to fix this issue (a "fix" to Gnulib): was rejected because it ruins the intent of Gnulib warnings. So, we need a Binutils/GDB-side solution. This commit tries to deal with this issue on the GDB side. We have "include/diagnostics.h" to disable certain warnings only when necessary. This commit suppresses the Gnulib warnings by adding DIAGNOSTIC_IGNORE_USER_DEFINED_WARNINGS before including "defs.h". gdb/ChangeLog: pr 28413 * unittests/string_view-selftests.c: Suppress Gnulib-generated warnings when "defs.h" is included. Reviewed-by: Enze Li --- gdb/unittests/string_view-selftests.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdb/unittests/string_view-selftests.c b/gdb/unittests/string_view-selftests.c index 2d7261d18d3..c1f7799d94c 100644 --- a/gdb/unittests/string_view-selftests.c +++ b/gdb/unittests/string_view-selftests.c @@ -23,7 +23,12 @@ #define GNULIB_NAMESPACE gnulib +#include "diagnostics.h" + +DIAGNOSTIC_PUSH +DIAGNOSTIC_IGNORE_USER_DEFINED_WARNINGS #include "defs.h" +DIAGNOSTIC_POP #include "gdbsupport/selftest.h" #include "gdbsupport/gdb_string_view.h"