From patchwork Mon Feb 17 16:57:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aktemur, Tankut Baris" X-Patchwork-Id: 38147 Received: (qmail 114098 invoked by alias); 17 Feb 2020 16:59:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113610 invoked by uid 89); 17 Feb 2020 16:59:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 16:59:28 +0000 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 08:59:27 -0800 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga005.fm.intel.com with ESMTP; 17 Feb 2020 08:59:25 -0800 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 01HGxPcR028249; Mon, 17 Feb 2020 16:59:25 GMT Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 01HGxPOF027228; Mon, 17 Feb 2020 17:59:25 +0100 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 01HGxPow027224; Mon, 17 Feb 2020 17:59:25 +0100 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: palves@redhat.com Subject: [PATCH v2 33/58] gdbserver: turn target op 'handle_monitor_command' into a method Date: Mon, 17 Feb 2020 17:57:41 +0100 Message-Id: <635d533a1e7f18a778bbb38e40b233fb21cef079.1581956646.git.tankut.baris.aktemur@intel.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes gdbserver/ChangeLog: 2020-02-10 Tankut Baris Aktemur Turn process_stratum_target's handle_monitor_command op into a method of process_target. * target.h (struct process_stratum_target): Remove the target op. (class process_target): Add the target op. (target_handle_monitor_command): Update the macro. * target.cc (process_target::handle_monitor_command): Define. Update the derived classes and callers below. * server.cc (handle_query): Update. * linux-low.cc (linux_target_ops): Update. (linux_process_target::handle_monitor_command): Define. * linux-low.h (class linux_process_target): Update. * lynx-low.cc (lynx_target_ops): Update. * nto-low.cc (nto_target_ops): Update. * win32-low.cc (win32_target_ops): Update. --- gdbserver/linux-low.cc | 15 ++++++++++----- gdbserver/linux-low.h | 2 ++ gdbserver/lynx-low.cc | 1 - gdbserver/nto-low.cc | 1 - gdbserver/server.cc | 3 +-- gdbserver/target.cc | 6 ++++++ gdbserver/target.h | 8 ++++---- gdbserver/win32-low.cc | 1 - 8 files changed, 23 insertions(+), 14 deletions(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 623499190d4..5fb38819e61 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -6394,6 +6394,16 @@ linux_process_target::handle_new_gdb_connection () }); } +int +linux_process_target::handle_monitor_command (char *mon) +{ +#ifdef USE_THREAD_DB + return thread_db_handle_monitor_command (mon); +#else + return 0; +#endif +} + static int linux_supports_disable_randomization (void) { @@ -7425,11 +7435,6 @@ linux_get_hwcap2 (int wordsize) static linux_process_target the_linux_target; static process_stratum_target linux_target_ops = { -#ifdef USE_THREAD_DB - thread_db_handle_monitor_command, -#else - NULL, -#endif linux_common_core_of_thread, linux_read_loadmap, linux_process_qsupported, diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h index aa3baf3327f..d3157220730 100644 --- a/gdbserver/linux-low.h +++ b/gdbserver/linux-low.h @@ -373,6 +373,8 @@ public: bool supports_exec_events () override; void handle_new_gdb_connection () override; + + int handle_monitor_command (char *mon) override; }; #define get_thread_lwp(thr) ((struct lwp_info *) (thread_target_data (thr))) diff --git a/gdbserver/lynx-low.cc b/gdbserver/lynx-low.cc index f19713981bc..d489886755e 100644 --- a/gdbserver/lynx-low.cc +++ b/gdbserver/lynx-low.cc @@ -735,7 +735,6 @@ static lynx_process_target the_lynx_target; /* The LynxOS target_ops vector. */ static process_stratum_target lynx_target_ops = { - NULL, /* handle_monitor_command */ NULL, /* core_of_thread */ NULL, /* read_loadmap */ NULL, /* process_qsupported */ diff --git a/gdbserver/nto-low.cc b/gdbserver/nto-low.cc index 3cb0f638f20..9cd30da32e6 100644 --- a/gdbserver/nto-low.cc +++ b/gdbserver/nto-low.cc @@ -947,7 +947,6 @@ nto_sw_breakpoint_from_kind (int kind, int *size) static nto_process_target the_nto_target; static process_stratum_target nto_target_ops = { - NULL, /* handle_monitor_command */ NULL, /* core_of_thread */ NULL, /* read_loadmap */ NULL, /* process_qsupported */ diff --git a/gdbserver/server.cc b/gdbserver/server.cc index f427e7706fb..f9817881d77 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -2577,8 +2577,7 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p) write_ok (own_buf); - if (the_target->handle_monitor_command == NULL - || (*the_target->handle_monitor_command) (mon) == 0) + if (the_target->pt->handle_monitor_command (mon) == 0) /* Default processing. */ handle_monitor_command (mon, own_buf); diff --git a/gdbserver/target.cc b/gdbserver/target.cc index 3416a3f449f..74cd90a48a4 100644 --- a/gdbserver/target.cc +++ b/gdbserver/target.cc @@ -577,3 +577,9 @@ process_target::handle_new_gdb_connection () { /* Nop. */ } + +int +process_target::handle_monitor_command (char *mon) +{ + return 0; +} diff --git a/gdbserver/target.h b/gdbserver/target.h index b6150631674..b607ca62540 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -70,10 +70,6 @@ class process_target; shared code. */ struct process_stratum_target { - /* If not NULL, target-specific routine to process monitor command. - Returns 1 if handled, or 0 to perform default processing. */ - int (*handle_monitor_command) (char *); - /* Returns the core given a thread, or -1 if not known. */ int (*core_of_thread) (ptid_t); @@ -486,6 +482,10 @@ public: /* Allows target to re-initialize connection-specific settings. */ virtual void handle_new_gdb_connection (); + + /* The target-specific routine to process monitor command. + Returns 1 if handled, or 0 to perform default processing. */ + virtual int handle_monitor_command (char *mon); }; extern process_stratum_target *the_target; diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 024479d1540..fcb3906197d 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -1852,7 +1852,6 @@ win32_sw_breakpoint_from_kind (int kind, int *size) static win32_process_target the_win32_target; static process_stratum_target win32_target_ops = { - NULL, /* handle_monitor_command */ NULL, /* core_of_thread */ NULL, /* read_loadmap */ NULL, /* process_qsupported */