From patchwork Wed Jun 7 08:37:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 20820 Received: (qmail 44133 invoked by alias); 7 Jun 2017 08:37:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 44026 invoked by uid 89); 7 Jun 2017 08:37:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1508 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0064.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.64) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 08:37:18 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0102.eurprd08.prod.outlook.com (10.160.211.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12; Wed, 7 Jun 2017 08:37:20 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::f0a8:fd0f:69e1:e280]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::f0a8:fd0f:69e1:e280%17]) with mapi id 15.01.1157.012; Wed, 7 Jun 2017 08:37:20 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: Remove MAX_REGISTER_SIZE from aarch64-tdep.c Date: Wed, 7 Jun 2017 08:37:19 +0000 Message-ID: <60390C6C-732F-428F-BCD0-57914872401E@arm.com> authentication-results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM3PR08MB0102; 7:1P1dIHqKLXh/KwacWamBQeSXt9hv0gIDhqRPV9Bm61G/NAWVFn2oDfykoXIHRPQaQEt9CFtXc/qp2qHBZwtPnmVExI2V3vzZWh1Yefn1jwQ674yjxpMUYMm4AFj6Kf/gUsPUX1/5f6BMpQnyI+7M3HJIIrn7f/5Zo+qwe8XK0AGEkC+DCFGjDjFvYj2dgdSzgE0u2kA6WrK6FMI1OzUSZnyDhxPUCE8F7aUdsXFDKHwO3FLQd+2b3IpWXtQ2H4Mrc6KLTLN+6uIOgUrLMB1+nwoZ4OQRcQ3Shn50vOFWsf54OOcqQTdSzgESa8y0clDXGHgi1eNM/w94gggmJHSIaA== x-ms-traffictypediagnostic: AM3PR08MB0102: x-ms-office365-filtering-correlation-id: 9eeb3d90-767f-4ac3-3561-08d4ad80694e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM3PR08MB0102; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(131327999870524); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(20161123558100)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR08MB0102; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR08MB0102; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39840400002)(39400400002)(39860400002)(39450400003)(39410400002)(377424004)(7736002)(54356999)(4326008)(508600001)(72206003)(6916009)(305945005)(6486002)(6506006)(5640700003)(3280700002)(25786009)(3660700001)(6436002)(99286003)(36756003)(6512007)(38730400002)(189998001)(110136004)(81166006)(50986999)(2351001)(53936002)(8936002)(2900100001)(66066001)(6116002)(102836003)(3846002)(33656002)(8676002)(2906002)(5250100002)(2501003)(5660300001)(83716003)(82746002)(86362001)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0102; H:AM3PR08MB0101.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2017 08:37:19.7891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0102 Simply uses V_REGISTER_SIZE within the pseudo read/write functions. Tested on aarch64. Tested on a --enable-targets=all and asan build using make check with board files unix, native-gdbserver and unittest. Ok to commit? Alan 2017-06-07 Alan Hayward * aarch64-tdep.c (aarch64_store_return_value): Use V_REGISTER_SIZE. (aarch64_pseudo_read_value): Likewise. (aarch64_pseudo_write): Likewise. diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 000540a4f52b4a856e9b88afef8395b52d7612c9..a5db6ed29d90e3166f885cd1367214fab669818f 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -1987,7 +1987,7 @@ aarch64_store_return_value (struct type *type, struct regcache *regs, for (i = 0; i < elements; i++) { int regno = AARCH64_V0_REGNUM + i; - bfd_byte tmpbuf[MAX_REGISTER_SIZE]; + bfd_byte tmpbuf[V_REGISTER_SIZE]; if (aarch64_debug) { @@ -2241,7 +2241,7 @@ aarch64_pseudo_read_value (struct gdbarch *gdbarch, struct regcache *regcache, int regnum) { - gdb_byte reg_buf[MAX_REGISTER_SIZE]; + gdb_byte reg_buf[V_REGISTER_SIZE]; struct value *result_value; gdb_byte *buf; @@ -2336,7 +2336,7 @@ static void aarch64_pseudo_write (struct gdbarch *gdbarch, struct regcache *regcache, int regnum, const gdb_byte *buf) { - gdb_byte reg_buf[MAX_REGISTER_SIZE]; + gdb_byte reg_buf[V_REGISTER_SIZE]; /* Ensure the register buffer is zero, we want gdb writes of the various 'scalar' pseudo registers to behavior like architectural