From patchwork Tue Jan 9 14:26:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 83644 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 40FFC385803E for ; Tue, 9 Jan 2024 14:30:04 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D4A7838582B5 for ; Tue, 9 Jan 2024 14:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4A7838582B5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4A7838582B5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704810417; cv=none; b=f9VETIQDMQLnBao5qyxD9n3BUZkPR8iQFxpbOLWMSDdsSe/4KiIJXuaLR9Di44DT8jSgIHHRM1nhu6J+qpYVB0XezbNNYd1HuRCQlbiGGmN5RhdEYjS35IZ2yagMk9s24HjO8oImy4SmXgrIg1n5gRJdEem11dUV/wDFrUI5d5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704810417; c=relaxed/simple; bh=9e3YG20+Bg/QD7ahk4+iY7SqS+p/dwWcM2ptkPRsTxw=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=koGUyvRiFVviPAc+r7d7Lt5Pqptxid7cZWgMLelnXsYf4WMxPuxnBDS9caLGRCvcjOUiLI+ebVJz6PpUfyDq3zTynsFYyaPAvMgeKRWEgtAIi0cd1WPEmWLAn5gJkuluKUEuO3zGEF9rtT1LqErJXAGti3yF0HspurOSbFw/2w4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704810414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hm8OAfOZDKD3hRcj8lXuncqR9EduzO4VR18/S8IjDrA=; b=ABlDm2grAO/TNsLFK+PNCVtR7na4yA7J1hqRtSaXaZvD9w/Zcm97tHAjBaAfNgn99hFz2C 9M10sm6qhYkQZTVammPrWfv3wt8lKcuiUnvPm1eA8//gTLyOzRdHp8J/POtQy6B2vmo+MJ /Jmp3b4jOHGJUKvKLxYfCiy59y1TjzQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-L3AmIVJbMWmougZj9WS1SQ-1; Tue, 09 Jan 2024 09:26:47 -0500 X-MC-Unique: L3AmIVJbMWmougZj9WS1SQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40d8032afffso23031445e9.1 for ; Tue, 09 Jan 2024 06:26:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704810405; x=1705415205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hm8OAfOZDKD3hRcj8lXuncqR9EduzO4VR18/S8IjDrA=; b=j6UE9vOrTdEdHr6+eqhQEI+shZixO0lAkzqgL6lNwDcK3vlFzpF/UASunwu/Sj85a4 UGwDg5bTbuL6YuMc5TKDd+KwZXNiSflw0rLuHwjXIeSXInzLClxnT5eLXeuoO7Ate3wD 6IoOqsCUnupg2oywhV8LtW3asAMWk6UWrlQKzS9ElTKEZ0EcNwVB8Ve1HzA+xcpooBPB 4bW/vdK/PhmITSOHFhm/tDSnYsTacUljf9yhIqfubzscbjyfyjwA85vhCA1TVJPtMsR+ qXTb7yj8f6cn6sS9B+Q0Q5GDMNcIYElrcXvI6Z6kUIAlXG8AWenmpA7Yr3h+tgdSXgtv rP7g== X-Gm-Message-State: AOJu0Yy2v9uJ6j5nRSYrLSaYU7GIiuyo8zA8Dm4GumwwCn4Fx3/hWyXQ vbYRPzgWecdTCS7N/biWkcEoic0T6CsXDuecZ+3VrHfswFdXNUuQsRXfXgkobRK/BKcMGqYa9UU MCVSkY+KwZfP9yJ1kWDRNE+k/C01S8/uA6PCs98+7A6Ngeb6iQI0DxmSJ0LFAoto/uRMxALSOgb kpLpjKVoShjHrmSQ== X-Received: by 2002:a05:600c:19d3:b0:40d:8a22:cc7 with SMTP id u19-20020a05600c19d300b0040d8a220cc7mr1364479wmq.175.1704810405229; Tue, 09 Jan 2024 06:26:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFl3jXc1eRfjaDoCrp1NvHke+ctZz6DKkvSXuhSwm9Cdi4RA4ewd3/y72K6DwJdYZKtbDWo7A== X-Received: by 2002:a05:600c:19d3:b0:40d:8a22:cc7 with SMTP id u19-20020a05600c19d300b0040d8a220cc7mr1364474wmq.175.1704810404890; Tue, 09 Jan 2024 06:26:44 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id g11-20020a05600c4ecb00b0040d8810efc9sm15067233wmq.17.2024.01.09.06.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 06:26:44 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , Michael Weghorn Subject: [PATCH 02/16] gdb/testsuite: add some xfail in gdb.base/startup-with-shell.exp Date: Tue, 9 Jan 2024 14:26:25 +0000 Message-Id: <5808a3f3b76fc376d908b820a28151553462a40f.1704809585.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org There are two tests that fail in gdb.base/startup-with-shell.exp when using the native-extended-remote board. I plan to fix these issues in this series, but not straight away. It is easier to test each patch if I can just check for no unexpected failures, so first lets mark the currently failing tests as xfail. This change will be removed by the end of this series, at which point the tests will be passing. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28392 --- gdb/testsuite/gdb.base/startup-with-shell.exp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp index 51b1e4fa922..f3ad4ec4cbb 100644 --- a/gdb/testsuite/gdb.base/startup-with-shell.exp +++ b/gdb/testsuite/gdb.base/startup-with-shell.exp @@ -55,10 +55,19 @@ proc initial_setup_simple { startup_with_shell run_args } { } } +# Are we using 'remote' or 'extended-remote' protocol? +set is_remote_p [expr [string equal [target_info gdb_protocol] \ + "remote"] \ + || [string equal [target_info gdb_protocol] \ + "extended-remote"]] + ## Run the actual tests with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" { initial_setup_simple "on" "$unique_file_dir/*.unique-extension" + if { $is_remote_p } { + setup_xfail "*-*-*" gdb/28392 + } gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file\"" \ "first argument expanded" } @@ -72,6 +81,9 @@ with_test_prefix "startup_with_shell = off; run_args = *.unique-extension" { with_test_prefix "startup_with_shell = on; run_args = \$TEST" { set env(TEST) "1234" initial_setup_simple "on" "\$TEST" + if { $is_remote_p } { + setup_xfail "*-*-*" gdb/28392 + } gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"1234\"" \ "testing first argument" unset env(TEST)