Remove MAX_REGISTER_SIZE define
Commit Message
Many thanks to Yao for helping me remove all the other uses of
MAX_REGISTER_SIZE over the last year or so!
This patch removes the last uses of MAX_REGISTER_SIZE and deletes the define.
Built on x86 and aarch64. Grepped to ensured no more stray
MAX_REGISTER_SIZEs left in the code.
Alan
2018-03-07 Alan Hayward <alan.hayward@arm.com>
* defs.h: Remove MAX_REGISTER_SIZE
* regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
asserts.
* python/py-unwind.c (pyuw_sniffer): Likewise.
Comments
On Wed, Mar 7, 2018 at 3:53 PM, Alan Hayward <Alan.Hayward@arm.com> wrote:
> 2018-03-07 Alan Hayward <alan.hayward@arm.com>
>
> * defs.h: Remove MAX_REGISTER_SIZE
> * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
> asserts.
> * python/py-unwind.c (pyuw_sniffer): Likewise.
>
Patch is good to me.
@@ -531,11 +531,6 @@ enum symbol_needs_kind
/* Dynamic target-system-dependent parameters for GDB. */
#include "gdbarch.h"
-/* * Maximum size of a register. Something small, but large enough for
- all known ISAs. If it turns out to be too small, make it bigger. */
-
-enum { MAX_REGISTER_SIZE = 64 };
-
/* In findvar.c. */
template<typename T, typename = RequireLongest<T>>
@@ -583,7 +583,6 @@ pyuw_sniffer (const struct frame_unwind *self, struct frame_info *this_frame,
/* `value' validation was done before, just assert. */
gdb_assert (value != NULL);
gdb_assert (data_size == TYPE_LENGTH (value_type (value)));
- gdb_assert (data_size <= MAX_REGISTER_SIZE);
cached_frame->reg[i].data = (gdb_byte *) xmalloc (data_size);
memcpy (cached_frame->reg[i].data, value_contents (value), data_size);
@@ -117,7 +117,6 @@ init_regcache_descr (struct gdbarch *gdbarch)
descr->sizeof_register[i] = TYPE_LENGTH (descr->register_type[i]);
descr->register_offset[i] = offset;
offset += descr->sizeof_register[i];
- gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]);
}
/* Set the real size of the raw register cache buffer. */
descr->sizeof_raw_registers = offset;
@@ -127,7 +126,6 @@ init_regcache_descr (struct gdbarch *gdbarch)
descr->sizeof_register[i] = TYPE_LENGTH (descr->register_type[i]);
descr->register_offset[i] = offset;
offset += descr->sizeof_register[i];
- gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]);
}
/* Set the real size of the readonly register cache buffer. */
descr->sizeof_cooked_registers = offset;