RFA: AArch64 sim: Add support for the MRS instruction
Commit Message
Hi Mike,
>> PS. I would be happy to be a maintainer for the AArch64 sim, if that is
>> agreeable.
>
> sounds fine
Great - in which case is it OK to check in the attached patch ?
>> +static uint64_t
>> +system_get (sim_cpu * cpu, unsigned op0, unsigned op1, unsigned crn,
>
> no space after the "*"
Oops.
>> +static void
>> +do_mrs (sim_cpu * cpu)
>
> same here
Doh.
>> + /*
>> if (uimm (aarch64_get_instr (cpu), 21, 20) == 0x1)
>> - /* MSR <sys-reg>, <Xreg>. */
>> - return;
>> + do_msr (cpu); */
>> HALT_NYI;
>> + return;
>
> should there be a TODO or some other note explaining why the code
> is commented out ?
Yes - the comment was intended to indicate that this is where the
implementation of the MSR instruction should begin, but only if bit 21
is clear and bit 20 is set.
I have checked in a revised version of the patch with the changes you
suggested.
Cheers
Nick
Comments
On 15 Dec 2015 11:04, Nick Clifton wrote:
> >> PS. I would be happy to be a maintainer for the AArch64 sim, if that is
> >> agreeable.
> >
> > sounds fine
>
> Great - in which case is it OK to check in the attached patch ?
sure
-mike
@@ -13,6 +13,7 @@ Mike Frysinger vapier@gentoo.org
Maintainers for particular sims:
+aarch64 Nick Clifton <nickc@redhat.com>
arm Nick Clifton <nickc@redhat.com>
bfin Mike Frysinger <vapier@gentoo.org>
cr16 M R Swami Reddy <MR.Swami.Reddy@nsc.com>